Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1566031rwd; Thu, 1 Jun 2023 18:28:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7rEwRslWfPQ9Cqavn7Oa9Tmj730C5INyCJQ6Iia7iH/sVIjKq80QwJmiFjOHApV3NrsKsx X-Received: by 2002:a17:902:b18e:b0:1ac:66c4:6071 with SMTP id s14-20020a170902b18e00b001ac66c46071mr578881plr.57.1685669303719; Thu, 01 Jun 2023 18:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685669303; cv=none; d=google.com; s=arc-20160816; b=UKZ32z2MX1w4GT2HOCGZlbJP9DpBmmwGQp8pornCTS1tt2uGZgqEdU0tyRVlrn17Gd rXs1PS1nzwl//bTs5FBmsB9AHpygGTV4WGZ3gOYRQZrpUXmSpNXhdOzsyrt59JxnFAAS 1RgOyZLax4LT0ix8AGO58BRPasI0YE9c63l0OuQ9ENVhX1mSZNGUi/woV63nAQX/cEKn 8sNVcP9pgmFr2mephcC49d+GvYHO44Tl6+9BLRQ0kaMqO59kYqNzSRRH+ThQgibiqC2k n+VDfZDbX6DCVzmAyk96Td36iKT/oRh//bOKwxYEYiFoxocNF/FZbOaQaIthh1/pmu/3 uKxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=fDgd2gotor4ZR8cqfCrVsmiIAEV2vs7BB2zp4kNLJPc=; b=KA0jlQKj4Wlxeqgp8dOD73GT6XSY/CKMQI5v8Sdudt8jADug/KJ2xv83QnSNjjCYq/ OD3TVgtTWP9ZUXIUsBSkGOp953QPhdp10Lk7wslGTqpRctaP3ZsqbvLA3wpfjtulS/KT y73HczaXqNV0DMfCX9fpac3VgRikyh0wHlkiNiXtJsAsIwwsvMpftU5UAV+reFXkCJ8n uPoet7TJRcWcXRL8Pt5aq61m/R4W4WwjUywEeB5WxJofOGP+s4Qcc/dWrGkrgZhoBayV IICYzEi+BEbag+lFLtv0iP12vw7HjNhKes8bOhtYpHJtYYdDp+/01LGKxXsJby58qwKB xQIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=pWAmJFh3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e21-20020a170902d39500b001a9baadecc0si56169pld.160.2023.06.01.18.28.09; Thu, 01 Jun 2023 18:28:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=pWAmJFh3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233473AbjFBBXS (ORCPT + 99 others); Thu, 1 Jun 2023 21:23:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233480AbjFBBXQ (ORCPT ); Thu, 1 Jun 2023 21:23:16 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC098E45 for ; Thu, 1 Jun 2023 18:23:04 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-256563a2097so667135a91.0 for ; Thu, 01 Jun 2023 18:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685668984; x=1688260984; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fDgd2gotor4ZR8cqfCrVsmiIAEV2vs7BB2zp4kNLJPc=; b=pWAmJFh3nGZ3XxQM7dBmf1+v2k6ehvlxXGidXMvm1s19HS+8M0tAvhMEdMZen45J2p o89UsftScXkJZ4xodlztX7r7J4Vo9/ZeH4lU1YGROBA6svmK5gjcT2HIHjhR3InifNMc FOw2LbaXrMaoCLaUcp56oriTt9toCPCKa+OgV8l90PhxL06KA/36NeNJAr1L1LIB3MOS TZ2ecDTpi/lora9QXFE5xtlLgjukbnjBGCqQDm2Qcg9ha2yHnTMRzW6LSvu7QF7KWvOs w1tYW4udIMl7d8TIs1CDK+lhshz2+PoOm6YI2heB4Egws2T1Hprc367aAhhkMXwgLmtN hDWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685668984; x=1688260984; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fDgd2gotor4ZR8cqfCrVsmiIAEV2vs7BB2zp4kNLJPc=; b=TxTgKBAcfvweEZQxqHX3b+szskR0Tgl7KvPRt98RdaKED0Oj0dyoZwN/LZji94f9di dj8vTxdiDKuFaTWH1qWsulOa+CRjR2sM/xsX3f/pfZ1U/B9VaHGwUfqSsFY2Xi4yTZ5u ZThGpJIf3yt1j1LfJRVk3x5QYVHOmqOglEI5uhRTehUmvC/jVuivjPJ7l/08xuFpGTBq F+yQJsYb7Ag6q5GFDB52U0CKcWVRT3cm/65QuOAvSaVupAr47Yt3x3fvzHLXiY54Bocr jOWrOcFy6pDVQMzbUDvYL1eITceyYoUuftpDZp8WYhqZ3Wf0rS6i9+Wag7oSEFkBTWLf Z+xA== X-Gm-Message-State: AC+VfDxwugTYaps4exWewp7Arvjmp83jXATo+FDPp37msNuW0WRkIpsl OQooKvrc9pn4EoWq2d1t5QRSrIAlCzw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:11cd:b0:255:7a07:9e63 with SMTP id gv13-20020a17090b11cd00b002557a079e63mr201828pjb.3.1685668984352; Thu, 01 Jun 2023 18:23:04 -0700 (PDT) Date: Thu, 1 Jun 2023 18:22:46 -0700 In-Reply-To: <20230425113932.3148-1-ubizjak@gmail.com> Mime-Version: 1.0 References: <20230425113932.3148-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog Message-ID: <168512497255.2748559.4747399178242270011.b4-ty@google.com> Subject: Re: [PATCH] KVM: x86/mmu: Add comment on try_cmpxchg64 usage in tdp_mmu_set_spte_atomic From: Sean Christopherson To: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Uros Bizjak Cc: Paolo Bonzini , David Matlack Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Apr 2023 13:39:32 +0200, Uros Bizjak wrote: > Commit aee98a6838d5 ("KVM: x86/mmu: Use try_cmpxchg64 in > tdp_mmu_set_spte_atomic") removed the comment that iter->old_spte is > updated when different logical CPU modifies the page table entry. > Although this is what try_cmpxchg does implicitly, it won't hurt > if this fact is explicitly mentioned in a restored comment. > > > [...] Applied to kvm-x86 mmu, thanks! [1/1] KVM: x86/mmu: Add comment on try_cmpxchg64 usage in tdp_mmu_set_spte_atomic https://github.com/kvm-x86/linux/commit/12ced095956a -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes