Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Fri, 2 Jun 2023 04:32:00 +0300
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     albeu@free.fr, linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: ath79: Add missing check for platform_get_irq
Message-ID: <ZHlGkM0O0IT1U7Fl@surfacebook>
References: <20230601085132.12508-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230601085132.12508-1-jiasheng@iscas.ac.cn>
Precedence: bulk

Thu, Jun 01, 2023 at 04:51:32PM +0800, Jiasheng Jiang kirjoitti:
> Add the missing check for platform_get_irq and return error
> if it fails.

>  		girq->parents[0] = platform_get_irq(pdev, 0);
> +		if (girq->parents[0] < 0)
> +			return -ENODEV;

Can you elaborate why error code has to be shadowed (overriden)?

-- 
With Best Regards,
Andy Shevchenko