Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1580977rwd; Thu, 1 Jun 2023 18:47:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5VoUGtmsMjFo+rEdRURX1hrUyXV9K/Ow7OGXAA8Fwb2bhQhq3htJu7Jbf+A1mi20F3Cazb X-Received: by 2002:a05:6a20:918a:b0:10b:7400:cef7 with SMTP id v10-20020a056a20918a00b0010b7400cef7mr13243178pzd.17.1685670425249; Thu, 01 Jun 2023 18:47:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685670425; cv=none; d=google.com; s=arc-20160816; b=GAZhePe+j2disHEvkoTQhWqgLX3dhq0Ti+ccOqxOpj8HMKsIbD69F6lb+P2SIU/R6f xitcj3nQEoPKXNmovQN6Iow+ESsiZ8HyFi3/ObguXv0qNR47M3TB8i/ocQtIdug5L1e3 0UymVQsaDZJoRbwikjSGvvcPbQkMueXLAv2SL44uH81kG9Eu00EaTLkKlW86O7KTO0DI YuGH1DnDAF2ZinMjeROCRfL2Bo+bkMncIDcRaSaItsmJ2YKgKNqEBuch110gSHcpe5PP o7+70zCVGc05fgRDrdBAUyeqL0LJ9UkAKy7Ecw9VfCczbpQEUW2hIiupNbfTWc8X6MwK 3hSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=/cMHIbrTWtgBUsYlhuC2ZhD157W4Z46c619IAlhaVOY=; b=X649QscbKkoZb/nv4yJ7DBsjZQnkJVw6hSddGKZ8irZAKllS2nZtcXdX9h1Ryh1p5I XxIri/nzrnd4jTEpdgsB0CkY9ZP84QMBSMZsuoKIUrK6ut4WAsNWgvpU/ZVKAxU5KTj1 48q78IpPjugJQruxqvNtWbIzhX2k6spP0TALedqTjW/nhBX+n7G/UB2dS/d3b5/etOwm KzzaLX4jQfANCISK1xxqlfnTBPeyViT7zp4zN91jPiSZhiIS6woYQvN3FX9olTCP5Pda ZX3O57/KiufVhMqq/Yv8WyENz5XbdG7zEvVYxrSMPsM988+CEVkdEhh1hXUM4CS4/uQ/ RuFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b1iDfAMJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az9-20020a056a02004900b0053f32b910c1si138495pgb.700.2023.06.01.18.46.53; Thu, 01 Jun 2023 18:47:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b1iDfAMJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbjFBBba (ORCPT + 99 others); Thu, 1 Jun 2023 21:31:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232292AbjFBBb2 (ORCPT ); Thu, 1 Jun 2023 21:31:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 763F6198 for ; Thu, 1 Jun 2023 18:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685669446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/cMHIbrTWtgBUsYlhuC2ZhD157W4Z46c619IAlhaVOY=; b=b1iDfAMJiI7544cv6P8+/ob0/fVsS7mNbJ19KyvUH4PQZdohoeEL0uee4oj64UDBihwrio /tfcGbi9KwRNJaeG9LbCxkxuCZ7bCsI/q1oocmS5Zbg8U0rBupiv4WPrq9hjGRd7eFi97P IwPwS5v12WsQnqU4/VFEjm5unRQ/L3g= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-zRBlaODHPZm4kq_rKHyRUA-1; Thu, 01 Jun 2023 21:30:45 -0400 X-MC-Unique: zRBlaODHPZm4kq_rKHyRUA-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-1b024ab0c28so14192055ad.2 for ; Thu, 01 Jun 2023 18:30:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685669444; x=1688261444; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/cMHIbrTWtgBUsYlhuC2ZhD157W4Z46c619IAlhaVOY=; b=QxdxPpL+PYzaT+TfllQJW1nmbnjVFKg+TF+m3hXjwTvmf1fJi5EQPUHEvBSajBIiHX oNvYJvZ7khUlzzQtqhXz860FIaUoaGta/igDwfUG7z9u4sFcwZatBqddOyB8/XSlkE4a XGMIg3WhgZlSGNeiTgFFRvzYLNma2cQk3jyib0er42ayKMBb0Y0pTSmN+fWikshHuUM3 fpN7QTXZALlzhRU+okdcBgsbPCg5HgZmU3WzeFP4g/hEGCOmVRICiJnv7SgTNvoBhW92 tD4L60BvQrX1KkXgh/iCHZ8TdSq5PMJcva6C4QE85iaXT3ysSWl8rMix0OERXOVgYkND ZVaw== X-Gm-Message-State: AC+VfDxaK2D1f1xJicD+gI4VxK7ZidVIUMJLYjNo8lVANbnpWGkgQHPF rSLI4h8Cyqdk3Jv8NDotfNf2LgRQhTaG4zVsZSwCmhVqjzfVtlbQMOKj3e63Ngz8KFO3S9OKlHV +85FVEW25TuZB1s8XxbCTH6Rk X-Received: by 2002:a17:902:e851:b0:1ae:6a3:d058 with SMTP id t17-20020a170902e85100b001ae06a3d058mr1297444plg.36.1685669444423; Thu, 01 Jun 2023 18:30:44 -0700 (PDT) X-Received: by 2002:a17:902:e851:b0:1ae:6a3:d058 with SMTP id t17-20020a170902e85100b001ae06a3d058mr1297430plg.36.1685669444141; Thu, 01 Jun 2023 18:30:44 -0700 (PDT) Received: from [10.72.12.188] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id f7-20020a170902860700b001acad86ebc5sm47952plo.33.2023.06.01.18.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 18:30:43 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 09:30:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 10/13] ceph: allow idmapped setattr inode op Content-Language: en-US To: Alexander Mikhalitsyn Cc: brauner@kernel.org, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Christian Brauner , Jeff Layton , Ilya Dryomov , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com> <20230524153316.476973-11-aleksandr.mikhalitsyn@canonical.com> From: Xiubo Li In-Reply-To: <20230524153316.476973-11-aleksandr.mikhalitsyn@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/23 23:33, Alexander Mikhalitsyn wrote: > From: Christian Brauner > > Enable __ceph_setattr() to handle idmapped mounts. This is just a matter > of passing down the mount's idmapping. > > Cc: Jeff Layton > Cc: Ilya Dryomov > Cc: ceph-devel@vger.kernel.org > Signed-off-by: Christian Brauner > Signed-off-by: Alexander Mikhalitsyn > --- > fs/ceph/inode.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c > index 37e1cbfc7c89..f1f934439be0 100644 > --- a/fs/ceph/inode.c > +++ b/fs/ceph/inode.c > @@ -2050,6 +2050,13 @@ int __ceph_setattr(struct inode *inode, struct iattr *attr) > > dout("setattr %p issued %s\n", inode, ceph_cap_string(issued)); > > + /* > + * The attr->ia_{g,u}id members contain the target {g,u}id we're > + * sending over the wire. The mount idmapping only matters when we > + * create new filesystem objects based on the caller's mapped > + * fs{g,u}id. > + */ > + req->r_mnt_idmap = &nop_mnt_idmap; For example with an idmapping 1000:0 and in the /mnt/idmapped_ceph/. This means the "__ceph_setattr()" will always use UID 0 to set the caller_uid, right ? If it is then the client auth checking for the setattr requests in cephfs MDS will succeed, since the UID 0 is root. But if you use a different idmapping, such as 1000:2000, it will fail. So here IMO we should set it to 'idmap' too ? Thanks - Xiubo > if (ia_valid & ATTR_UID) { > dout("setattr %p uid %d -> %d\n", inode, > from_kuid(&init_user_ns, inode->i_uid), > @@ -2240,7 +2247,7 @@ int ceph_setattr(struct mnt_idmap *idmap, struct dentry *dentry, > if (ceph_inode_is_shutdown(inode)) > return -ESTALE; > > - err = setattr_prepare(&nop_mnt_idmap, dentry, attr); > + err = setattr_prepare(idmap, dentry, attr); > if (err != 0) > return err; > > @@ -2255,7 +2262,7 @@ int ceph_setattr(struct mnt_idmap *idmap, struct dentry *dentry, > err = __ceph_setattr(inode, attr); > > if (err >= 0 && (attr->ia_valid & ATTR_MODE)) > - err = posix_acl_chmod(&nop_mnt_idmap, dentry, attr->ia_mode); > + err = posix_acl_chmod(idmap, dentry, attr->ia_mode); > > return err; > }