Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu,  1 Jun 2023 18:25:47 -0700
In-Reply-To: <20230411130338.8592-1-cloudliang@tencent.com>
Mime-Version: 1.0
References: <20230411130338.8592-1-cloudliang@tencent.com>
Message-ID: <168565360839.667711.17229671566468688990.b4-ty@google.com>
Subject: Re: [PATCH] KVM: x86/pmu: Remove redundant check for MSR_IA32_DS_AREA
 set handler
From:   Sean Christopherson <seanjc@google.com>
To:     Sean Christopherson <seanjc@google.com>,
        Like Xu <like.xu.linux@gmail.com>,
        Jinrong Liang <ljr.kernel@gmail.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Wanpeng Li <wanpengli@tencent.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On Tue, 11 Apr 2023 21:03:38 +0800, Jinrong Liang wrote:
> After commit 2de154f541fc ("KVM: x86/pmu: Provide "error" semantics
> for unsupported-but-known PMU MSRs"), the guest_cpuid_has(DS) check
> is not necessary any more since if the guest supports X86_FEATURE_DS,
> it never returns 1. And if the guest does not support this feature,
> the set_msr handler will get false from kvm_pmu_is_valid_msr() before
> reaching this point. Therefore, the check will not be true in all cases
> and can be safely removed, which also simplifies the code and improves
> its readability.
> 
> [...]

Applied to kvm-x86 vmx, thanks!

[1/1] KVM: x86/pmu: Remove redundant check for MSR_IA32_DS_AREA set handler
      https://github.com/kvm-x86/linux/commit/33ab767c2628

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes