Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Fri, 2 Jun 2023 04:59:52 +0300
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Rafael Wysocki <rafael@kernel.org>, hdegoede@redhat.com,
        linus.walleij@linaro.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org,
        S-k Shyam-sundar <Shyam-sundar.S-k@amd.com>,
        Natikar Basavaraj <Basavaraj.Natikar@amd.com>
Subject: Re: [PATCH v3 1/4] include/linux/suspend.h: Only show pm_pr_dbg
 messages at suspend/resume
Message-ID: <ZHlNGF79cwicmWde@surfacebook>
References: <20230601232923.1248-1-mario.limonciello@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230601232923.1248-1-mario.limonciello@amd.com>
Precedence: bulk

Thu, Jun 01, 2023 at 06:29:20PM -0500, Mario Limonciello kirjoitti:
> All uses in the kernel are currently already oriented around
> suspend/resume. As some other parts of the kernel may also use these
> messages in functions that could also be used outside of
> suspend/resume, only enable in suspend/resume path.

...

>  * Remove pointless do/while

I believe this is a joke.

This guards against weirdness, like

	__pm_pr_dbg(foo)
	else
		bar;

NAK for this particular change.

-- 
With Best Regards,
Andy Shevchenko