Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
MIME-Version: 1.0
Subject: Re: [PATCH 2/2] mm/hugetlb: Use a folio in hugetlb_wp()
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <20230602015408.376149-3-zhangpeng362@huawei.com>
Date:   Fri, 2 Jun 2023 11:17:33 +0800
Cc:     Linux Memory Management List <linux-mm@kvack.org>,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        willy@infradead.org, mike.kravetz@oracle.com,
        sidhartha.kumar@oracle.com, vishal.moola@gmail.com,
        wangkefeng.wang@huawei.com, sunnanyong@huawei.com
Content-Transfer-Encoding: 7bit
Message-Id: <EBC08570-CC5A-4B82-9DB0-3D7BA0BDFCA1@linux.dev>
References: <20230602015408.376149-1-zhangpeng362@huawei.com>
 <20230602015408.376149-3-zhangpeng362@huawei.com>
To:     Peng Zhang <zhangpeng362@huawei.com>
Precedence: bulk


> On Jun 2, 2023, at 09:54, Peng Zhang <zhangpeng362@huawei.com> wrote:
> 
> From: ZhangPeng <zhangpeng362@huawei.com>
> 
> We can replace nine implict calls to compound_head() with one by using
> old_folio. However, we still need to keep old_page because we need to
> know which page in the folio we are copying.
> 
> Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.