Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1688966rwd; Thu, 1 Jun 2023 21:12:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4+LdKmpY9m153t3tiLMp4Cx8NSmQd7LmfSLlLlMaA9q1x1gfWw2rzjelPJjvPELA8NzmBG X-Received: by 2002:a17:902:cec3:b0:1b0:75ef:ce3e with SMTP id d3-20020a170902cec300b001b075efce3emr1066823plg.25.1685679173201; Thu, 01 Jun 2023 21:12:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685679173; cv=none; d=google.com; s=arc-20160816; b=1GjY1a/xXj5hiBarXdQUdyxKcfbvheaAeU5yVCp8yDxMX0c8VZtmtTwwehKhU2Ncjj qaxjcIgUJvgSGh0qm5fEPUKrXoZUDucuycXf/eeX22jfFEzoKbglmOS8VhdF1WPPj3ic FdrPr9uaGe/X4z+gjgdXeXuBih5MptAQ86vWIifR4DTaEIvnjjLlOkC4B7EFfv4MEy6D ry19zS6HfqoBjch9MSc4ildORouAUlwDE03pjp2ylC5UcGqnymzNt9phnwPFvogeI7b5 5qUFnN4ZyWv6JWIU8M4H3Hf9fSFg/+mo69n+KEcDZFpxPn8xLSFSaVZKfjSzjCrZGkGW y7GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=I6z0pOwW+tzc6u3dQO09lUEAzP/cM45yNrex7nu7vvs=; b=poeLtv6NQVrzlAPjWFqpLQKP/s3Azxe/is5fcDpaXLzcYiT3o9bdbfAEaRKFJKT7oV J1to3fXSFg4a6/kYeJplqzyz1kbJ585GbppvVsdGuq3l8sVx3PxuLege5LOieT0VWV6W Gr/kYorR74nJmneo8EihPUVA6yV1oaSipoo90xw2O546DR2Iwg82HNz4RZbhCiOFG2ik hT1zQe6gPoZq/4zx9IFvenPMio2XB2z9z47KjnNtMeeFsgAkOwwZ7BPXKI9Iq3BnxkDn pZQ9JJNc8LtF9ZyNTbqZqq4oR7wJioYTV2RyZjHgryjQtU/fr+sSXwpzVlzMHmzLVqkG C+Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BELBIGFR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r11-20020a1709028bcb00b001adb9d5e1d2si263694plo.130.2023.06.01.21.12.41; Thu, 01 Jun 2023 21:12:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BELBIGFR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230166AbjFBD7Q (ORCPT + 99 others); Thu, 1 Jun 2023 23:59:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjFBD7P (ORCPT ); Thu, 1 Jun 2023 23:59:15 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93BF8194 for ; Thu, 1 Jun 2023 20:59:13 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-3f6affdb6ddso16339001cf.0 for ; Thu, 01 Jun 2023 20:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685678352; x=1688270352; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I6z0pOwW+tzc6u3dQO09lUEAzP/cM45yNrex7nu7vvs=; b=BELBIGFRJ9f9hjm+T7CxnQxnjgbCYKIp+P5u8N616hIvSPC9IAfXUGQ9kMkCQH00mi QX8nx71Zt+iFS7h0BFWanE6Nuplrf6q8AfldzNcYbEPIRGbadURu7Wh+96VQ6YmeRw/U hN2Z3MZbVOeJiGQQJ45k+nwOau5x4Y0eB5GHyEuD7ddslmuy/p2GKvEYvubylnW4x97R q1EVu3G12YRRsbV0/bsuXVq+6aL6UMfLgGLvdvnS8pC4L+cBDHAIDRr0I0j4wdCDFROc 887MvHaIsxAzfYLrQqSzBi5re3uaPnG3tflAl3oCBIPZ+vwGAKI5Fvgi34EHiqCcNjYH xNoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685678352; x=1688270352; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6z0pOwW+tzc6u3dQO09lUEAzP/cM45yNrex7nu7vvs=; b=eI8hyaIC0tYXAzNtCL1Nws/CuZGtg7nVXjft+kUjGS99NqllDXXUGdheTfY69RjvIL VvxL4xvFYBjtD1ft1yjIqh4HoI6VA7ayzwHRMM9rHnuTHlDaUrgTkE6aQ6HZo9J+TALG acU0jpPYsBIfYWHw1yXMKXR8EUtMQJPH5efJNF6MquI4Sc1unrtYAXXsvyE8c1auCoby VVlakQUkrX03suePtZJ17qyhJlg6gPt5r+aWpfyZn0dXQX0OgWUgt6o6FnrWlOUc9n2U DGhVpXrUnFO+bx1Bs3jNBZ0AZ6fMgnwzRl9b9AdvqdNbvrrCd31QuBR2JtQ6q4vdKRKs fltQ== X-Gm-Message-State: AC+VfDyQqsT9eEry/2htEuYQonN10G9W2SgGjONdMCiWJTas8T/XnnYf rcr50f4OKgV3EnLjJqKbYHK5Ks2DuI+y3GTEdztwMbgQ X-Received: by 2002:a05:622a:1454:b0:3f6:bb5b:8111 with SMTP id v20-20020a05622a145400b003f6bb5b8111mr15420315qtx.60.1685678352143; Thu, 01 Jun 2023 20:59:12 -0700 (PDT) MIME-Version: 1.0 References: <20221217001554.554913-1-lstoakes@gmail.com> <20221219100734.jag6zejp4tug77yq@techsingularity.net> <20230601091002.zl3udcqxmb3tjtri@techsingularity.net> In-Reply-To: <20230601091002.zl3udcqxmb3tjtri@techsingularity.net> From: Yang Shi Date: Thu, 1 Jun 2023 20:59:00 -0700 Message-ID: Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() To: Mel Gorman Cc: Lorenzo Stoakes , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko , David Howells Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 1, 2023 at 2:10=E2=80=AFAM Mel Gorman wrote: > > On Wed, May 31, 2023 at 02:29:01PM -0700, Yang Shi wrote: > > On Wed, May 31, 2023 at 8:24???AM Lorenzo Stoakes = wrote: > > > > > > On Mon, 19 Dec 2022 at 10:07, Mel Gorman wrote: > > > > > > > > On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote: > > > > I reckon we should give it another few months until May. There has = been > > > > one user recently that tried to use list but it turned out arrays w= ere > > > > more appropriate. > > > > > > > > > > It being May 31st, it feels appropriate to chase this up :) > > > > > > David's series at [0] did initially use this function, before > > > switching to the _array() variant. Other than that it seems that it > > > remains unused. > > > > Thanks for following this up. My patchset (use bulk allocator for > > dm-crypt) also switched from list API to a new callback API suggested > > by Mel. But I haven't heard anything back from Mel about it yet. I > > forgot to follow up due to too many distractions. > > > > It needs a follow-up. My various inboxes that I get cc'd on currently exc= eed > 1000 mails due to being offline a lot during the last few months so there > could be a lot hiding in there. Conceptually at least I don't recall havi= ng > any problem with the callback patches as long as the dm-crypt people are > happy. I vaguely recall a review disappeared off into the weeds talking > about maybe using physically contiguous pages (missing the point of using > the bulk allocator at all and ignoring fragmentation concerns affecting > allocation success rates) but I'm not certain. Yes, other than that someone also complained the changeset is too big, and suggested just try to allocate compound page and fallback to the mempool allocator if that fails instead of creating a dedicated mempool API. Do you prefer follow up in that v2 thread or I send a new v3 (basically same with v2, just rebased on the latest mm-unstable)? > > -- > Mel Gorman > SUSE Labs