Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <201cb02b-b7b0-eecc-a9d5-3a7535c91d8d@linaro.org>
Date:   Fri, 2 Jun 2023 09:04:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH RESEND 4/4] arm64: dts: qcom: ipq5332: add support for the
 RDP474 variant
Content-Language: en-US
To:     Kathiravan T <quic_kathirav@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230601042054.29075-1-quic_kathirav@quicinc.com>
 <20230601042054.29075-5-quic_kathirav@quicinc.com>
 <91c63634-eb39-fdca-2c76-6f8182c2d47c@linaro.org>
 <2dd8e5be-c5b5-02e7-32d0-587a40cb70cc@quicinc.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <2dd8e5be-c5b5-02e7-32d0-587a40cb70cc@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02/06/2023 06:05, Kathiravan T wrote:
> 
> On 6/1/2023 10:59 PM, Krzysztof Kozlowski wrote:
>> On 01/06/2023 06:20, Kathiravan T wrote:
>>> Add the initial device tree support for the Reference Design
>>> Platform(RDP) 474 based on IPQ5332 family of SoC. This patch carries
>>> the support for Console UART, eMMC, I2C and GPIO based buttons.
>>>
>>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/Makefile           |   1 +
>>>   arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts | 112 ++++++++++++++++++++
>>>   2 files changed, 113 insertions(+)
>>>   create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>>> index 4f9e81253e18..0f8c763a9bd9 100644
>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
>>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-mi01.2.dtb
>>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp442.dtb
>>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp468.dtb
>>> +dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp474.dtb
>>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
>>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
>>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c1.dtb
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>> new file mode 100644
>>> index 000000000000..085729a0fdf1
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>> @@ -0,0 +1,112 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * IPQ5332 RDP474 board device tree source
>>> + *
>>> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/input/input.h>
>>> +#include "ipq5332.dtsi"
>>> +
>>> +/ {
>>> +	model = "Qualcomm Technologies, Inc. IPQ5332 MI01.9";
>>> +	compatible = "qcom,ipq5332-ap-mi01.9", "qcom,ipq5332";
>>> +
>>> +	aliases {
>>> +		serial0 = &blsp1_uart0;
>>> +	};
>>> +
>>> +	chosen {
>>> +		stdout-path = "serial0";
>>> +	};
>>> +
>>> +	gpio_keys {
>> No, srsly, so not only ignored the tags but also feedback?
> 
> 
> Please correct me if I am wrong here..
> 
> This is RESEND of V1 patches (only minor correction in the subject line

I sent you three emails and I assumed you got my feedback, thus it
should not have been resend...


> in cover letter). Also I don't see review comments as such in original 
> V1 as well 
> https://lore.kernel.org/linux-arm-msm/20230531135048.19164-1-quic_kathirav@quicinc.com/
> 
> Can you help to point out your review comments, I couldn't able to find out.

... but I don't see them on lore. So apparently you also did not get them.

I apologize in such case. Mails are nicely sent in my outbox but
apparently went to /dev/null.

Original feedback:

Same problems as with most of recent patches. No underscores in node names.

Best regards,
Krzysztof