Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v10 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon
 migration driver
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <alex.williamson@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        <jonathan.cameron@huawei.com>, <cohuck@redhat.com>,
        <linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>
References: <20230408074224.62608-1-liulongfang@huawei.com>
 <20230408074224.62608-4-liulongfang@huawei.com> <ZDlGC8SUXqKNmfSe@nvidia.com>
 <ca592d60-9a5b-dec3-9565-76cd5c0740e0@huawei.com>
 <81e11acf-0ede-d515-bb5a-3964c302f384@huawei.com>
 <ZEKeUBiLyWWW7E+V@nvidia.com>
 <fa3d47a1-0af5-f8ba-d14c-8d9a756e2c23@huawei.com>
 <ZGNuFYQJz488Xrdr@nvidia.com>
From:   liulongfang <liulongfang@huawei.com>
Message-ID: <9c2a68f6-7ee4-03a0-eb9b-49137b37ed10@huawei.com>
Date:   Fri, 2 Jun 2023 15:07:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <ZGNuFYQJz488Xrdr@nvidia.com>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/5/16 19:50, Jason Gunthorpe wrote:
> On Tue, May 16, 2023 at 05:40:36PM +0800, liulongfang wrote:
>> On 2023/4/21 22:31, Jason Gunthorpe wrote:
>>> On Fri, Apr 21, 2023 at 11:32:47AM +0800, liulongfang wrote:
>>>
>>>> Thank you for your suggestion, but the current debugfs method can already
>>>> meet the functional requirements of verification testing and
>>>> problem location.
>>>
>>> To be clear, I'm against adding selftest code in this manner. We have
>>> many frameworks for kernel teesting, please pick one and integrate
>>> with it.
>>>
>>
>> Hi, Jason:
>> The purpose of this hisi_acc_vf_debug_restore function is to obtain the
>> migration status data of the migration device. It is a debug operation.
>> Just to obtain this status data, user need to complete the few steps
>> of live migration.
>> Therefore, it is a debug function here, not a self-test function.
> 
> A debug function should not alter the device state, or do a trial migration.
> 

OK Then I delete this migration and restore the test operation.
Does this meet your requirements?

Thanks,
Longfang.
> Jason
> .
>