Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1851483rwd; Fri, 2 Jun 2023 00:41:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4C7IneRiKN8kgmjjy+4aR6ggV47zgr2aUInAfd9w6AdVnCGS2GXROIUbVli9705S+zCKhH X-Received: by 2002:a05:6358:4303:b0:122:f227:581d with SMTP id r3-20020a056358430300b00122f227581dmr10080265rwc.24.1685691677645; Fri, 02 Jun 2023 00:41:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685691677; cv=none; d=google.com; s=arc-20160816; b=YCSGpMF13dZqrANAvNF5wqgULTdG9T4XY1Fg3zK8VzySEbXLjOulAj2q+EUpT1CAGi lyX7yXWV+NwSvzqJhE/Q827BuVmxQ2lgmq7voDk2c8ca/PcdRq5SBGDD90J9JvfnkLTL PY2w+NSFZBDfdMSy8U836wNzMnRNp67vc58hM+snsq8fgNMQ9R3zvgDfYmvhr/YIHPrL Bmu2rHDER30xEov9JV7sswyM2Pm+ZPau8dqo3+gReoiRA9KvlosDGrvxA3WSOF9hBumR 3wrCoBwz8UU1rLzWD+JTNhLoNXr+XlPK9f7hjrbJOVymDA8H3+StpwTgLAY9Kn7jI/Ty MXUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5mz0xAIbticKoD8d57JrRQoHpa38UW5+gVYXlrr1/Nc=; b=eCBPp++gkkKc3dR94Camvai0/JDYHuCHXzD+YRv/vhzxkoMIZ5/FJ9+6di8ljqXjWO 641TknACib5T/MUv3gLbBTzib0EjZ2ZJmdnFEtGPlIRRLA7L2vyz7mFPY+t0Al2HwIVA +6CBuN/GiqmY1k4Sn0zJql2JFrrCOB2odIqeUa80ZThKmt/JUm8YSNQDsyxm/zeacGwh c/ugbqZSsoWzm9XhxlHLt26CDQPvelE6CCzwj4/erpHcIxeHItI7VzANriFLm++4JV0O GXUKsBdJJ/mGXKIt7Ft1UG2H72Um+3UEMNbMYx1jnd55pHsxXCSJWmRRaip8MWuinHiV 06hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k34-20020a17090a3ea500b0025698fca606si621829pjc.109.2023.06.02.00.41.03; Fri, 02 Jun 2023 00:41:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234272AbjFBHdV (ORCPT + 99 others); Fri, 2 Jun 2023 03:33:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234261AbjFBHdL (ORCPT ); Fri, 2 Jun 2023 03:33:11 -0400 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 314131A6; Fri, 2 Jun 2023 00:33:08 -0700 (PDT) Received: from localhost.localdomain (unknown [124.16.138.125]) by APP-03 (Coremail) with SMTP id rQCowABnSB0um3lk55d4CQ--.40453S2; Fri, 02 Jun 2023 15:33:03 +0800 (CST) From: Jiasheng Jiang To: andy.shevchenko@gmail.com Cc: albeu@free.fr, linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH v2] gpio: ath79: Add missing check for platform_get_irq Date: Fri, 2 Jun 2023 15:33:00 +0800 Message-Id: <20230602073300.7536-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: rQCowABnSB0um3lk55d4CQ--.40453S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Gr17Ar4kZr1xXw1xGw47XFb_yoW3Zrg_Cw n7Xw47Gr48CrnIvw12yw1ayFWSyr9rur4kZr4vga1aqr98Z3yDu34Duw4rXr1UWr10yFyD Ga4qkrWYyFs3GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8 CwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r 1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij 64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr 0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUGhFxUUUUU= X-Originating-IP: [124.16.138.125] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the missing check for platform_get_irq and return error code if it fails. Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Return "girq->parents[0]" instead of "-ENODEV". --- drivers/gpio/gpio-ath79.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c index aa0a954b8392..31ce2d5c6ba0 100644 --- a/drivers/gpio/gpio-ath79.c +++ b/drivers/gpio/gpio-ath79.c @@ -286,6 +286,8 @@ static int ath79_gpio_probe(struct platform_device *pdev) if (!girq->parents) return -ENOMEM; girq->parents[0] = platform_get_irq(pdev, 0); + if (girq->parents[0] < 0) + return girq->parents[0]; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; } -- 2.25.1