Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1864303rwd; Fri, 2 Jun 2023 00:57:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5REE/7/cdTZHWGSPreVGlGQdfXS7W7mef0BU4AQp/TeUALBoZrr7WpR3e6lej6renySYdn X-Received: by 2002:a92:c648:0:b0:33d:16b6:3df8 with SMTP id 8-20020a92c648000000b0033d16b63df8mr3535470ill.24.1685692652586; Fri, 02 Jun 2023 00:57:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685692652; cv=none; d=google.com; s=arc-20160816; b=a+SyAx/3jcHfxUl85g3QuqLJeo4bsX46ta9sdOWjQ+e+I8XSM6muSRMZg91raO04Ou GkvMCS66ZHfajwmlOao17vyfn4uXd2gydqG1khXDzcLjXRTLtm3ZBSpkBW+ThUDZeaFI 6liGnsR/wHpvNJjFikr/P5l7Lb0vlyWV9t6NTQpOOsuWmHMQcvvfMIGMP/2s9A45cBRV qJuQMboR4d7wrZM9fJFV89NtQ2rR2Chrboz5aN4pxAAXfiNEnWAn7iJOGWWZyzmQED1Z zG7HEHPXgPxAIruSMqGbhsIVFvj+QsQBQ4Oz8kXSNgZ7NK7Cw0rOpf1D5Sf+h9MqMJ60 jB7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=slOwxmgd9A3pmNVMsaJmt/qiJCPXAzWUp9wNIuZuuyY=; b=zxSVOWTcuc2loT6SiIX0GlrTTb/SUIwQi58UjzlfqAFJ6wz0zHPJs/DDwEFh/5WaIR Qbh+qm8zV0WmdPEh3LOQp5IAC3jOaujcjyrf8vugOtGqaKF7lmyIn16yEyBpT0yRrKwE snEV7Up1Dwkne96tYGBWxU58+oc8MnpzXyPJBQXPuYDfRLqjIZ/XCxFzS/mY2jA5bW12 6JrcUJCfkH4EVagX+ODh/Uqd883Db+Hjf9OY6b8LiQNtMhB1jRAef8L2oh6uU8uLGke4 PkkSIQ+7M8NyjfUUcBGMg11dyngzSM7lHgmEGBpcUFpPrPp3kjtxwUBhcQxsTEqFvmag gkoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AeNLt/fC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y27-20020aa78f3b000000b00643430939acsi338738pfr.164.2023.06.02.00.57.18; Fri, 02 Jun 2023 00:57:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AeNLt/fC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233795AbjFBHx6 (ORCPT + 99 others); Fri, 2 Jun 2023 03:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232674AbjFBHx4 (ORCPT ); Fri, 2 Jun 2023 03:53:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E44123 for ; Fri, 2 Jun 2023 00:53:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 912CC60EE9 for ; Fri, 2 Jun 2023 07:53:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76EF9C433D2; Fri, 2 Jun 2023 07:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685692435; bh=XH5l+kAhJj2RsYxYAcPm2mIoXZkoLae+HowrUKup1UQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AeNLt/fCvTQ0N19RKQBtqbYxgE6fQDZAzEj6n5CWmZQBpn69YD1RCefmkQi8VI1Te k92FEzgP6HyjFgmxz2zLhXrwKnMPbPzEBKy8dbQJwRfA0yGi0gbGW+9JjE7LsILOZz YxPYWJ1FEpu7ASvlR+9yVLUrx4QQc5EkUvgGlNGz3418QztSgdGQC0xTHdhcc/HrAa g3ZyD3ET5+dWyanokzuJGojr/C9NN1MNeXKAoEzHPZHejMpHAwA4Pu23E+9xa5h/Hz 9KRy49AjnBpyix20mT02pjEpgU6pk+Jhee91zgxgCpiS1VwkOUziVGAcrgI3L2Oocn NzC41kU9ziCvQ== Date: Fri, 2 Jun 2023 09:53:49 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: msmulski2@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, simon.horman@corigine.com, Michal Smulski Subject: Re: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x Message-ID: <20230602095349.2ab53919@dellmb> In-Reply-To: <20230602001705.2747-2-msmulski2@gmail.com> References: <20230602001705.2747-1-msmulski2@gmail.com> <20230602001705.2747-2-msmulski2@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2023 17:17:04 -0700 msmulski2@gmail.com wrote: > config->mac_capabilities |= MAC_5000FD | > MAC_10000FD; > } > - /* FIXME: USXGMII is not supported yet */ > - /* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */ > + __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); > } > } The set_bit() should go into the if statement above, since 6361 does not support usxgmii: /* 6361 only supports up to 2500BaseX */ if (!is_6361) { __set_bit(PHY_INTERFACE_MODE_5GBASER, supported); __set_bit(PHY_INTERFACE_MODE_10GBASER, supported); + __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); config->mac_capabilities |= MAC_5000FD | MAC_10000FD; } -/* FIXME: USXGMII is not supported yet */ -/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */ Marek