Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Jun 2023 10:18:25 +0200
From:   Francesco Dolcini <francesco@dolcini.it>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Francesco Dolcini <francesco@dolcini.it>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et
 al.
Message-ID: <ZHml0ZEC9ZvxHXr9@francesco-nb.int.toradex.com>
References: <20230601131332.26877-1-francesco@dolcini.it>
 <20230601131332.26877-2-francesco@dolcini.it>
 <20230602072045.GO14287@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230602072045.GO14287@atomide.com>
Precedence: bulk

On Fri, Jun 02, 2023 at 10:20:45AM +0300, Tony Lindgren wrote:
> Hi,
> 
> * Francesco Dolcini <francesco@dolcini.it> [230601 13:15]:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > 
> > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its
> > nonwifi and wifi variants and the carrier boards (Dahlia,
> > Verdin Development Board and Yavia) they may be mated in.
> 
> Looks like you have wifi on sdio, there should be no need for separate
> compatible properties. The sdio wifi will try to probe and will just bail
> out if no wifi is populated.
> 
> If however the non-wifi variants are recycling the sdio pins for something
> else, then it's it's a different story. In that case you want either
> seprate compatible properties, or want to use dts fragments possibly.

This is exactly the case, the wifi/non-wifi variant are re-using pins.

I provided a more verbose explanation on that on a previous discussion
https://lore.kernel.org/all/ZG5jYV%2FNfGJvYkma@francesco-nb.int.toradex.com/

Francesco