Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1897966rwd; Fri, 2 Jun 2023 01:34:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7PZvoCu2a//Op1D5zru9Jmb5Qak6w5qWf/rvAF66bgyDzg3JGyAEPCGNsKPThv9lFMFrmt X-Received: by 2002:a05:6830:1e96:b0:6af:6e7c:e7b2 with SMTP id n22-20020a0568301e9600b006af6e7ce7b2mr1935238otr.10.1685694851400; Fri, 02 Jun 2023 01:34:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685694851; cv=none; d=google.com; s=arc-20160816; b=nZ1iyYNSn95XziHFv/URGdF8ch3aQeUmc19EiC4kHDphhf7lhd3pCGnu/kblnamrLy FOJPzbOmL04kl4RoOOEZnImCAV3cxMcO/AbWbCrGPoQYnqVGKCqKlBSmiJGijr19D0En GFvzYpH2cPV6B/K5matbwWfYu51TMwhnfOSIS3TjWEFB/GIc0uKdUPRpCsTeSIQwkQx0 Um1VdqjqTM4BJ1hwI9K1ubzRl0Pjbs5xe5S+8eUJA4dMAZjbnJXu3xIRkVqd09XTUxWT 01n9F+5agIg+7GKVoNlZse6BnGNzRwPlXCpnQwXfFP5/Ilfd/b2OjW2r+HjsgIUckx6W RkpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TcZ6dfEMtk1B3ObKgN+ttlZ17TyrmysNGVXlZpEDeyU=; b=KvU8jxxJiLtxYNrFmsTQKCRcQ1EGezW5Nt5sYI1nBsHT2Gk+l5UTSUmzusJeaidgwU iF8cCez0XnoQ3m/4d0fjfBxHNM59W1rchLplO3ro8aTCu6XyhTzAIVARubX09wxBEp+3 JZbFXgKCBFI0pPqi+EOS4q9rY/fqE0VOdc/3WSLjuDhrIUrrOIySEje3KFH6+8BpSFbz DgQkowQQVQSvMFke346fh8hEf0WG0R2GitkFba7KyijZ37VDak+fb3e/zT7+jxTtVdEX 6Vz+tE3ZxYSMG9YKJ1ex0+SiaZXb0cO2j6xETIhJl0FujC3I4AXMO5oNo8VvnFui2LQY oRBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AAwtZHnB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020aa79e41000000b0064a15fc65d5si407615pfq.83.2023.06.02.01.33.57; Fri, 02 Jun 2023 01:34:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AAwtZHnB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234366AbjFBIVk (ORCPT + 99 others); Fri, 2 Jun 2023 04:21:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233890AbjFBIVj (ORCPT ); Fri, 2 Jun 2023 04:21:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BD9CEB; Fri, 2 Jun 2023 01:21:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD32E642DB; Fri, 2 Jun 2023 08:21:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B817C433D2; Fri, 2 Jun 2023 08:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685694097; bh=QbOneeT8lhByLYodDEKczI5ni1C0nepP3+sbgHrYq4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AAwtZHnBN9GrXjXsmigetfsp0evgoEW/HLqlrxb/nOI01R2q4IDkpo+5k4mwsSAET IEwccguKNeNQ/x+/eCF29r7wEpMDQclAjvZiQxFhOs4WmerD15Ybd4/z16PPMqwkP4 4P0xSleF378Y3ym65eFDjEcIkCuWixQ21q8N5n1lAZINbsG5AyidenKGh39jgqGaiT 13Jf5BsFw8fo+QRmnRpjvqrUs+t9lXX7kcEoTx/hxJ8wzTTuT9Ec5kfN2HP3mGmgwD pRpKd1uo8bFRrOKpGswULRUSxJQJnHUpCQaR+p2O6GFztpZ6I++SOVUKhkie8/bz8S xDCx6nBijvAFw== Date: Fri, 2 Jun 2023 09:21:33 +0100 From: Lee Jones To: Dan Carpenter Cc: Julien Panis , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mfd: tps6594: Fix an error code in probe() Message-ID: <20230602082133.GP449117@google.com> References: <49f7cd8f-f7eb-40f1-91e8-291620c684df@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49f7cd8f-f7eb-40f1-91e8-291620c684df@kili.mountain> X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2023, Dan Carpenter wrote: > These error paths accidentally return success when they should return > -EINVAL. > > Fixes: 325bec7157b3 ("mfd: tps6594: Add driver for TI TPS6594 PMIC") > Signed-off-by: Dan Carpenter > --- > drivers/mfd/tps6594-i2c.c | 2 +- > drivers/mfd/tps6594-spi.c | 2 +- > 2 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks -- Lee Jones [李琼斯]