Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3b05763-0153-e422-9874-bfaab461003b@quicinc.com>
Date:   Fri, 2 Jun 2023 14:23:09 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH] arm64: dts: qcom: ipq9574: add few more reserved memory
 region
To:     Anusha Rao <quic_anusha@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
        <quic_sjaganat@quicinc.com>, <quic_arajkuma@quicinc.com>,
        <quic_poovendh@quicinc.com>
References: <20230602084431.19134-1-quic_anusha@quicinc.com>
Content-Language: en-US
From:   Kathiravan T <quic_kathirav@quicinc.com>
In-Reply-To: <20230602084431.19134-1-quic_anusha@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/2/2023 2:14 PM, Anusha Rao wrote:
> In IPQ SoCs, bootloader will collect the system RAM contents upon crash
> for post-morterm analysis. If we don't reserve the memory region used
> by bootloader, obviously linux will consume it and upon next boot on
> crash, bootloader will be loaded in the same region, which will lead to
> loss of some data, sometimes we may miss out critical information.
> So lets reserve the region used by the bootloader.
>
> Similarly SBL copies some data into the reserved region and it will be
> used in the crash scenario. So reserve 1MB for SBL as well.
>
> While at it, drop the size padding in the reserved memory region,
> wherever applicable


LGTM.

Reviewed-by: Kathiravan T <quic_kathirav@quicinc.com>


>
> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 0baeb10bbdae..7d21ec0909fb 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -156,6 +156,16 @@
>   		#size-cells = <2>;
>   		ranges;
>   
> +		bootloader@4a100000 {
> +			reg = <0x0 0x4a100000 0x0 0x400000>;
> +			no-map;
> +		};
> +
> +		sbl@4a500000 {
> +			reg = <0x0 0x4a500000 0x0 0x100000>;
> +			no-map;
> +		};
> +
>   		tz_region: tz@4a600000 {
>   			reg = <0x0 0x4a600000 0x0 0x400000>;
>   			no-map;
> @@ -163,7 +173,7 @@
>   
>   		smem@4aa00000 {
>   			compatible = "qcom,smem";
> -			reg = <0x0 0x4aa00000 0x0 0x00100000>;
> +			reg = <0x0 0x4aa00000 0x0 0x100000>;
>   			hwlocks = <&tcsr_mutex 0>;
>   			no-map;
>   		};