Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9fc06dd-d9e4-58fc-6252-87590c416ce7@yadro.com>
Date:   Fri, 2 Jun 2023 11:46:36 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 2/2] dt-bindings: leds: Document Awinic AW2016 bindings
To:     Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        <devicetree@vger.kernel.org>, <linux@yadro.com>,
        <linux-leds@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20230524113910.196321-1-v.barinov@yadro.com>
 <20230524114056.196518-1-v.barinov@yadro.com>
 <168493088788.3462735.2834416618033227181.robh@kernel.org>
 <20230602080655.GN449117@google.com>
Content-Language: en-US
From:   Vladimir Barinov <v.barinov@yadro.com>
In-Reply-To: <20230602080655.GN449117@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Lee,

On 6/2/23 11:06, Lee Jones wrote:
> «Внимание! Данное письмо от внешнего адресата!»
>
> On Wed, 24 May 2023, Rob Herring wrote:
>
>> On Wed, 24 May 2023 14:40:56 +0300, Vladimir Barinov wrote:
>>> Add Awinic AW2026 binding documentation
>>>
>>> Signed-off-by: Vladimir Barinov <v.barinov@yadro.com>
>>> ---
>>>   .../bindings/leds/awinic,aw2026.yaml          | 92 +++++++++++++++++++
>>>   1 file changed, 92 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/leds/awinic,aw2026.yaml
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Error: Documentation/devicetree/bindings/leds/awinic,aw2026.example.dts:52.3-53.1 syntax error
>> FATAL ERROR: Unable to parse input tree
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/leds/awinic,aw2026.example.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1512: dt_binding_check] Error 2
> Taking this set out of my review queue until this is rectified.

Thank you for paying attention for this commit.

I've already resent fixes in v2 version:

https://lore.kernel.org/all/20230525101341.2036563-1-v.barinov@yadro.com/

>
> --
> Lee Jones [李琼斯]


-- 
Regards
Vladimir