Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1993125rwd; Fri, 2 Jun 2023 03:19:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ51L0yAVpYtV+M7UVVqbPAd1zQUAIgFurRfnj1nSB4ufvMoeyXPkSJXKZYe9wVPoDGD1QYQ X-Received: by 2002:a9d:7a91:0:b0:6af:7e7e:d7b with SMTP id l17-20020a9d7a91000000b006af7e7e0d7bmr2094935otn.15.1685701140577; Fri, 02 Jun 2023 03:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685701140; cv=none; d=google.com; s=arc-20160816; b=dgKmIy5aBJNoZHnaEw32PJc/ZBfvRBV/m+UWLjVQrXgn8BLobxnytTle+vY6i8ZLQf oVSCTztg8sOQ1LxRh2yL+Hg/oO730ZKMLBfsLnaqntgHbqoK0+qrEeTqQ4k9LyuLzaxC pTVWHw9zqmLopsbNdwMlnLh9ihLSQA/6BUeTcwGZfy83ezIc12H5fklhSp8MhTkr1OJh z3zrxSopjDnXDKr+Q93TZebMOK0/bRJAKtasJakR/dzuXwFRFzffaHLrWgPI4fbS9VLr 6Xo0XO40cFsYYZ0aA/fxN/BfPxxHNfwsmPfcFF84jWDtEA/2wNCFv11nvl5hL0VS2jPs FU/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=QspZhkhWQdQD4gUpwkhMOqtT5VUHoWWx+XNQWeKyt9w=; b=h++CvZNglIQE4hXsaQH0PAHQArWHMjFjwMKWRMRH5XTihVrA011gTt5bUEJQtHE+W4 dJKN+YAYV8bb4TWfmSJBRinHYi7Z631Y0nNRFeBdpKosobW4CDMTQs9bQO8aUpyUE2kP ra4Sdc0UJjWtDnw/r5hwoE8p8LVXXP8Ot8voz+eaWi0is/4ZP2KNUEfxgahXbMJIKrML qK9ja/orZKBWU163NjMNPN2JDRDi8uzCSdbTVAVsIYjuwMCXyokYRYgcjV2tsvUN7xtz UBbHJXI3d+y2IkRGZHNdIvfSI8gP0TqrblUuHTxieqAJZG9Yl/Vbe1eMFTexgRvymPbZ 91cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b="KOSr1/OJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a22-20020a637f16000000b00534839d1219si764054pgd.138.2023.06.02.03.18.48; Fri, 02 Jun 2023 03:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b="KOSr1/OJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234865AbjFBJzv (ORCPT + 99 others); Fri, 2 Jun 2023 05:55:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233971AbjFBJzt (ORCPT ); Fri, 2 Jun 2023 05:55:49 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2273AF2 for ; Fri, 2 Jun 2023 02:55:48 -0700 (PDT) Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 939E03F4DF for ; Fri, 2 Jun 2023 09:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1685699745; bh=QspZhkhWQdQD4gUpwkhMOqtT5VUHoWWx+XNQWeKyt9w=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KOSr1/OJnvLrqBe2Q7dz7yusG49kznQGHJMtgu06eiuQBp5u1WVo4X+OoECvl0ocv v7DFYvMk3N1Ig3PNny2CnZNi9j0lTTf79I/7ngXE0mQI2L7qui2Gx8JGmc5c3d0Hps eG+8SYjZskjnDrAYQbRxukRC3TS7R8hD2SzJQ1X5lXz8eyFdM3WRZqlQ5CS10oWVBp /nLJMw1zBjvLGIJcPFSus3th36GwrDSbkQfyhk72XyJ+kaCnG0zmaINrydUBxCqYBE 7CSmEpVy2YnlyuVlO5UggvqQ30e5O/4filBEUwHCkSjagwUpvCcRWh5Rj61sJlPJSi gpj3yDL95hFUg== Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-564fb1018bcso29039157b3.0 for ; Fri, 02 Jun 2023 02:55:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685699744; x=1688291744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QspZhkhWQdQD4gUpwkhMOqtT5VUHoWWx+XNQWeKyt9w=; b=D8Mo2iu2hquHmMPbP4QOgEkpePFRyvV/djMCuESkwgpTj/y0rPuwOLX/aBRLBqDc5/ C6jToAXPaP3jNiXvScy/6zaaPpnNwNm7hxM8vn2jJsIrYUgGmH+THHGgf4Vg6FTAYkKN i7z+z4+LffM01DOpDJbJXra2f7TGEutMt0kYuH9g6/c7VqMNi0rS7/HtssNhnSB6mh5N Q63CqnKoIApY0BDRFc8wK2GkLoxGjFCeJR/IU5l0rtQC4cWniTVN9GcZNy8zSMBzbOHu pcUOmVm/RnUQ48uCEuD+h6IqIvIzVDk63ncI/7UviCjDkVbQESmhsaZKLTAmzaF7uEkE Jd6A== X-Gm-Message-State: AC+VfDxHydD2rjDXEAjynLrGuTxtMqmSljj9B4RxAL+UOleetuHjDY3s P5+WlOzSpzkm12gFSb3ni1ODvrrePiaBnz7i40ADJu+HBp0Do082lzkEqAj72xsdGs9+W00Uxud zcyL9bGAMiEunR7TM3nuRSNYykHORpNYP6YdIHOb/VB6GyRc0k7qqTIVtfA== X-Received: by 2002:a25:e7c6:0:b0:bad:1131:97bc with SMTP id e189-20020a25e7c6000000b00bad113197bcmr2366568ybh.41.1685699744721; Fri, 02 Jun 2023 02:55:44 -0700 (PDT) X-Received: by 2002:a25:e7c6:0:b0:bad:1131:97bc with SMTP id e189-20020a25e7c6000000b00bad113197bcmr2366559ybh.41.1685699744492; Fri, 02 Jun 2023 02:55:44 -0700 (PDT) MIME-Version: 1.0 References: <20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com> <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> <64672c51-498a-2a0c-4d4e-caca145fa744@redhat.com> In-Reply-To: <64672c51-498a-2a0c-4d4e-caca145fa744@redhat.com> From: Aleksandr Mikhalitsyn Date: Fri, 2 Jun 2023 11:55:33 +0200 Message-ID: Subject: Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put To: Xiubo Li Cc: brauner@kernel.org, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Ilya Dryomov , Jeff Layton , Alexander Viro , Seth Forshee , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 2, 2023 at 3:17=E2=80=AFAM Xiubo Li wrote: > > > On 5/24/23 23:33, Alexander Mikhalitsyn wrote: > > These helpers are required to support idmapped mounts in the Cephfs. > > > > Signed-off-by: Alexander Mikhalitsyn > > --- > > fs/mnt_idmapping.c | 2 ++ > > include/linux/mnt_idmapping.h | 3 +++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/fs/mnt_idmapping.c b/fs/mnt_idmapping.c > > index 4905665c47d0..5a579e809bcf 100644 > > --- a/fs/mnt_idmapping.c > > +++ b/fs/mnt_idmapping.c > > @@ -256,6 +256,7 @@ struct mnt_idmap *mnt_idmap_get(struct mnt_idmap *i= dmap) > > > > return idmap; > > } > > +EXPORT_SYMBOL(mnt_idmap_get); > > > > /** > > * mnt_idmap_put - put a reference to an idmapping > > @@ -271,3 +272,4 @@ void mnt_idmap_put(struct mnt_idmap *idmap) > > kfree(idmap); > > } > > } > > +EXPORT_SYMBOL(mnt_idmap_put); > > diff --git a/include/linux/mnt_idmapping.h b/include/linux/mnt_idmappin= g.h > > index 057c89867aa2..b8da2db4ecd2 100644 > > --- a/include/linux/mnt_idmapping.h > > +++ b/include/linux/mnt_idmapping.h > > @@ -115,6 +115,9 @@ static inline bool vfsgid_eq_kgid(vfsgid_t vfsgid, = kgid_t kgid) > > > > int vfsgid_in_group_p(vfsgid_t vfsgid); > > > > +struct mnt_idmap *mnt_idmap_get(struct mnt_idmap *idmap); > > +void mnt_idmap_put(struct mnt_idmap *idmap); > > + > > vfsuid_t make_vfsuid(struct mnt_idmap *idmap, > > struct user_namespace *fs_userns, kuid_t kuid); > > > > Hi Alexander, Hi, Xiubo! > > This needs the "fs/mnt_idmapping.c" maintainer's ack. Sure, I hope that Christian will take a look. Thanks, Alex > > Thanks > > - Xiubo >