Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Jyri Sarha <jyri.sarha@iki.fi>,
        Tomi Valkeinen <tomba@kernel.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state()
Thread-Topic: [PATCH 3/3] drm: Fix references to
 drm_plane_helper_check_state()
Thread-Index: AQHZlTJEuVN3WjOI50uBFusv3IV2Yq93S5lg
Date:   Fri, 2 Jun 2023 10:16:50 +0000
Message-ID: <OS0PR01MB59225B787D7F3B179840CA6A864EA@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <cover.1685696114.git.geert+renesas@glider.be>
 <2408d7841c91e98e9a2b24b1b4df9b2b865519a6.1685696114.git.geert+renesas@glider.be>
In-Reply-To: <2408d7841c91e98e9a2b24b1b4df9b2b865519a6.1685696114.git.geert+renesas@glider.be>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DEkgYUhpt920N3yB9WqkCFFChRtC6yvA38SV0sx19Eg4dfj2jW9ryM1A42vF?=
 =?us-ascii?Q?UndsSpq+MpfX/fv4KvECG6c/qioNwbLKQjGPCjt6T9MsSudcdthX2+yBoRGp?=
 =?us-ascii?Q?7NjhVY5d1CXc3CDTRbpYZKLoHvjwXqN7+oBs2ZDV6R1AVLyvbqfyxrgPkUyy?=
 =?us-ascii?Q?BjkvVjLYwZ7HiTr1kYkadyQDGPox5zMIHA+ZPb+el4U9OJ/YVLnEt5A+kHn5?=
 =?us-ascii?Q?qKdJ9eEhY3+7KJPccLrGtmTLY1sxkewvARLkNR3VXEJBsj20Fo1pQaemMMvH?=
 =?us-ascii?Q?eDEM2u4R2ERAwkbis+lklUTfWARiWMiaZJ1TNQijij2mPP+Ee81PI+XAxsah?=
 =?us-ascii?Q?T8Kp7QdSfcq9UHaLT5WDmlRbDKnXZdFXIeCUAMOE7h4x8NRUjAw+GdVQQhV8?=
 =?us-ascii?Q?oDqn2ICykY81FZm4Oa+GHfOEw0M3vKkf2JvZdQUl+cvBMClPyXQwKBXf+u79?=
 =?us-ascii?Q?Mh0lbZ1olPLXtN3NmW8QpY/Em/jfTlmBC5UfSomX4IaU27d5PIy8OsQml8x4?=
 =?us-ascii?Q?ZkKKxp7ng6WNNEzD7kMx6H2OPTOjw+T7Pfhp6z8M2+5H0SFHIW8E2XAudVuc?=
 =?us-ascii?Q?OJao/TNHX5lmrorPMtf4FRGhv4sZ7ZhplgS+G6oH15+Rr+c3L8B2IVT7xJC4?=
 =?us-ascii?Q?v+CSO4Fk0N1fh4O+7tCbypt/hmAhCUkfMouLS4CIV9C1UcL5XbRW4iLeKP7L?=
 =?us-ascii?Q?CzeRh6ChgAeD5s1E7FOlTX8byf6KLKA2Nc8XwD4+uugGSVYZtDaYl31u9Fad?=
 =?us-ascii?Q?mo+oYgP+Ie9saAcooEM2o2APY2inU+JX75YQjR0TXfQF30TYb62hQcbFxckV?=
 =?us-ascii?Q?hYRKEqG3qXSnUtqU9W1GzizsBCybbVi0+LOudngoJGRivlX1qWbZz6U0H/GE?=
 =?us-ascii?Q?6+Esbu5PogM1eWT2QlTIaa2Wlp3maeRzi0cJP2QpVjbe6eysVvuFZgsLkupc?=
 =?us-ascii?Q?jJBfGV+EWyY3NaVycT2QQvSi8Ts/8K7qmJoYcvc/ZhGonf5KVHbfWDlS/VE5?=
 =?us-ascii?Q?9pfHiolJanaCmBOVlLMwdO9sM+VwI/qmRC1g4HRgWC5bPWPpxvTx9yw2EH2w?=
 =?us-ascii?Q?UX0tqkM+BHCE5BQMQ8lCB97g9GiKrEQZcPFHNmgeFHA1Ek/oYpO0xLxQIPru?=
 =?us-ascii?Q?87WFmhdEmilEh0xy/iYD0eiOarrSiclUId5P1B/xJgzGJxxuvYQ7By9IkF7i?=
 =?us-ascii?Q?u2cJUqccb8RTdjM17PyfS0Hqtkd1gHOmPZmx+eDGAdnuQsQgNsExkdPl0uYb?=
 =?us-ascii?Q?Dc7LL97mRpUakwzdkCNv468va+SFEhu+kRoy7vOJV9723DAmxO+S7okJTk1k?=
 =?us-ascii?Q?eJVUy9XAg5bZVRussmEIIzZdWRJ1a6Hh7rGoV8VjB2K+mgjc4cMcruP0iJzo?=
 =?us-ascii?Q?s4xVRgiJq/WO/iH2OQV9+vi0HovXj0tok+Qk1GEsRCcooh3odhzIi1iO0dU5?=
 =?us-ascii?Q?e0QXtyNDVK+9YVm7/OrC4Pnv4Kw2tlVe/rhTlZmnAnieL8d65gdTbInIahmm?=
 =?us-ascii?Q?5FSfOdKYvOVvPVO/B4sa94iHn25vrlk2k9BPujpVqXIvDKlxWB6eLvup8kCh?=
 =?us-ascii?Q?WhAEIw3MyHBaIuGGf7cXavvEoz5nQ+FfrZOO1GWv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f62386c3-c074-40fc-84ec-08db63527b3c
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 10:16:50.8642
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: byb7UcXXUcFotvkgePGdSVouQrOcsRlB9lXEObQicbDdb1ok1X0NfejYdG/eeQaFSduFJSQgMZzmTi1itF0ytS0tGeh5IZs1su4ngBMvZJw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0PR01MB5361
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Geert,

Thanks for the feedback.

> Subject: [PATCH 3/3] drm: Fix references to
> drm_plane_helper_check_state()
>=20
> As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state()
> into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer
> exists, but is part of drm_atomic_helper_check_plane_state().
>=20
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Interestingly, all these comments appeared only after the commit that
> removed the function...
>=20
> This is against next-20230602, which does not have the drivers/gpu/drm/{
> =3D> renesas}/rcar-du move yet.
>=20
> Biju: you're adding a new copy in
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c

OK, will update the comment in __rzg2l_du_vsp_plane_atomic_check()=20

as it is moved to drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c=20
based on Laurent's review comment.

Cheers,
Biju

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++-
>  drivers/gpu/drm/tidss/tidss_plane.c     | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> index d759e019218181ce..e445fac8e0b46c21 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane
> *plane,
>  	if (!state->crtc) {
>  		/*
>  		 * The visible field is not reset by the DRM core but only
> -		 * updated by drm_plane_helper_check_state(), set it
> manually.
> +		 * updated by drm_atomic_helper_check_plane_state(), set it
> +		 * manually.
>  		 */
>  		state->visible =3D false;
>  		*format =3D NULL;
> diff --git a/drivers/gpu/drm/tidss/tidss_plane.c
> b/drivers/gpu/drm/tidss/tidss_plane.c
> index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644
> --- a/drivers/gpu/drm/tidss/tidss_plane.c
> +++ b/drivers/gpu/drm/tidss/tidss_plane.c
> @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane
> *plane,
>  	if (!new_plane_state->crtc) {
>  		/*
>  		 * The visible field is not reset by the DRM core but only
> -		 * updated by drm_plane_helper_check_state(), set it
> manually.
> +		 * updated by drm_atomic_helper_check_plane_state(), set it
> +		 * manually.
>  		 */
>  		new_plane_state->visible =3D false;
>  		return 0;
> --
> 2.34.1