Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Jun 2023 13:32:14 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     wei.fang@nxp.com
Cc:     claudiu.manoil@nxp.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: enetc: correct rx_bytes statistics of XDP
Message-ID: <20230602103214.6uzugiwjrhjcs7wk@skbuf>
References: <20230602094659.965523-1-wei.fang@nxp.com>
 <20230602094659.965523-3-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230602094659.965523-3-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+QsLJgjnqFWnZ0ntDCoXFVEAiqA9P8IGiwyGKjULVVbAtzcgqHH+XcUMBp9W?=
 =?us-ascii?Q?UPjZbOepXE5NySAt4pt/AfXLyWz65Wa45s3EJFan42H1GhBSkydZiuWSnJuI?=
 =?us-ascii?Q?KdjGXry9YCYsze7qODUROPutpVMwxkYHyFIJsV/IwHgJBr/EeKjxCDLcw5ol?=
 =?us-ascii?Q?SXRRdwknaABE62esV+cOBuDYZwrEySUvkLa4yxL0PPSDRqfcPZ88FHlU9G1p?=
 =?us-ascii?Q?+NsSjPQSCNkc+bpK9m+SOSRCzB3gleYJfQh+dC0RDUhpp5zOxab1w7M8+0ty?=
 =?us-ascii?Q?+3KhSMSIqBEwrWcmq1dKMttf0kdVlcgJavAO4vxm8JY63cUNbTPynnvcoKpb?=
 =?us-ascii?Q?ViRZvyb1Tyw8vJ0uu+vPp9t6wVSzBJi8sVs/piaW/aKzpB3wRseofL5dZpzD?=
 =?us-ascii?Q?bCuSNKgXxpYojdSmnHtlD6oHgD22GBLSdyNdMvAYI4b17XK+yPl2oOJiZr3w?=
 =?us-ascii?Q?isMRUe/6Rhc+6Te211Psb0pXq2ptG2/JPaZjhvP4jblDG1GUj1YT+kXVw8WA?=
 =?us-ascii?Q?CsyHb3HZVZBRfqHMZemf4qxSUXRXOMbpX/NJGQ0Wx9zVHrZiCkbB00ruBr8l?=
 =?us-ascii?Q?CK9aY9TavMn6pWozsXa83r45rpZ1e6SWyGeNSID0G/AOm0O1hVGAZeAGUN5N?=
 =?us-ascii?Q?pbM8j1SitHuhPRjzTj1EUkLjcg5vYFU+zNZLPh6j1X8B5PEyyiAWDDhusEPT?=
 =?us-ascii?Q?PSu6QPxnmJoAKEKDW0TOqXaMoMVVtqr4cynsf0AJ5v/qMLaLYgz9u0QbUCOK?=
 =?us-ascii?Q?D9tZLawosvlKSVIGyL3wnI5BXowgOI1sAtGjn89b1CsZkwVB53+G5hx+LZvx?=
 =?us-ascii?Q?yadq2G/w2Nykbh6GXgaoJUfaKatdxlKIN3PO4Fgx14ZL9R0jA1dNOQT+2e2k?=
 =?us-ascii?Q?eVhRUjXIsb9ZRwTEqvPC/Sd0Xo0UB4FTSA7d1q2+WUi+vcjBTIjz8BJDu6be?=
 =?us-ascii?Q?TeQpnZc/vMs7rtMVWBye86MWYhB6zzMRrnIWTDfUBtbJ7WE/sauPQ1Vg2soU?=
 =?us-ascii?Q?jy9Wf8UVuIlXyzrsvuCBGNmPDOhspp8Z96cIMIYIysa/AX5cQmzU0S24yDfx?=
 =?us-ascii?Q?42/WFU7SBLOS9+or0EydTshmYx/hfL+IF+VrwM+iiBWZEUpRrdnZpl2qNJlX?=
 =?us-ascii?Q?1ICqTmAstWO57yE6eb4SiBiaQmTlX37S+p1K2w0i90dO4/PHP4Cf7Mll6aL+?=
 =?us-ascii?Q?AesT92RR3impfsA/Z318edZiRlki+OeKyygPxNdnVmTurfKfShZvtowumH1N?=
 =?us-ascii?Q?mGF25hMlRwxb94TLEMQVsRnnwyByEnRaJl0EKYuNsXKiun/bZ0ek+Tn7LO1G?=
 =?us-ascii?Q?3GefyzdE0D/WeIFJGDOBi/f9kqW0J5QOoxFY9/gkelRGwpOkeQg3Uhiv3w8v?=
 =?us-ascii?Q?K/qUMMmPY2oS//t+jg8XFyQidjn41jn124tvNBKDhjXFIwbF4Tj28jMIhiGN?=
 =?us-ascii?Q?EAQ4NrO5UmCl0irnGPDTrqlxTUQQSXwXcE3ReXz+jCP5esYtD3mmQP6TKv4T?=
 =?us-ascii?Q?UXPBUeqNgeWvKF/KexwdtT08aP6JG6tHFPnHuUcdfWnR4gfnVLyD4YrxvVRP?=
 =?us-ascii?Q?JScfCt8riiDN/+Ojy5IvDybE2qiD/w8qHIl1RENaMvnD5Ok7BwLnOEonEElB?=
 =?us-ascii?Q?yA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8f02f6f-6e24-4107-8d0f-08db6354a3ab
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 10:32:17.8756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nqc5DYA0yxkVLDGZ0QLeXegOy7+KXj/3zYGci6SKu2axyF/5J6NVnyKxB3NsxCNntYHRhLbBExs7ldfY/s8BZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7502
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,
        T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 02, 2023 at 05:46:59PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> The rx_bytes statistics of XDP are always zero, because rx_byte_cnt
> is not updated after it is initialized to 0. So fix it.
> 
> Fixes: d1b15102dd16 ("net: enetc: add support for XDP_DROP and XDP_PASS")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Thanks!