Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Jun 2023 13:31:42 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     wei.fang@nxp.com
Cc:     claudiu.manoil@nxp.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: enetc: correct the statistics of rx bytes
Message-ID: <20230602103142.ryesgb7ykamtzxnx@skbuf>
References: <20230602094659.965523-1-wei.fang@nxp.com>
 <20230602094659.965523-2-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230602094659.965523-2-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dK2idyzXApJtUuANMEEwOHrR2gt3VUp0mO0a4ziY37zqiMrEZNJlRkPlJkpi?=
 =?us-ascii?Q?4jD31vgs9+g+TG4Rttjngq+zh4DY99krSr0dFa3Az2/Vr5+w2vucDuKlTDAD?=
 =?us-ascii?Q?LhgQeXAXWRhqeSq3CQr72VNcUuhuWQqeuQeGTOExTp/1hGx/CqNJSLP1NfVH?=
 =?us-ascii?Q?Hpl/xiZNtPyr5z8XzYO15nXKSuUmu4XnozCvCILMEO0zD5EJkd7Vcuq7bPx/?=
 =?us-ascii?Q?IQP3ePAnMq3IliITOpC/u7hqXQOoNs6p0XCxtHHPW6Hnb4xo1t3ucESj3Dqk?=
 =?us-ascii?Q?ImYRkXnEAbZcfcI7ZtlzLhHtXsxY3ISpXgDP9oH0lxAGgXLyzJ+6z3G3yf7H?=
 =?us-ascii?Q?1gsHsfNRZbFnGBSC/ZNaXtbyP5Mq7XhC8p8QKAiqJ8Nr+K+MGUc1DBqIt104?=
 =?us-ascii?Q?q9QnzNJm5YAwVd9gTWx2pZV3+HXcsCvyIkmpcZHjYcDYtjQYoQZoJnHEAlhj?=
 =?us-ascii?Q?zdRVJWQzgTlL+JO4w8KBSoqFr2NY+xVwzyRNWjphQkisumdF9nEAG8w+R3kw?=
 =?us-ascii?Q?irKBjcRkacMfyVsZuklemsFVNmvgsQxIpg+HXLv04pbbxlMeEtk3xuJK+gnJ?=
 =?us-ascii?Q?j5MfgzDnrNZaF1SsnKY4dD+y9cMnvi6QP19j5XgW+6PuTMtXCQJbJDjc/cc1?=
 =?us-ascii?Q?hjyeDxXlxXw9MZtpzbh1QBbCCpXzBf4nBQf0fmEDvGHkNNp9iHvA6uiPeFIK?=
 =?us-ascii?Q?du1hvzCd0xwAwn34OGqt0YwW1feSzR2D5192Xg9J+0bbz+vdmgD0Yr4gwby2?=
 =?us-ascii?Q?N8A79AlnnpFZe8ez55Wc3mUDIE/VinJWLtH/nWvQIzrK26ETmGZQC0S/pHVm?=
 =?us-ascii?Q?VNxrjKgvJOdaurK+AqMtTMtB7eHFz/f97bWJJttydWvCxyKNrClkVsm31j9O?=
 =?us-ascii?Q?aEJdONTu3NTV2wEK96bQF2Sur0m/+3VhCWDTWLJtHQ1qa8UApLrS8RAXwjYN?=
 =?us-ascii?Q?DKv34XPxVGiZFdltgEgKDRmScRQZQKJHQcWYCed9pV7LZMztzYHXs4B1P2oU?=
 =?us-ascii?Q?yfily4ca4WPCPXWt17XoaLtJYZTNNaCCD8Mg45sPkrTCrGj0R4dGmHGdWAG4?=
 =?us-ascii?Q?D3DoVzaSp87LnGLkV9mm5depueveA2qfx14Jl21F6xkCU0yM/Lu6Tg1wlczl?=
 =?us-ascii?Q?LpJgqlmlGjwaqkzSgg8+Yvfv9hWVDNHJHg+vclKEzaBT92SNPxBwGA084GIA?=
 =?us-ascii?Q?EIbPvc7Nkga1kq39MY+ZbxLm01df9Qb3JfUSKMNTm422Yf05N79izaF2kOjx?=
 =?us-ascii?Q?17wbLEJ7iI6++9Zeit1L0mlKal3xPDou03bbfhYdvPmg53kRXYV4D5CFdkvM?=
 =?us-ascii?Q?Tt7qrkiE+o3FpPHho7/OSrT41thHuac+IIiK4bKQfX9LTAxGn2EW8equ6e+o?=
 =?us-ascii?Q?Ig4Df1goAORtxaViVdmm1NgBEIobfEp3LohX61M23/rJp81f1mf7Ce8Qorvi?=
 =?us-ascii?Q?DLA9KJYeyAjG1Svy5ivSRV7dJuJM8IQ+hPdA8hsKIKa2iQu2PSuu0BZ+t/Wg?=
 =?us-ascii?Q?16aQ/hMY24y0PoEn7v4z9pkyETBVhZeW5gEh4R6hRwT8wyRAPlR3jfSFbu42?=
 =?us-ascii?Q?QoVT0ySD8f0csXNfmht6jhm+BR/nA1NqHAc6R0ey5n5NAj5hsyBGs2muQ4wf?=
 =?us-ascii?Q?Lg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb22fe5b-30f6-4f6d-0d4c-08db635490ac
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 10:31:46.0252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8S4SQb+4N/KU2Wj7sFTX+XAo6U8EY2AWjk6ZSUst+Jrd2jZEE/eDvAVDXn6VOi9lMtf/tdN63LoZtRtDeuuo4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7502
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 02, 2023 at 05:46:58PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> The rx_bytes of struct net_device_stats should count the length of
> ethernet frames excluding the FCS. However, there are two problems
> with the rx_bytes statistics of the current enetc driver. one is
> that the length of VLAN header is not counted if the VLAN extraction
> feature is enabled. The other is that the length of L2 header is not
> counted, because eth_type_trans() is invoked before updating rx_bytes
> which will subtract the length of L2 header from skb->len.
> BTW, the rx_bytes statistics of XDP path also have similar problem,
> I will fix it in another patch.
> 
> Fixes: a800abd3ecb9 ("net: enetc: move skb creation into enetc_build_skb")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

By the way, you mangled Jakub's email (kuba@kernel.or) - I've fixed it up.