Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>
Subject: [PATCH RESEND net-next 4/5] net/sched: taprio: delete misleading comment about preallocating child qdiscs
Date:   Fri,  2 Jun 2023 13:37:49 +0300
Message-Id: <20230602103750.2290132-5-vladimir.oltean@nxp.com>
In-Reply-To: <20230602103750.2290132-1-vladimir.oltean@nxp.com>
References: <20230602103750.2290132-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5wUo5hx1WWbgsUAn3CrKvu47D37CnEp3BHq/AwL5YoB4YWNf3wtAyYwj57a1?=
 =?us-ascii?Q?BBQAFjN+vnU53v55W8bdAJX7NjBJU/hl+Nc8cjg99qaATgqhVLB/4P6ysjS9?=
 =?us-ascii?Q?394bP7cEY61y+81TvrrtZaY7GhronHsIDBiKdlh8v9DctvuTNaXJ2BHQ544Y?=
 =?us-ascii?Q?sjmFGBrWuzq7xLmXFt9t+LrcNcXkQS0sw3usHCIi+6D8872+q1HlR7br059C?=
 =?us-ascii?Q?aOKKbF7IgyuwIeyAoBzmL6qzuiXuptCNsymFfk+MXIC6bD341hS+FPU0IjVj?=
 =?us-ascii?Q?stkqf+vGF6hxcCE/4TfT6vZ8uEPRsUz+Fac/B/Whj4YNcxQe9O3kMcVtSRNS?=
 =?us-ascii?Q?L7qHHiyDtZq+hOL9ieSbqZQ1AI5uUFEvlE/QLtvkpy/lBpRVV8XaGux8QaCF?=
 =?us-ascii?Q?2i0AtfayM1gHcxdkPwNhcfUQsAtZdqfAAysNRWbbo05zNxFwCAoxX0o/V4Vd?=
 =?us-ascii?Q?++BOMwIi08h74S3g2NrV6N0aWbALEXCnN/SF0rXcxCn5pVMhkRjChFfdMh29?=
 =?us-ascii?Q?1nBLy95Sc5xgXrudbVFtN3vjLZUQ4kq6L7ydOsu1Zy4C0qlP/21MZplbj+yu?=
 =?us-ascii?Q?pALNXyviD+rwk/MKq4CZwlEFzRLPMSnJZh1KCZpEjzcl+/z64kaYrUa+1xni?=
 =?us-ascii?Q?BuIYFVHTQfC7cjQRSXwFz1leL5YsNo2B9CYw2j75NSv8Bx4s3iF/tdt82t7v?=
 =?us-ascii?Q?KdHmwTghT6DCVTKW9G8ZttJ0tzlPp2m1h4Km5mAXpDtENKFc5XvJwsh6ZOIW?=
 =?us-ascii?Q?FrUL1mat5a4bBOOQjuYkby1sva+PKVPajf4mW+sbGfPfJf5xf5w4sdXQ1Evk?=
 =?us-ascii?Q?JL1KvBux0FSdBXF43jvljLJQLuoKm7p3Cz5X4LWj+uuKKBqyysk403yeWE5D?=
 =?us-ascii?Q?309yMZheHUfKXIhe1iWSi9Q+G0Rs93tsYxj/wxy5I+YBZh92gDDtyee6DhWu?=
 =?us-ascii?Q?EuI68H2lXG46/Q7Jo26gfNWYVzGO6Yn8aQpJ2gKIQuSV4GmbQEbpzmGZcFXR?=
 =?us-ascii?Q?aMIZja0XHFTWyVYPsn018b6te1UxhufuPZK5jRDf4g8P/YsqmfECjms+L0Gy?=
 =?us-ascii?Q?CuOxQtHYVA78MlagBWD5/jVcZMk2XedhFdD78eOc1+j5tC0opQSCZvPfXrEB?=
 =?us-ascii?Q?WJvZyNIVXE03lOXQUmp2is5XcSN3EpS1aomvQB14lVEd7iDI5C1EOtoX2FxI?=
 =?us-ascii?Q?LCM1MfXN9cjt0Yybh3cN/keqSYSKYPsuTdSjMAYcYbNsPkrWTZRruVmWRFQZ?=
 =?us-ascii?Q?9XMTlgDWNqmkZ/psxOtIy2rg9kCtqfjXyCKr3wkpmb7N3LPgdsZRkq9snsO0?=
 =?us-ascii?Q?BKk5kxXPiCQM4JMNm/9SNZZt6wEit9PRsMpy3oX/NPbMBP9BWkuSiigjsk0T?=
 =?us-ascii?Q?X/jpK9qu2V0qz36tv7R3/7hj12ICRRJQGqVSAKnnw5EQYh4aTGrNxTAgZXXw?=
 =?us-ascii?Q?gcGNfgw0MrlDG+309B2L/3UaTyI4PGfk05pJrFB+tiLIAhkPb0t2NcnPWlXw?=
 =?us-ascii?Q?7dfyEh0zsIO51IKkQ/E4vDI17RYPqfClq2384aKscTPHQxuk+M2I6Xw/HHss?=
 =?us-ascii?Q?UQztCwopNoTbJkJLu4WhQHn12hLQLY/ALV9UliUpJEWzcBIox7Ht2/mM+Ojh?=
 =?us-ascii?Q?tQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1708cbfe-17bd-43fa-424f-08db63557c63
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 10:38:21.5272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mmo6/kc9MWV/wvrbG4gprOQ4exyFZerVft5Q/jKhV2kP4HkYzJTMDYxNousPCxAkALzpDDxYpl4v9Bg32s71ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8926
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As mentioned in commit af7b29b1deaa ("Revert "net/sched: taprio: make
qdisc_leaf() see the per-netdev-queue pfifo child qdiscs"") - unlike
mqprio, taprio doesn't use q->qdiscs[] only as a temporary transport
between Qdisc_ops :: init() and Qdisc_ops :: attach().

Delete the comment, which is just stolen from mqprio, but there, the
usage patterns are a lot different, and this is nothing but confusing.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/sched/sch_taprio.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 263306fe38d8..cc7ff98e5e86 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -2084,11 +2084,8 @@ static int taprio_init(struct Qdisc *sch, struct nlattr *opt,
 		return -EOPNOTSUPP;
 	}
 
-	/* pre-allocate qdisc, attachment can't fail */
-	q->qdiscs = kcalloc(dev->num_tx_queues,
-			    sizeof(q->qdiscs[0]),
+	q->qdiscs = kcalloc(dev->num_tx_queues, sizeof(q->qdiscs[0]),
 			    GFP_KERNEL);
-
 	if (!q->qdiscs)
 		return -ENOMEM;
 
-- 
2.34.1