Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f125f0db-30fe-5452-4669-3e48f7856569@redhat.com>
Date:   Fri, 2 Jun 2023 13:49:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 1/2] mm/memory_hotplug: remove reset_node_managed_pages()
 in hotadd_init_pgdat()
Content-Language: en-US
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     osalvador@suse.de, rppt@kernel.org, mhocko@kernel.org,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230601162626.1030-1-haifeng.xu@shopee.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230601162626.1030-1-haifeng.xu@shopee.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01.06.23 18:26, Haifeng Xu wrote:
> managed pages has already been set to 0 in free_area_init_core_hotplug(),

"via zone_init_internals() on each zone"

> so it's pointless to reset again.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---
>   mm/memory_hotplug.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..65e385f34679 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid)
>   	 * online_pages() and offline_pages().
>   	 * TODO: should be in free_area_init_core_hotplug?
>   	 */
> -	reset_node_managed_pages(pgdat);
>   	reset_node_present_pages(pgdat);
>   
>   	return pgdat;

With that, reset_node_managed_pages() no longer needs to be exposed 
outside of mm/memblock.c

Can you unexport that function as well?

-- 
Thanks,

David / dhildenb