Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Jun 2023 15:08:19 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Janosch Frank <frankja@linux.ibm.com>
Cc:     Colin Ian King <colin.i.king@gmail.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        David Hildenbrand <david@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Shuah Khan <shuah@kernel.org>, kvm@vger.kernel.org,
        linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] KVM: s390: selftests: Fix spelling mistake
 "initally" -> "initially"
Message-ID: <bbd79f29-f490-4fe4-b5b9-2a0a85c31431@kadam.mountain>
References: <20230602102330.1230734-1-colin.i.king@gmail.com>
 <f0f0587b-5f19-82bd-3d58-bdb89ff59f8c@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0f0587b-5f19-82bd-3d58-bdb89ff59f8c@linux.ibm.com>
Precedence: bulk

On Fri, Jun 02, 2023 at 01:07:45PM +0200, Janosch Frank wrote:
> On 6/2/23 12:23, Colin Ian King wrote:
> > There is a spelling mistake in literal string. Fix it.
> > 
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> Hey Colin,
> 
> I'm not a big fan of such fixes since they are most of the time more work
> for the maintainers than they are worth and accepting one can result in a
> flood of similar new patches. If this would have been your first ever patch
> I might have considered picking this but that's not the case.
> 
> That being said, if one of the other maintainers choose to pick it I won't
> stand in their way.

I kind of get dread when people ask me to fix a typo in my commit
message.  The drudgery of Sort by thread, Up arrow to the patch, Hit e,
Fix the typo, Add the v2 to the subject, The little note under the
--- cut off, and Hit send.  FML, right?  So I sympathize about not
caring about spelling.  But this is a user visible string.  Kind of.
It's testing code...

You should improve your process so it's easier to apply patches.  For
me, I type "i" to review this patch in context.  Then "ESC:q" to leave
vim.  Then "ap" to apply the patch.  It's six key strokes.  Anything
more than 10 key strokes to review and apply a patch is not Web Scale.

regards,
dan carpenter