Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762120AbXJML6S (ORCPT ); Sat, 13 Oct 2007 07:58:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753918AbXJML6H (ORCPT ); Sat, 13 Oct 2007 07:58:07 -0400 Received: from x346.tv-sign.ru ([89.108.83.215]:49355 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752642AbXJML6F (ORCPT ); Sat, 13 Oct 2007 07:58:05 -0400 Date: Sat, 13 Oct 2007 16:02:30 +0400 From: Oleg Nesterov To: Andrew Morton Cc: Mathieu Desnoyers , viro@ftp.linux.org.uk, kamezawa.hiroyu@jp.fujitsu.com, linux-kernel@vger.kernel.org, sam@ravnborg.org, netdev@vger.kernel.org, Pavel Emelyanov , Sukadev Bhattiprolu , Paul Menage , "Eric W. Biederman" Subject: Re: 2.6.23-mm1 thread exit_group issue Message-ID: <20071013120230.GA130@tv-sign.ru> References: <20071011213126.cf92efb7.akpm@linux-foundation.org> <20071012140328.f82af8e8.kamezawa.hiroyu@jp.fujitsu.com> <20071011234202.2f15bb76.akpm@linux-foundation.org> <20071012064658.GA8181@ftp.linux.org.uk> <20071012001325.ba02a6f0.akpm@linux-foundation.org> <20071012194759.GA31733@Krystal> <20071012180349.b4b4c2c3.akpm@linux-foundation.org> <20071013114820.GA121@tv-sign.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071013114820.GA121@tv-sign.ru> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 32 On 10/13, Oleg Nesterov wrote: > > On 10/12, Andrew Morton wrote: > > > > Bisection shows that this problem is caused by these two patches: > > > > pid-namespaces-allow-cloning-of-new-namespace.patch > > This? http://marc.info/?l=linux-mm-commits&m=118712242002039 > > Pavel, this patch has a subtle difference compared to what we discussed on > containers list. It moves put_user(parent_tidptr) from copy_process() to > do_fork(), so we don't report child's pid if copy_process() failed. I do > not think this is bad, but Eric seems to disagree with such a change. > > But I can't understand why Andrew sees the same problem _after_ this patch! > > And which patch removed the "put_user(nr, parent_tidptr)" chunk? Aha. I am looking at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/broken-out/pid-namespaces-allow-cloning-of-new-namespace.patch Looks like the original patch was damaged somehow, it doesn't have the "put_user(nr, parent_tidptr)" code. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/