Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2152392rwd; Fri, 2 Jun 2023 05:45:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5EjsMnisj7IVtRJA+1WjUVHrMWbE8P4vfpQ/GyzN3+tWB68xWmdyW6hU3gqeSG1nIfSFNo X-Received: by 2002:a17:90a:ab8a:b0:256:5b86:4f8c with SMTP id n10-20020a17090aab8a00b002565b864f8cmr1203469pjq.43.1685709947706; Fri, 02 Jun 2023 05:45:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685709947; cv=none; d=google.com; s=arc-20160816; b=hX9Rdq6APasPtGzxW4ojciP6cua0gcyOjNbsWRVg4V1ssyD1BDrlTkBSuIH+UGc30u 700A/DmmszKaW1U68vIMpEpfGKNQtoQLgF262K0hvYdsvB86HqQH2T5vC/Yp86YVXY1R YdCC7qKNBkJYRRblwy2XeD+08m0QSXedw9MQWrj8Ug21oNT2+5spbGQZFNGwNFn7mwnR Sl764S6wt8SbLzIfz6A96zWjBDFQDWDv6EXIJuXxbsZ4ZfEAaWXzkEVjMvG7ge8I7GF6 IozQGYnXkEvMTY/RqHATR7INVJY5PrF+IedvWKgrwcb3/hhYVTCbqppMFcmGmyZkJvMp iUhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WcSLfirs9Oef60gSCL0PxN2oAOkn9q0gdtsQLSNszVo=; b=Q/GM1ICpdT1F6RHCdY/AUDb0JEdORyH/eziFoWcAi17jxPMwuqpv2KQWn+QfbN+yR1 G+mCYTHn0a2cTp7cIncwn0i+2cbBzQDA61z6K94gjbR/e8GyeK6LRXaMvLoTYmN9lknl F5RJwtYLY0B3L6avWlnd/NT0w7iXizQsM/2seedIXExO8RrP1lvQ7k3N6i58h2Icv9PJ VefbR68PRCFmlqtYHxCSB+oeirhlOKgO59TWxg7VO9TEp55p6r24ZKeoeoWewqjz+f5E 8aNTLzITmW4QnpPtZlBy1EMq46neybw4mXRtrbtuQ9qm53eQLQlLy4DE13+zL9fh6n9r d4ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RHpXetLu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 12-20020a17090a1a0c00b0024bccf6609dsi460875pjk.114.2023.06.02.05.45.29; Fri, 02 Jun 2023 05:45:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RHpXetLu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234248AbjFBMkm (ORCPT + 99 others); Fri, 2 Jun 2023 08:40:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234530AbjFBMkj (ORCPT ); Fri, 2 Jun 2023 08:40:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2823180; Fri, 2 Jun 2023 05:40:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46CE764FED; Fri, 2 Jun 2023 12:40:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AACCC433D2; Fri, 2 Jun 2023 12:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685709637; bh=wFvoHZitiOtC290G+wp4+/TYZYR62ERLRNIegvZqTQs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RHpXetLu3iBOp1GxAghgEgStinoRkVPS9grxrD1Z9uKpmUD4XokSL6ilTp6QNjN2J A8E7xHY3v+etHb3wuHN7TTtMj+2eYyTVgMZKCroMnFp4fjDAASaJA7KmRQyywna9Th SjN7nJVIHIXo0yw8kJpokSjZ8TZ5PJhUxVSGb2npJgw+s2QUMi76Dnl8HOAlYwJCmN sMSRy2i21vx7j6fZRR/Y0wYYJUQ/Rn2I4YvhRGJKzhSXPpjDwox2zH/xyDKhNOHuT9 4sc0fuNRtOxY+0TEX/K+9kdte1IIJW9HdTRsApmy7GXHKlBsKEfralncwWg01DsSKU TRp6aMIAOvueg== Date: Fri, 2 Jun 2023 14:40:27 +0200 From: Christian Brauner To: Alexander Mikhalitsyn Cc: xiubli@redhat.com, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Ilya Dryomov , Jeff Layton , Alexander Viro , Seth Forshee , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put Message-ID: <20230602-lernprogramm-destillation-2438cc92fee3@brauner> References: <20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com> <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 05:33:03PM +0200, Alexander Mikhalitsyn wrote: > These helpers are required to support idmapped mounts in the Cephfs. > > Signed-off-by: Alexander Mikhalitsyn > --- It's fine by me to export them. The explicit contract is that _nothing and absolutely nothing_ outside of core VFS code can directly peak into struct mnt_idmap internals. That's the only invariant we care about.o Reviewed-by: Christian Brauner