Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230602073300.7536-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20230602073300.7536-1-jiasheng@iscas.ac.cn>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 2 Jun 2023 16:02:47 +0300
Message-ID: <CAHp75Vdfvt-jxesWOgki+wV0QdVLidSVc6J+Fcm6dU4pxZYfPg@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: ath79: Add missing check for platform_get_irq
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     albeu@free.fr, linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 2, 2023 at 10:33=E2=80=AFAM Jiasheng Jiang <jiasheng@iscas.ac.c=
n> wrote:
>
> Add the missing check for platform_get_irq and return error code
> if it fails.

The template for function references is func().
Otherwise looks fine to me
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Return "girq->parents[0]" instead of "-ENODEV".
> ---
>  drivers/gpio/gpio-ath79.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index aa0a954b8392..31ce2d5c6ba0 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -286,6 +286,8 @@ static int ath79_gpio_probe(struct platform_device *p=
dev)
>                 if (!girq->parents)
>                         return -ENOMEM;
>                 girq->parents[0] =3D platform_get_irq(pdev, 0);
> +               if (girq->parents[0] < 0)
> +                       return girq->parents[0];
>                 girq->default_type =3D IRQ_TYPE_NONE;
>                 girq->handler =3D handle_simple_irq;
>         }
> --
> 2.25.1
>


--=20
With Best Regards,
Andy Shevchenko