Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230601201844.3739926-1-hugo@hugovil.com> <20230601201844.3739926-6-hugo@hugovil.com>
 <ZHkN5kEa6yqHdDeL@surfacebook> <20230601204140.3b45c9b97efb36431d058ba7@hugovil.com>
 <20230601212514.28914aee77ae9a513904ee6b@hugovil.com>
In-Reply-To: <20230601212514.28914aee77ae9a513904ee6b@hugovil.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 2 Jun 2023 15:58:43 +0300
Message-ID: <CAHp75VcLNRQyeo4H-auDvk+CxZ0hz+2pysqP3bBgW-uZB_2vPw@mail.gmail.com>
Subject: Re: [PATCH v6 5/9] serial: sc16is7xx: fix regression with GPIO configuration
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        jirislaby@kernel.org, jringle@gridpoint.com,
        tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 2, 2023 at 4:25=E2=80=AFAM Hugo Villeneuve <hugo@hugovil.com> w=
rote:
> On Thu, 1 Jun 2023 20:41:40 -0400
> Hugo Villeneuve <hugo@hugovil.com> wrote:
> > On Fri, 2 Jun 2023 00:30:14 +0300
> > andy.shevchenko@gmail.com wrote:
> > > Thu, Jun 01, 2023 at 04:18:40PM -0400, Hugo Villeneuve kirjoitti:

...

> > > Maybe positive one?
> > >     if (mctrl_mask)
> > >             regmap_update_bits(...);
> >
> > I used negative to save on indentation, but it also fits by converting =
it to positive, so done.

I understand, but in this case it is slightly more weird to have
negative conditional and in either case return the value of the local
variable.

...

> Greg did not yet respond to my email about the proposed tags, but if the =
new order of the patches and the stable tags I added seems ok to you, I wil=
l resend V7. It will then probably easier for Greg to comment directly on V=
7 for the stable tags (Cc:).

They look fine to me, but Greg is the maintainer, he decides if it's
really okay or not.

--=20
With Best Regards,
Andy Shevchenko