Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com>
Date:   Fri, 2 Jun 2023 16:22:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3 0/1] gro: decrease size of CB
Content-Language: en-US
To:     Richard Gobert <richardbgobert@gmail.com>
References: <20230601160924.GA9194@debian>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <lixiaoyan@google.com>,
        <lucien.xin@gmail.com>, <alexanderduyck@fb.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230601160924.GA9194@debian>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnB1ekMxV2I2c25laWw2TTJJTjlQdENmUjJKdkhJTzlablBXeW81R2tEcWxz?=
 =?utf-8?B?cHVQVW85bHA1dzZIVmtTQWZzYWxUYTFIOHdLQm83UmlLeWg1RHdKdTJ6ZmVy?=
 =?utf-8?B?RFRNK1BsMitEVW15bndWK0lWM3V2VlpsbkJLVEtqeU9XNk9kV2c2d3NKZERF?=
 =?utf-8?B?Y2o4c2VLTUFFRTJkMnlROW1tRXlQaUcwajJiMmZ3WVMrTFdXQk9ET2lndzcv?=
 =?utf-8?B?TDhyNktMS1RVQ25sQUU2RmRkRURtR0RQdVdHVUE2NXBVUHN3YzdkT1pDbUZJ?=
 =?utf-8?B?RXVNYU93dm4yam4vckVkTlJYZE10VWxTTmt2VlJQVTZteno3N2xNcUNnRGFr?=
 =?utf-8?B?RkFjVmdmS3VCemN5WVlaNER5ZjRuc21ncElubkk1Nnh3Yk8yMVRNRDV1dnRE?=
 =?utf-8?B?dUg5WFBQbi9sWTdDNXRhcm54WkI4ZEZuRW9jNk9zR1RSRUUzUXRMaXdBeWE2?=
 =?utf-8?B?NzFseTU3dlBNU0lHbGprU2RMcFR1L0FhWWZxN25pdmg0L0RJYzFsSEtWWXR6?=
 =?utf-8?B?RHpONGNHdUlmaVJLL2hlb2w0T0MvRmd4dldGYTVuZzVnRU0wNEVGejhiTDNp?=
 =?utf-8?B?SVJMM2dRbW9uQUNFRGtiTitSMnNHYkw5b0pPbzVYRUJhdllHZy9JTmcrdEpS?=
 =?utf-8?B?bGJ3MGZranBOcURPZTM2SmxidzNqN3Rhc21ROTBQZkFVaHE0TzhiYm1mbFdj?=
 =?utf-8?B?Tm90K24rVjJ5Z3BaQThuNitMSmc3Sk41Z2d2Slk5VXlnV3hBZkpweGdwSlcz?=
 =?utf-8?B?VU1GbFZFNk1mN244Y3RpQjRISjM1TWtPMjRIRWxwbHFJS2czR2tvMjlVMzEx?=
 =?utf-8?B?TjRqckZ3QWRwV2JEYWdWUlZBTUhTSEhKS2I5eXNwOVJHV3p0MWNVVlpVSmJU?=
 =?utf-8?B?dW1Db2t2YlRPaFFMT0F4b00rQ2YvTWt3NzJPUldxazZRenltNEQ5ZkJPd3Fx?=
 =?utf-8?B?QmhxY2xxbXd1SXJlT051c2hvQmNMOVJ3YXAyMHNQZSt1MXVQaXo0alcvK3Fq?=
 =?utf-8?B?d0M5OGNPaE1ocEhSdUEyOXk1YVhWdW1RbkpHM3BSTjRPRkQ2UjJVQ0o3anVx?=
 =?utf-8?B?V0dwM1NoQWVBRjFEUVdtNXp0aHhSUytqREVVUTNBWHpyQTdvWnU1MVRJUlZE?=
 =?utf-8?B?NmR3ZE5vTGhHL2RoYW5PTDNxN3lqWmRmZDV3aE5reXhXZlZOaWRVbjI1bjBz?=
 =?utf-8?B?b3h5Qm93bTdIWWkvZWEzeHlvMUNBRVZOT2V4RzFudER4dE9HN0tFYUhaOTZ3?=
 =?utf-8?B?UytxU25obk5xUm8rS3dCVGVVQVdld3VFZElDSU5ib0t5YzhYZHRzZXQrNjhl?=
 =?utf-8?B?WmdWUUtkd2hvQjBFMGVNM0dZWEowd1JIbTlBQnMrOGxIWnorQ2laYU9iSkFk?=
 =?utf-8?B?M3h6dDVUQnFsb1ZDUVhhYW9tOE9reGNyaUs2VElyVk1LcWZZSm9VaFR3SDls?=
 =?utf-8?B?bzNrUWVha0JsRVc0R0RIWHhPNmJJR2NScFhTdkxOYlJ1UzJ5eDcvVWtZNHND?=
 =?utf-8?B?TldVNGpFbFFTRU5yVXNYT21oVkJUcGh1cDBEd2p5elNHZmlVSHovY0Q3d285?=
 =?utf-8?B?YjRLT3dPalVuTVpVWDF5a1laL3lNamlWY1ZBNkxOYit1OTFSRnZpNkNiakZE?=
 =?utf-8?B?YUtwRDFwc2p5bm8rVlEvVE1NNk96RVFaQkZWQXNJSzBZY3RMVEFvd3grc3Fw?=
 =?utf-8?B?S09xWFRaSmdKK2xiak9ka1IvM3B0MDQ5RmkyUER1bjVXYVN2S3lWNUdvMldK?=
 =?utf-8?B?VHRDSG1CeUh1L0xyRmE5U1J1VlFsNzZVMkNJYmIvOERvRUxCaWJHUjdRaUwr?=
 =?utf-8?B?V3pDc1ZDa0Z5eTFOYXhpVEwvbWRWNE1Ua05rUjN1UXQyTTFIdWdnNktZaXRH?=
 =?utf-8?B?QVBRN29YNFpDd2laMjFUYml3NEVyOWVXZGtUTGpmYTh3OEZ5RTdvNTlla3Bv?=
 =?utf-8?B?VHJqWFJTYUpqZVpZaG9kczE2SUIxNEFUQzZPTSt3K2FBdG5pRnJQb3E0c3FT?=
 =?utf-8?B?K2RBU0F4ODlxODN3TXROZ3ZoUTd4eG5aeCtQcTU5U1Nqc1hGR0NiNmd0V0Zz?=
 =?utf-8?B?TGFsMWVHTytmSSt6eUN1Uzg2YnJqdWJjcFVxejVZY3ZHVlpHQW9WaTVPWlBY?=
 =?utf-8?B?QTluY1N2dzJyRzBRZWd0N1FsYUpocXQ5SFBqTHlPQUNnODFtQ0Myam01REgv?=
 =?utf-8?B?RkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a07b393-9dc6-4886-b3b3-08db6374f435
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 14:23:37.0351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hT9J6v6gFhW9G7CfiPJzlrae+M9PN8o4mU+sA39kbqLKLbBfz7V70SccTTLZpijN47QPk5+RTxmvCKzPa4zu2lOg+0sNSBn0Aw4s6gGnVn0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7413
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Richard Gobert <richardbgobert@gmail.com>
Date: Thu, 1 Jun 2023 18:09:28 +0200

> This patch frees up space in the GRO CB, which is currently at its maximum
> size. This patch was submitted and reviewed previously in a patch series,
> but is now reposted as a standalone patch, as suggested by Paolo.
> (https://lore.kernel.org/netdev/889f2dc5e646992033e0d9b0951d5a42f1907e07.camel@redhat.com/)
> 
> Changelog:
> 
> v2 -> v3:
>   * add comment
> 
> v1 -> v2:
>   * remove inline keyword

I hope you've checked that there's no difference in object code with and
w/o `inline`? Sometimes the compilers do weird things and stop inlining
oneliners if they're used more than once. skb_gro_reset_offset() is
marked `inline` exactly due to that =\

> 
> Richard Gobert (1):
>   gro: decrease size of CB
> 
>  include/net/gro.h | 26 ++++++++++++++++----------
>  net/core/gro.c    | 19 ++++++++++++-------
>  2 files changed, 28 insertions(+), 17 deletions(-)
Thanks,
Olek