Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <53e9b63f-06da-ff0f-8776-0c5032d58aff@amd.com>
Date:   Fri, 2 Jun 2023 10:28:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] drm/amd/display: fix compilation error due to shifting
 negative value
Content-Language: en-US
To:     "GONG, Ruiqi" <gongruiqi@huaweicloud.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Pan Xinhui <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Xiu Jianfeng <xiujianfeng@huawei.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Wang Weiyang <wangweiyang2@huawei.com>,
        amd-gfx@lists.freedesktop.org, gongruiqi1@huawei.com
References: <20230602101233.1255276-1-gongruiqi@huaweicloud.com>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230602101233.1255276-1-gongruiqi@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTduZzJVOVVtM1N3eWk5bmk0QU1LdERFelQySlhSVUFPOHV1cGhQengydkZ5?=
 =?utf-8?B?ZVVsbWNKYWpZVnVBdnZ2K1J4NkxqcDdmdVFoN01SOCtpbWNWcU41QXZRVjlI?=
 =?utf-8?B?QVVMMmI0MG5GVHdzU0JDWVVDNmRUWVNySzdBcFhwU0ZsemxXdVhhSDljSTd3?=
 =?utf-8?B?T1VBU21rRGxEcVFQMzRpMnVSSzZQT244aUVSQ2pmaWxydXFDNWYrWEtPNnVW?=
 =?utf-8?B?a2EvWnBPbU1UY0VneUNzZEhGQlFIVmV4SHdNemVPcStHMFNSMDMxbkxoa21I?=
 =?utf-8?B?VXo4RzJ0cWFadUdZSkNTS0UxbElFTUJGWTRCNWo4VldsUW5kQ2dqeE5ySHZF?=
 =?utf-8?B?VU5xUm1Cc0d6alJqTEVVSWNlY3hpOExPOWpPdmVLRVJaRmlsN1JyemRwT1RE?=
 =?utf-8?B?MDhSNDVhZElVZ3hVc1BoakpRWm53RGNFOVVlbmJ4NjY3cm16UStXZFJiclgy?=
 =?utf-8?B?SWYrYzhZbnIxaDZKODBscXZqVUxyYTM1eFYzc0JjT0Fmc3NFdlI1ZnJYN3pS?=
 =?utf-8?B?SUNJcWtaL3crYkpMcGxXVmQ2eHo0SE0vRFYramJOWkhKdzRYbWVuSUcyUjho?=
 =?utf-8?B?Q2N2OFhrRmduUHZQWUM4RVg3T2FHdzl5L1NQTHRzVjBsWVMySm9jczU0bWNE?=
 =?utf-8?B?dXVIKzNnOU4rUW1CcG5UYXlkcEwyTFYyQ05BYkczSW9DZ1EvY2JkV1psbGMz?=
 =?utf-8?B?ZTlseWdlRzdBUGJOeGs3QmxZVjFXbGxYWHZ6NWRFWXBRdUM4ZnVmbTBYVGd6?=
 =?utf-8?B?UDJzc2hKMk5UVTNIRDEvTlZTeDZKcGxVMU9VZzRmSWlKNDI1VSs4bC9md1Bk?=
 =?utf-8?B?U25TQ1cwcjk2d3BvV3JRTlhYTTJ1SURGb3JlUTJ2MHFNV2lFZStCRGlkb1Zu?=
 =?utf-8?B?NXN3dWZtemowZFlKcys3b0VNZW5xV2s1OGNHQkFUR2s2ZTFyb0tzU1dwZnZk?=
 =?utf-8?B?RWk4YVdyQkJWYTgwKy9XZ3pWTk4xVVozNzBmdGs2T29ES09GWGpQV3BWeXJC?=
 =?utf-8?B?QUlUTmUxRE95d2lodjROVjBhQnFSM3dlVDdaUXdWeUxtNCtZV3ZTT3Rtcms3?=
 =?utf-8?B?VlpBaUNyWTVOdHVjYWZmL0VyV2JzeCt2Q3U1bDArVnZkZjNoclJPQVZkVlpo?=
 =?utf-8?B?TGw0elVJSGIybTViUEdWTWNrMVRZMlV4aFB1WEJoWGlUTzczMTVic0RpVmlB?=
 =?utf-8?B?MTRyeXU0RGhIZERWbE1iRElTS0pNeXNTcTFpOWZVTDExcGZmV0FOR3ZXZitp?=
 =?utf-8?B?RktiempTUFJZYzQyNm81YjIwajU5MHVJZ0o5WFFYN3BLYmZEUVVaS1I5UCt6?=
 =?utf-8?B?TzhoRWJYUnFhQ1NEaDZMUllTN01PQzhZVTZOY013YndJWmZWWFJVdjc5dWc2?=
 =?utf-8?B?ZitPUjh3bEdxek4xOTdOT0hPaVhETWtqNXFTdEdqb2FkY3JoeXcwOW5Meklv?=
 =?utf-8?B?TktQSmp1TmJKVTVndjVzVzI4WXlsS082TEtXMUwyUlZtUnFGMWhGQmFJNHBt?=
 =?utf-8?B?MW1mMnZ1Tmx6VWFBRUVPY3ZWOFdWa21YUDFOWUxtSXBkYXRWTFYwT3M1VmZm?=
 =?utf-8?B?enhLNlNvdGQyTEJ6T3NvZDJLQWFETXJLRDFCTTJyaTRUdjdrYi9FZm5UZk53?=
 =?utf-8?B?SytlVVZXMFl2Rjk4emhUbWUwc2UzMDN6Zm1Ba1NDcXFqUGVBT291anZEbUxr?=
 =?utf-8?B?azhMYXNnRjl5RXdiN1NaOVJSL3NNbC9CcnlSTUt6akxBZG1rU2RMUWlUTEZL?=
 =?utf-8?B?WnJHZDRWYUR1di90Z0RlSWZDUTF6akwzL052UGUyUG16Y3hzcnRGRUxlNDJI?=
 =?utf-8?B?ejJxbDE2aTg1RUlVRXJ5SEN0V2t3aGV2RTVJUzVCa09zbWFaajhvZ01nb0w1?=
 =?utf-8?B?Mzk3eEFyRjZJWVdoRG84VUxTUHZWU2xFUlEzSWQwQk1NWHFJcTR1c2ZpUEkv?=
 =?utf-8?B?czIzdDdURHhrTkRkWmtUM25WUmdVTWRQQXVnQ2l0dGtFNFJINzEwMlhlR08w?=
 =?utf-8?B?clN6NnpFRjVHUjhFSWxDN1ZjWlJYS0wrZHAvZlkvNVY3RUR6eGVtRnZ3UW5Q?=
 =?utf-8?B?SmFlQm9lK0FCOTlYbWxWTHdoY21pNlpzYkN6K0pDZHR6aGFITXBWY0piRlFU?=
 =?utf-8?Q?zByD717el8TL5hFAkDcEpFq3F?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03e75c3c-d5b6-404e-e480-08db6375aa3f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 14:28:42.3142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /RBRE9sKERD2RdFJtGkPjMtI0Ek7UrnH3pFy9e+nZ5n99a6hm3XoBY5O7Wa41XPDqz0FKD9xAc3kxx9UB7y3zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6584
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/2/23 06:12, GONG, Ruiqi wrote:
> Currently compiling linux-next with allmodconfig triggers the following
> error:
> 
> ./drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h: In function ‘dc_fixpt_truncate’:
> ./drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:528:22: error: left shift of negative value [-Werror=shift-negative-value]
>    528 |  arg.value &= (~0LL) << (FIXED31_32_BITS_PER_FRACTIONAL_PART - frac_bits);
>        |                      ^~
> 
> Use `unsigned long long` instead.
> 
> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/include/fixed31_32.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/include/fixed31_32.h b/drivers/gpu/drm/amd/display/include/fixed31_32.h
> index ece97ae0e826..d4cf7ead1d87 100644
> --- a/drivers/gpu/drm/amd/display/include/fixed31_32.h
> +++ b/drivers/gpu/drm/amd/display/include/fixed31_32.h
> @@ -525,7 +525,7 @@ static inline struct fixed31_32 dc_fixpt_truncate(struct fixed31_32 arg, unsigne
>   
>   	if (negative)
>   		arg.value = -arg.value;
> -	arg.value &= (~0LL) << (FIXED31_32_BITS_PER_FRACTIONAL_PART - frac_bits);
> +	arg.value &= (~0ULL) << (FIXED31_32_BITS_PER_FRACTIONAL_PART - frac_bits);
>   	if (negative)
>   		arg.value = -arg.value;
>   	return arg;
-- 
Hamza