Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13
Mime-Version: 1.0
Message-Id: <3dda4d38-ef79-403c-a233-a8cf774edfd2@app.fastmail.com>
In-Reply-To: <bec3684e-d9d1-d88b-846a-46a1fc481ffb@linux.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20230601200552.4396-1-mpearson-lenovo@squebb.ca>
 <20230601200552.4396-8-mpearson-lenovo@squebb.ca>
 <bec3684e-d9d1-d88b-846a-46a1fc481ffb@linux.intel.com>
Date:   Fri, 02 Jun 2023 10:58:21 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 8/8] platform/x86: think-lmi: Don't display unnecessary
 authentication settings
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 2, 2023, at 7:12 AM, Ilpo J=C3=A4rvinen wrote:
> On Thu, 1 Jun 2023, Mark Pearson wrote:
>
>> If Opcode support is available (which is the standard for all platfor=
ms
>> going forward) then there is no need to have the encoding and kbdlang
>> attributes visible.
>>=20
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>
> Thanks a lot, the patches look good now. One small thing for future: n=
ext=20
> time, try to arrange a series such that the patches with Fixes tags ar=
e=20
> the first patches, in here I think it's not a big deal since 2/8 doesn=
't=20
> seem to conflict with 3/8.
>
Ah - OK, thanks for the note, I didn't know that.

> For all patches 1-8:
>
> Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
>

Many thanks
Mark