Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Thompson <davthompson@nvidia.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Asmaa Mnebhi <asmaa@nvidia.com>,
        "mkl@pengutronix.de" <mkl@pengutronix.de>,
        Liming Sun <limings@nvidia.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mlxbf_gige: Add missing check for platform_get_irq
Thread-Topic: [PATCH] mlxbf_gige: Add missing check for platform_get_irq
Thread-Index: AQHZlFEGLh+roIfUHEuJJeLaBTGvMa93mzUA
Date:   Fri, 2 Jun 2023 14:56:49 +0000
Message-ID: <DM6PR12MB55342319E09EB4D03773C2C5C74EA@DM6PR12MB5534.namprd12.prod.outlook.com>
References: <20230601061908.1076-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20230601061908.1076-1-jiasheng@iscas.ac.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R1hLj62Is7xhC5qlkj9M7fIBV5VCV0KGNEDz4QJBZQQGeptsOrDsB+5emUj0?=
 =?us-ascii?Q?uG0e7+y3952XgxWM//2qyC2A7jCrH3UkvSrNJu0BNOH9QtIqyZJTGhE+dQRH?=
 =?us-ascii?Q?uiZJo+c9ll8WA/WAkgCU3Ugfz4t5s0gkm1QJJnkeQb5t9Jy9F3HPgI7bpaia?=
 =?us-ascii?Q?RupAUiWSLxrQHnzZW7QbQfH2srBb3CHAOGyhi/dQGu+pgaqQgroapYW5jQGR?=
 =?us-ascii?Q?Ko3JJUB20MmDa5hlEYKFmY1yKkEkS2gjgu+bF+55P/dgAgQPfMYMryAMUsnV?=
 =?us-ascii?Q?bZ2qt/iTRAkAIITWP1DlS+bMufW0CV1tcoEvA5IRGz1kD74l/efCaH0y6KU7?=
 =?us-ascii?Q?yNUbxIGqgNEYJckUvorPUb6+kA2QhZs7MZogmQsJOGlLUo0sHvmwLONY4U5S?=
 =?us-ascii?Q?75baOA658GiOr/N32JKWVS7Oe4RcsTs6h74xrEtFdp3EmM4S4UAQI8QIZX+q?=
 =?us-ascii?Q?Wv91VhhORcwVWczax3/yWNDiUlOFUxYEVTK96l3GJEDr/HvSbudh7zJvX/2F?=
 =?us-ascii?Q?cTapJPaCYCtS5DiLg9rRyGRrXYp23htN631DxKWXNe2z1ZFJclpQunZjwC83?=
 =?us-ascii?Q?72qs0OWSKbkYy5xafzuCvntvdzD3Mr6mKr35beSucK6rwKvpfYwhdwN7game?=
 =?us-ascii?Q?Ctr3Uiud/otnRujFhLw2DALFwLllrr9cD/Y4JVJok69yf+2AzbCN0a2veLrP?=
 =?us-ascii?Q?IgHN+6BLCXbQpUv3dqQwQJlqYoqDg6g39WfLYXLKjdGccF5o3MjMh9tfuv81?=
 =?us-ascii?Q?DowFGE5sjq1eeLxdF3i7zy0vBgxhtq8Ul04z9l1dxf0Lm/8Xf4oofjX1TSCK?=
 =?us-ascii?Q?78XQcQmJEBFYWQOSVaVuffCEXHl17S+dnF4HCBGN7BoxCBCrY0Y+hdxRxG8z?=
 =?us-ascii?Q?P/yk8OWzsLTNKmPPUofBIt+msXhIPnU3n9dFB3H2yJANbHjUYm70wh6le0gM?=
 =?us-ascii?Q?j9UANQA3x1UJ11bOye/pOleenjlzL4gIFJDdpNmdtvKy7gMMEcN5b9Qg6rk2?=
 =?us-ascii?Q?qfSm2FJEKiUexnRxL1Id6a+CEMSoVFoh7FnzhXcYSA0ta8o4j8H9mZy/7I9J?=
 =?us-ascii?Q?jOnUCKl85G4ick1WZdZRBFPwmZAz5aj5SRlqtxEFEBG/WebnxtcOZErdg7+R?=
 =?us-ascii?Q?/xQH+fXpnqU47Rba4PsEWOJTSnGzl8e99fmM+ey2jPLpX8hOOAsocSol6SBH?=
 =?us-ascii?Q?OShNehxqsUYBhPTiQ9qNwISAC4Jh2E371dZh022WJSz2uCr4jhBkVTNatNb6?=
 =?us-ascii?Q?Gsx3Kk2bKQ1eZ8DMT13iR59FtL63h1W73bjH7ngnUWYx/bQvHhfrvFT6Sj6+?=
 =?us-ascii?Q?/UV4pS4aKskzRUVbH0en0df5iBq/CFQTS2pFZPfqpPPHYJkfBHuddz2sjpHi?=
 =?us-ascii?Q?ydJAUN01RCpJvKFZnE2igoirKyQ00MdUbrX1YG5koSWSwQ6gEt7ry/uzjzUX?=
 =?us-ascii?Q?VYWfl9KM/NPj88MK1/9Ah7jqXV8rp1NQyntoRPS5k/6LKdPPoopM+A8toJ4/?=
 =?us-ascii?Q?jyD8LNn5R/KeVp/fRb4gXTmb49iCHsD8PTCgdx+g7xUmr6UlWrnPhzpf//Mv?=
 =?us-ascii?Q?VMNaj2FHtJLRMrS92MSiATaSBV8Wzve4bZdN+pBMnkjm63iyA87Rj4pcW5TU?=
 =?us-ascii?Q?XU2pG5DyaRgqC5o7+NXmDz7agKwOVzDBQdesftWnfJdS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB5534.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ebc441d-8760-44ef-6dee-08db63799832
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 14:56:49.8197
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TGdR1KCmT2+kAdULQ3HeUHUo8cR5DTXSDfQSEABEss/irzWq1Wp/rT/qSNStDPFbiC0IRiiatNMVYHImjyGr/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6102
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Sent: Thursday, June 1, 2023 2:19 AM
> To: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; David Thompson <davthompson@nvidia.com>; Asmaa
> Mnebhi <asmaa@nvidia.com>; mkl@pengutronix.de; Liming Sun
> <limings@nvidia.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jiasheng Jiang
> <jiasheng@iscas.ac.cn>
> Subject: [PATCH] mlxbf_gige: Add missing check for platform_get_irq
>=20
> Add the check for the return value of the platform_get_irq and return err=
or if it
> fails.
>=20
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> index 694de9513b9f..a38e1c68874f 100644
> --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> @@ -427,6 +427,10 @@ static int mlxbf_gige_probe(struct platform_device
> *pdev)
>  	priv->error_irq =3D platform_get_irq(pdev,
> MLXBF_GIGE_ERROR_INTR_IDX);
>  	priv->rx_irq =3D platform_get_irq(pdev,
> MLXBF_GIGE_RECEIVE_PKT_INTR_IDX);
>  	priv->llu_plu_irq =3D platform_get_irq(pdev,
> MLXBF_GIGE_LLU_PLU_INTR_IDX);
> +	if (priv->error_irq < 0 || priv->rx_irq < 0 || priv->llu_plu_irq < 0) {
> +		err =3D -ENODEV;
> +		goto out;
> +	}
>=20

It is preferred to maintain the error code from "platform_get_irq" and retu=
rn
that instead of -ENODEV.  Please review the API for "platform_get_irq" :

/**
 * platform_get_irq - get an IRQ for a device
 * @dev: platform device
 * @num: IRQ number index
 *
 * Gets an IRQ for a platform device and prints an error message if finding=
 the
 * IRQ fails. Device drivers should check the return value for errors so as=
 to
 * not pass a negative integer value to the request_irq() APIs.
 *
 * For example::
 *
 *              int irq =3D platform_get_irq(pdev, 0);
 *              if (irq < 0)
 *                      return irq;
 *
 * Return: non-zero IRQ number on success, negative error number on failure=
.
 */

So, the code could look something like this, for each of 3 IRQs:
=09
	priv->error_irq =3D platform_get_irq(...)
	if (priv->error_irq < 0) {
		err =3D priv->error_irq;
		goto out;
	}

Just a thought.

Thanks,
- Dave

>  	phy_irq =3D acpi_dev_gpio_irq_get_by(ACPI_COMPANION(&pdev->dev),
> "phy-gpios", 0);
>  	if (phy_irq < 0) {
> --
> 2.25.1