Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Fri, 2 Jun 2023 17:27:05 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        David Gow <davidgow@google.com>,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] drivers: base: Add tests showing devm handling
 inconsistencies
Message-ID: <aix7tdvpegbkfe3okbrxu6phk7gnzfttrkmomocwofi5kkoaqz@25oaumodlg7j>
References: <20230329-kunit-devm-inconsistencies-test-v1-0-c33127048375@cerno.tech>
 <wiej2vps6uhozcpxeye3xfgpnlvxcbaek73px36f4jsef3e77p@ewcsmzrxzhsi>
 <2023053137-leggings-grumbly-a33a@gregkh>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4a5e5qpdgsdrrqyo"
Content-Disposition: inline
In-Reply-To: <2023053137-leggings-grumbly-a33a@gregkh>
Precedence: bulk


--4a5e5qpdgsdrrqyo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 31, 2023 at 08:20:13PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Apr 17, 2023 at 06:12:26PM +0200, Maxime Ripard wrote:
> > Hi,
> >=20
> > On Wed, Mar 29, 2023 at 08:38:30PM +0100, Maxime Ripard wrote:
> > > Hi,
> > >=20
> > > This follows the discussion here:
> > > https://lore.kernel.org/linux-kselftest/20230324123157.bbwvfq4gsxnlnf=
wb@houat/
> > >=20
> > > This shows a couple of inconsistencies with regard to how device-mana=
ged
> > > resources are cleaned up. Basically, devm resources will only be clea=
ned up
> > > if the device is attached to a bus and bound to a driver. Failing any=
 of
> > > these cases, a call to device_unregister will not end up in the devm
> > > resources being released.
> > >=20
> > > We had to work around it in DRM to provide helpers to create a device=
 for
> > > kunit tests, but the current discussion around creating similar, gene=
ric,
> > > helpers for kunit resumed interest in fixing this.
> > >=20
> > > This can be tested using the command:
> > > ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/base/test/
> > >=20
> > > Let me know what you think,
> > > Maxime
> > >=20
> > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> >=20
> > Is there any news on this?
>=20
> Can you resend, last I saw the kernel test robot had a problem, which
> causes any patch series like that to be ignored by me.

Yeah, this was due to .kunitconfig being ignored by .gitignore, which
triggers a warning for the bot.

It's now fixed (at least in next), and I just resent the patches

Thanks!
Maxime

--4a5e5qpdgsdrrqyo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZHoKSQAKCRDj7w1vZxhR
xXI0AP92qZlvkY6tZTf/o96Lk7z7mgalTkrKk3lDwB+Y2+jYnAEA/uqb5/rYKIDu
y4MSGyib4QSms9nvdN7YIC53SV364wQ=
=m7wS
-----END PGP SIGNATURE-----

--4a5e5qpdgsdrrqyo--