Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2391086rwd; Fri, 2 Jun 2023 08:47:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5MJ6YrZ5Inke7bwQaGUv1TLvPD+i5ub2UwQ/xQdkNv9XfBbmBHtpbw0dLirS++AdSxo0Qn X-Received: by 2002:a05:6a21:2d0c:b0:10c:67c9:2fdc with SMTP id tw12-20020a056a212d0c00b0010c67c92fdcmr11622400pzb.48.1685720841593; Fri, 02 Jun 2023 08:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685720841; cv=none; d=google.com; s=arc-20160816; b=bFuZVtqxm4i5fVO00NNQk+WWCDP/+JVBifWGOevABj9VKMdXZJSQ3VT+oSHEdY2kQU LK0acjDuzgKnNlVcRGG5WIYTt95yTSIHISiE44V+EA8PYiqgbp9d8+hNpQu1SrWTyaSN na//Sku2SwJHPtAnNM3eN2OJNkyOwFWWnmjO23tm2c7dgpAYfqOEOxzntewVGKMUQU96 /dkrObVpw24JdKEG9s6oE6IbUTh+gz7YTQUTYfhsmsojpKczCrU3Bp5i7hdAXiuHdvrZ dDcrb/lSQofD795G/wtXnHhfO8tWgZUrMIyUpRV+kVWY4Wq6fNoSdPkOvMKlbkoG5p53 BwAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KP2LwxKY0P5BgJoIDGzxP6Ti8Vrkl5ZL8kcFLhdizVw=; b=SgpjNurzB9b8tP3MppW6Cbsr2P36wStdGkkMru3j9fQixHEG9Ewp2/gheBi5HpCJpk i5GcqvKkOkyzv8jEi5VxVPXyfkh1z31wXPXyhPSJlJpR1p3fEusecybrQ1r0EyBmAEi6 ujlq20hD7bPMqJw+PKlfbkLPWwqVNQuk0xOr3UGwrJc7il643XBaOJgkih61AZ048x5V gwqolsz68K0ZiI8Tg7GyoAaS2dRn1qSYIOLC71UejaR8HCz5Q+Y1qv3MSYq7PHfDy+x7 Z2HpHvoOkBRu6KB5eUaDsv9d/v4WgtV9PkclvorC9bgG3D3Hi6pJKhCSR6wkM9gepwQN Ao5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a4LjYWTp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r25-20020a638f59000000b0052c6e736ad1si1220413pgn.61.2023.06.02.08.46.46; Fri, 02 Jun 2023 08:47:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a4LjYWTp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236585AbjFBPcp (ORCPT + 99 others); Fri, 2 Jun 2023 11:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235747AbjFBPcn (ORCPT ); Fri, 2 Jun 2023 11:32:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005ED18C for ; Fri, 2 Jun 2023 08:32:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 847D064D44 for ; Fri, 2 Jun 2023 15:32:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0CDC433D2; Fri, 2 Jun 2023 15:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685719961; bh=SVkGyzyW8nD/mzC5YVIz+vKUiiAkmDQMqMj4UnkMOvY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a4LjYWTpbyhaOCA2bjWfV6TKsAgOy0MeWkpXwXMgRqQrO2fOpIwDxkpGCod6ev4ca 4exLVAQJyOMXp3tiGzfhhJSoawY9lZ7CjmtbafYeUSEgx8zMoe+5cO8WLK7Ld1+U7Q B78Ybw4fArsHemqOhqq/BsAK0D1ZxmWYIek99Kjpv6Ub5LWPtmgP6Kj4SvPdGYoP/5 z8sPMznaMNgOnEiietpuLDNEH+Z/KkQjUj/swTZ8CRoi1YRNSq9ZdVCzqHO8tLSMPR M+s9niZ/npdhaRbYZD+/6nk5+6OugCI/TRittqnyBK+2HgnC6DQkz7rhn8C66EWYMB mxs+26vWyM5ww== Date: Fri, 2 Jun 2023 08:32:39 -0700 From: Josh Poimboeuf To: Peter Zijlstra Cc: Zack Rusin , linux-kernel@vger.kernel.org, Miroslav Benes , x86@kernel.org, VMware Graphics Reviewers , kernel test robot Subject: Re: [PATCH] drm/vmwgfx: Silence RBP clobber warnings Message-ID: <20230602153239.fsug6rgvoxgnrea6@treble> References: <20230602151639.GK620383@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230602151639.GK620383@hirez.programming.kicks-ass.net> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 02, 2023 at 05:16:39PM +0200, Peter Zijlstra wrote: > On Fri, Jun 02, 2023 at 07:56:34AM -0700, Josh Poimboeuf wrote: > > VMware hypercalls take the RBP register as input. This breaks basic > > frame pointer convention, as RBP should never be clobbered. > > > > So frame pointer unwinding is broken for the instructions surrounding > > the hypercall with the clobbered RBP. There's nothing that can be done > > about that. Just tell objtool to ignore it. > > > > That's a pretty horrific ABI, one that violates the oldest x86 calling > convention in existence. > > VMware folks, shame!! Agreed :-( BTW, please ignore the patch, I'll be sending a v2. I realized (with Peter's prodding on IRC) that reliable ORC unwinding would be broken if the function has a frame pointer. Which can happen if the function needs an aligned stack. -- Josh