Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Jun 2023 09:12:16 -0700
In-Reply-To: <20230602030842.279262-1-gongruiqi@huaweicloud.com>
Mime-Version: 1.0
References: <20230602030842.279262-1-gongruiqi@huaweicloud.com>
Message-ID: <ZHoUyDMJ8xq7ENnX@google.com>
Subject: Re: [PATCH] bpf: cleanup unused function declaration
From:   Stanislav Fomichev <sdf@google.com>
To:     gongruiqi@huaweicloud.com
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Wang Weiyang <wangweiyang2@huawei.com>,
        Xiu Jianfeng <xiujianfeng@huawei.com>, gongruiqi1@huawei.com
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On 06/02, GONG, Ruiqi wrote:
> All usage and the definition of `bpf_prog_free_linfo()` has been removed
> in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> jited_linfo"). Clean up its declaration in the header file.
> 
> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>

Acked-by: Stanislav Fomichev <sdf@google.com>

> ---
>  include/linux/filter.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index bbce89937fde..f69114083ec7 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
>  
>  bool bpf_opcode_in_insntable(u8 code);
>  
> -void bpf_prog_free_linfo(struct bpf_prog *prog);
>  void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
>  			       const u32 *insn_to_jit_off);
>  int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> -- 
> 2.25.1
>