Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <ZHO4/Z+iO+lqV4rW@work> <202305301608.2982BD3CAF@keescook>
In-Reply-To: <202305301608.2982BD3CAF@keescook>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 2 Jun 2023 14:27:27 -0400
Message-ID: <CADnq5_O6fzoCOo5YEAEv=D8ComZaYShx5ot=TQBmdFf8ReEKrg@mail.gmail.com>
Subject: Re: [PATCH][next] drm/amdgpu/discovery: Replace fake flex-arrays with
 flexible-array members
To:     Kees Cook <keescook@chromium.org>
Cc:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, May 30, 2023 at 7:08=E2=80=AFPM Kees Cook <keescook@chromium.org> w=
rote:
>
> On Sun, May 28, 2023 at 02:26:37PM -0600, Gustavo A. R. Silva wrote:
> > Zero-length and one-element arrays are deprecated, and we are moving
> > towards adopting C99 flexible-array members, instead.
> >
> > Use the DECLARE_FLEX_ARRAY() helper macro to transform zero-length
> > arrays in a union into flexible-array members. And replace a one-elemen=
t
> > array with a C99 flexible-array member.
> >
> > Address the following warnings found with GCC-13 and
> > -fstrict-flex-arrays=3D3 enabled:
> > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1009:89: warning: array s=
ubscript kk is outside array bounds of =E2=80=98uint32_t[0]=E2=80=99 {aka =
=E2=80=98unsigned int[]=E2=80=99} [-Warray-bounds=3D]
> > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1007:94: warning: array s=
ubscript kk is outside array bounds of =E2=80=98uint64_t[0]=E2=80=99 {aka =
=E2=80=98long long unsigned int[]=E2=80=99} [-Warray-bounds=3D]
> > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1310:94: warning: array s=
ubscript k is outside array bounds of =E2=80=98uint64_t[0]=E2=80=99 {aka =
=E2=80=98long long unsigned int[]=E2=80=99} [-Warray-bounds=3D]
> > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1309:57: warning: array s=
ubscript k is outside array bounds of =E2=80=98uint32_t[0]=E2=80=99 {aka =
=E2=80=98unsigned int[]=E2=80=99} [-Warray-bounds=3D]
> >
> > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> > routines on memcpy() and help us make progress towards globally
> > enabling -fstrict-flex-arrays=3D3 [1].
> >
> > This results in no differences in binary output.
> >
> > Link: https://github.com/KSPP/linux/issues/21
> > Link: https://github.com/KSPP/linux/issues/193
> > Link: https://github.com/KSPP/linux/issues/300
> > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.htm=
l [1]
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> --
> Kees Cook