Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@meta.com>
To:     Song Liu <songliubraving@meta.com>
CC:     Song Liu <song@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Kernel Team <kernel-team@meta.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v4] watchdog: Allow nmi watchdog to use "ref-cycles" event
Thread-Topic: [PATCH v4] watchdog: Allow nmi watchdog to use "ref-cycles"
 event
Thread-Index: AQHZiR9WEaR3xoFFfEGCLaxGjWAWL69h1CkAgAnH6YCADJAYAA==
Date:   Fri, 2 Jun 2023 22:11:51 +0000
Message-ID: <393545F8-AB12-47F6-9293-75B2274CF7B2@fb.com>
References: <20230518002555.1114189-1-song@kernel.org>
 <3BDFDE24-C5B6-47A0-A541-2BF833BBA832@fb.com>
 <5F882BF2-6B6A-4809-B0D5-9EF430E11C2F@fb.com>
In-Reply-To: <5F882BF2-6B6A-4809-B0D5-9EF430E11C2F@fb.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3G8oqlv6wHfWdkXM9xdBpS/hqU/KCLuIQC8deND9v6jYKt1mg2ken4SsKM5U?=
 =?us-ascii?Q?3sFC8ODOYC4cacgJhQMY303mMPbbRqVf0S5LZnlnouykLGj4Q+Dufon9ZE0J?=
 =?us-ascii?Q?L4cumiqFwMcxk6JIvJJMMdWK1WAggy0tk5Y4kw/vpDHuymskqfPMtLHgnrGx?=
 =?us-ascii?Q?e47Gxm3KhxHdJL4Ffcq+FwU9uVZ6sbGN7ChkLPwk6FMpOJSP8wIvmFSSknvR?=
 =?us-ascii?Q?iR5FOznHBAfxLYZYTYrL5pNlFWCgYRX8xsbwZdP4dNsk9SOMOEHqluF40/8W?=
 =?us-ascii?Q?rYt1D5Og+jn26V8CU5QZV1WCXZuG/WsYLIB1+dD956ej0LdKbiqwfomjlxeI?=
 =?us-ascii?Q?LTlkIDs2ypcKLzLKSOir4M3KTcD7fZhUwF35cbOAaQOCwQ7j8eW34fkW7wE0?=
 =?us-ascii?Q?FZtTCNX/jO97usraHR5YqeEGhXDZ8gayqpwygSS9YUMFnKyy50OodYQpc3GQ?=
 =?us-ascii?Q?IeBI4suHrDwVdh7hqMp5OWILUv03HCu4YLOXzJIXqOM2isaOXD16Z0bg1LZP?=
 =?us-ascii?Q?Ik4EBKWVtT/M+bUZLgM8O3W/PoreR60MVkAPqC5QJZWNrah7kTqvIW6rQISF?=
 =?us-ascii?Q?MjJ2RweiclZ+E5eNS0JlziztAqUlP7l9eEtqYO24R/b6wfNGVmfkmQ47FAvV?=
 =?us-ascii?Q?1DtKnAFhHopt9xWfg5OJWT/TvExnvuzRu09VGUQRvHeuXhS9JbFSJg4b+20D?=
 =?us-ascii?Q?xwr4tBdY6tBG7clXcQ0aGgD4XYVM+rb4jTaxFikjQJPviupeoWUe1mrYJ5YT?=
 =?us-ascii?Q?WP/kmnZje3ijLaMn8bAwXuzgz0wGR7LMGrMWXZAhZZ9eYvUy8kYwb9OfUqk+?=
 =?us-ascii?Q?yQ/lfCt0VWRX9PN3uhti3u2Ra3h0Ff45TOClKJYVGdUcV4LZU13fSeD1XXdg?=
 =?us-ascii?Q?UFPcpe2ZAKZ8Maypn2GSzvYG3TSw1Bak/n13lGv20c+ybxJzQ7O8W4XII26R?=
 =?us-ascii?Q?NytqBhiOGyPr1f6jmTAhcRQMc4d1Pp7xRMYSk87zekr10f8kZmb7sM2IxddK?=
 =?us-ascii?Q?dxe2ZOlM5PelEK+YJb8y1sYCiA3Q4Bjaw6/yJQJu731C0aMXs74l0htsK0Tv?=
 =?us-ascii?Q?RYicO2bjMJwCMAawcH4TCEKochYS2epMdEPzQs8ep1Cz7Gx+ERVRNjggn3e2?=
 =?us-ascii?Q?OoVnjkwvl5Op/0K49ZyhjdY3gZmXp5ffPLHQUdZ1VeBzxLY8ARDm4NyWibOJ?=
 =?us-ascii?Q?JmXm13aRgeIAyVQhJskhzfxVI9QrlQe28p5d/tOcM8Veqf8snbT45L3dx948?=
 =?us-ascii?Q?8p6DkiBhchASalH6/kmFTbN+ZYYJ2t44aZrah+nDJ9UcTP5e2D9GvcArwcsX?=
 =?us-ascii?Q?sw5g1chPJrLS8ih2vWLWKq5ActsSaqVZom7KgF3CD+PkiKKOd8v/b5MhDcSj?=
 =?us-ascii?Q?+IJuP8LRYXDUE3AeS8rQf1KmMlViyTmmFACjgorSXqumJLtYDNB6EEK+x9im?=
 =?us-ascii?Q?9LtTUlNXsyMu4q9ewblJU8d1GBQ4YLBYhUMM4eTOe0f57QFkZOH9sDUsueWJ?=
 =?us-ascii?Q?LcJ5NVlr7gyNH0X0Vg6ySXSrLvkaO75du6uKrxNmlMi7B2uDc6xfurDi9SMB?=
 =?us-ascii?Q?AYcjJumlb7dfZoUMdUY2HhZ08NybmfRD5hLmpMGySRHCrXC+4guMRwMf/be2?=
 =?us-ascii?Q?XNGlsUkIhi7KGvqZglLo3+e38DDTGOxJmlv2eQT2uTvl?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DE841E3720E3454495FF53AE31BF894C@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd48da9a-25d4-4c73-2cb3-08db63b65e20
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 22:11:51.7372
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N7Ef2LlwCk86dkviLKjPYbUhzdfi1FciqVQ3xMOwpDBfgEnP+QvD7qoSABdvFMBdqEs1sS0wj0hzLyLiIPZuuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB4881
X-Proofpoint-GUID: P3vVF4kmcPF-beE4W8hb6jK4AgKsvtqQ
X-Proofpoint-ORIG-GUID: P3vVF4kmcPF-beE4W8hb6jK4AgKsvtqQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-02_16,2023-06-02_02,2023-05-22_02
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew and Peter, 

Friendly ping... Any comment on this one? 

Thanks,
Song

> On May 25, 2023, at 3:20 PM, Song Liu <songliubraving@meta.com> wrote:
> 
> Hi Andrew and Peter,
> 
> 
>> On May 19, 2023, at 9:59 AM, Song Liu <songliubraving@meta.com> wrote:
>> 
>> Hi Andrew and Peter, 
>> 
>> Does this version look good do you?
>> 
>> Thanks,
>> Song
>> 
>>> On May 17, 2023, at 5:25 PM, Song Liu <song@kernel.org> wrote:
>>> 
>>> NMI watchdog permanently consumes one hardware counters per CPU on the
>>> system. For systems that use many hardware counters, this causes more
>>> aggressive time multiplexing of perf events.
>>> 
>>> OTOH, some CPUs (mostly Intel) support "ref-cycles" event, which is rarely
>>> used. Add kernel cmdline arg nmi_watchdog=ref-cycles to configure the
>>> watchdog to use "ref-cycles" event instead of "cycles".
>>> 
>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>> Cc: Peter Zijlstra <peterz@infradead.org>
>>> Signed-off-by: Song Liu <song@kernel.org>
> 
> Could you please share your comments on this patch?
> 
> Thanks,
> Song