Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAG8fp8Te=oT1JJhTpOZvgWJrgcTq2DXan8UOVZ=KYCYNa8cKog@mail.gmail.com>
 <CAMj1kXG0q-pJEnvqJxxpecVqJcB2jk3rj7S4KNp728THM=de3Q@mail.gmail.com>
 <CAG8fp8Tnfb5tt3Eea4+=zznZLxBfqwha_wkQcPDvU4QhcSckEw@mail.gmail.com> <CAG8fp8QbQqDVxEvzeyijbkfU5HoAwbRH0VptMK4-oPnJ7-0Ljg@mail.gmail.com>
In-Reply-To: <CAG8fp8QbQqDVxEvzeyijbkfU5HoAwbRH0VptMK4-oPnJ7-0Ljg@mail.gmail.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Sat, 3 Jun 2023 00:52:33 +0200
Message-ID: <CAMj1kXHAt69QqFdZDOTFKNLvAYuY9cwrVFgE+eDNZ8FSQA-45w@mail.gmail.com>
Subject: Re: [PATCH] efi: bump efistub version from 1.1 to 3.0 for
 VZLinuxBootLoader compatibility
To:     Akihiro Suda <suda.kyoto@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-efi@vger.kernel.org, Linux x86 <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 2 Jun 2023 at 22:30, Akihiro Suda <suda.kyoto@gmail.com> wrote:
>
> > > I'll queue this as a fix, but I'm going to tweak the comment (and the
> > > commit log) a bit, if you don't mind
>
> Thank you for rewriting my comments, but the new comments seem
> slightly incorrect:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=36e4fc57fc1619f462e669e939209c45763bc8f5
>
> > efi: Bump stub image version for macOS HVF compatibility
>
> The commit is about Virtualization.framework, not about
> Hypervisor.framework (HVF).
>
> Virtualization.framework = high-level VMM, similar to QEMU
> (/usr/bin/qemu-system-*)
> Hypervisor.framework     = low-level  VMM, similar to kvm.ko
>
> > The macOS hypervisor framework includes a host-side VMM called VZLinuxBootLoader
>
> VZLinuxBootLoader is a part of Virtualization.framework, not
> Hypervisor.framework.
> Also, VZLinuxBootLoader is not a VMM; it is just an API for loading
> vmlinuz into Virtualization.framework.
> (similar to the `-kernel` and the `-initrd` flags of QEMU)
>

Apologies for these mistakes. Unfortunately, this patch has been
merged now so there is nothing we can do about it.

> > On x86, it incorporates a BIOS style loader that does not implement or expose EFI to the loaded kernel.
>
> AFAICS, it does not seem to use real mode BIOS.
>

I never mentioned real mode, did I?