Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2861733rwd; Fri, 2 Jun 2023 16:15:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6IFSuSZbuzqlnexrKNI9N53w2enkkjds/Ejl1fFhdFVeDpU3BaBw1dovZYFkfwG0pJscdl X-Received: by 2002:a05:6a20:4415:b0:100:3964:6cb with SMTP id ce21-20020a056a20441500b00100396406cbmr16522555pzb.40.1685747741386; Fri, 02 Jun 2023 16:15:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685747741; cv=none; d=google.com; s=arc-20160816; b=puIhA6tjurTGfGePCm6Fm9rLxpj2U6kz5GUf4WzcJ+MRhKeOXkcZjzn8VRZKiPTd17 EIAN+YAWmS+g2FzSTGvn5P72vbyWT6BNhBHBCDhyeZO1to5qfQLTxSxvJdNyQdac3qos K8YQBxZcxHC8N1+GFwsSSpMRVYqOBx/yftwlfg4qRoS/DOX5Xy6GfmpW658KtGU3R9RZ IaLc2NJrV9XNZREwlMTbV1WY3Mladq7oISWEayegCbnFH5HpiK7QYr9id6hEqlbk6HQP ZGssPh91x9vsNuO08gKStWR8grzJBuJlvRsKEi6BP3gvyvWw/3uA6bbuS3pEJm/W8cEp jnew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LwIToiVgzi6wCdIjwjcb3L/GvJpdQgBVPSWA+oF1rjY=; b=DlB+Dx4h0fx4dTHsR1Psqx5xgJ0BDgEiclgfrBXd+vqBcc/xQbniV6RHlv8w29Lg6Z 5lpVVlVhf8q0zYuacXDKBXKYNIjrPV2DEuKFOpnO45sQaIuJDRHd7Q8JZ2GAEww41ICC C3WGzMylewBKeDZmQjZVYKNzlPkdAemtWT6PQI8NDWvsiUVxIeTiHbLDShh4WYF+Y2ik PVMrKKtNoB+Fl2DZby2e5g6QpxByaXD58O880R+oDdz99ZJnS2dP+v30+4+fqPcyK/Dw kkGAcPXc8U/Zf2k2XK0augSrBoDaIzkhI6YyvkvDfp1UPn5UMW0llw+nR/qJoY9GlbtR e1qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oB0OrsCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i6-20020a625406000000b0064d3e1db254si1373737pfb.347.2023.06.02.16.15.26; Fri, 02 Jun 2023 16:15:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oB0OrsCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236424AbjFBXCT (ORCPT + 99 others); Fri, 2 Jun 2023 19:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236190AbjFBXCS (ORCPT ); Fri, 2 Jun 2023 19:02:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7AB818D for ; Fri, 2 Jun 2023 16:02:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C3F561F55 for ; Fri, 2 Jun 2023 23:02:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06931C433EF; Fri, 2 Jun 2023 23:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685746936; bh=fYigfzOcxFRHWwMscO3wkkw2DhR7y12cBw39ZlnS/xc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oB0OrsCFyKp9cVcnqvB62uPXOvyifqR2n6b6yPImGYflokBzsNLq47jhgqq/T+qej J3PdMOqW9QCUXk/R+JYml5trXX3bbbWANTwNXP+0vjQYFaCnp7rV984jHc/lSfNfG7 1cbuhm7dSrZUBH7aa4MhVNZntmDheES4zdwqVYkqLBSmNCFeZ+8IsveCNykKouJoYO uthIHns3ldgqEGKkHGssBw2qT/5xzisxuDvh72+Ch4D0LEORzs12efIZE6znLaR1FJ IA4DUKPc8ITCSXeGU+1nMW+ms8wdNq/5pqNIj06CThXT+y9slnNH85y5/2sHDTBv75 Qp1I6bb1x22DQ== Date: Fri, 2 Jun 2023 16:02:14 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , Eric Dumazet , "pabeni@redhat.com" , Evgeniy Polyakov , Christian Brauner , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements Message-ID: <20230602160214.292749c9@kernel.org> In-Reply-To: References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com> <20230331235528.1106675-6-anjali.k.kulkarni@oracle.com> <20230601092533.05270ab1@kernel.org> <20230601094827.60bd8db1@kernel.org> <20230601101514.775c631a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Jun 2023 22:23:01 +0000 Anjali Kulkarni wrote: > > Not much, really. I think the requirement is to exit with a non-zero > > return code on failure, which you already do. 0 means success; 1 means > > failure; 2 means skip, IIRC. > > > > The main work in your case would be that the selftest needs to do its > > checking and exit, so the stimuli must be triggered automatically. > > (You can use a bash script to drive the events.) > > Thanks! So this will be part of the kselftest infra right? > https://docs.kernel.org/dev-tools/kselftest.html ? Yes, that's right.