Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
Cc:     Matthew Wilcox <willy@infradead.org>,
        Ackerley Tng <ackerleytng@google.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>, vannapurve@google.com,
        erdemaktas@google.com, Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH 1/1] page cache: fix page_cache_next/prev_miss off by one
Date:   Fri,  2 Jun 2023 15:57:47 -0700
Message-Id: <20230602225747.103865-2-mike.kravetz@oracle.com>
In-Reply-To: <20230602225747.103865-1-mike.kravetz@oracle.com>
References: <20230602225747.103865-1-mike.kravetz@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8RrIQJig+8nQ+FsEd0UBTTVf9dxD5ZzicEpVocn3sLu9ZpdO3F8EkOh7e5UJ?=
 =?us-ascii?Q?R/PnVuUAOkhwH1d1o+462DCUKM7BT1jYPFi2T2Zjpmdseq1zx27MJxebi+Vp?=
 =?us-ascii?Q?ZVVnbtjyoUZToacIY5jk0QFgtwNOja7SPDHW7u2yyywA0tYBRYdoxu/HM4Pd?=
 =?us-ascii?Q?zaw39gl6ABFMvuFVuAnXZpdL/28gI04yj8fKjDdBpfZTAKYOrRRUKzFN2wnC?=
 =?us-ascii?Q?glQIXnK767g0VU/hcA/SDehcDKdOHYCO5KbTxs5k8l5/mxec3N+vVV+j0jYr?=
 =?us-ascii?Q?Utm4WjlPsFQP7NKZ0n83jD0hxbP+jlmxDRIAqmOobdtOPe9L0yVnKHbebN+c?=
 =?us-ascii?Q?iDO1aUKF0fMAmSlR90sd2Te20nZyvZid8Wn5D2gmt4GKZG69Gz+pPv5vVcWc?=
 =?us-ascii?Q?7aCe6gYz09KCaEecnyNoye9WRZ77WLSgKq783/uUyEkgeHcFGlf6+ph7a5DB?=
 =?us-ascii?Q?CrJJfRP/crgc6lhk97zC9Y3Cx2Cgy4VqucutY62BBVTF4DeQvjYl+UfgDsv4?=
 =?us-ascii?Q?ItnDfb+nHtFmpZviJr3d2OBUutVQuI24GfiIsrFXaDsxrQR1qLbpdE0Y5d9I?=
 =?us-ascii?Q?/i823cw3Jp/9ZccYhcL8L4ik85kk2gwclauDwOrLi1BQi3Stsc/N4rw9WxMW?=
 =?us-ascii?Q?FXpCmDY/UXHFXAYG7fYJlCrJr3+3ZMP25MBUWk7J/ZVzk2V07EqIzyg35VF3?=
 =?us-ascii?Q?5kj6IYREu/NdoszxrGHKb96enMqZCvMjOlY8TNBatWZSIIABGTQ/2TqI9iiu?=
 =?us-ascii?Q?YIv0oDY2XiMlqBv++XPFTsmsbT5pJtRhET6iiOOEiQUMwk67II2oJ5pxpkbg?=
 =?us-ascii?Q?nqaxw2Etobn9SGOzlJ8mmOqlvfBXeBCvZH5qD0nMhZy8su9idvxkl7jsuZqn?=
 =?us-ascii?Q?d4XyhhM6qkZkVVtzOJk4NuCXyMANJr2v9olMW9yUikJjQNHUr4QQcaPyLrMK?=
 =?us-ascii?Q?Wjw6fwqE+vOiQFTOpJ1IEuQ/15Xfe7YKysDfkeOW2tZ4S3EuZGUJMdqxWwSg?=
 =?us-ascii?Q?amkeW2EUtxm8pK3936PQO8aZr/3J6+nlA+YakTeiIwQZ7cUOEQWNXFfoW9gq?=
 =?us-ascii?Q?osEcsjnEeE4cfOLOGFzH0DOMW+fxbr0iJsIkc7Um8wGea4OmYlbX/MTN9YMO?=
 =?us-ascii?Q?0cDyUDGeqv3ezI87zvW0845wK8W2oCCyOLqc0vEG6BlPkabMC3lBwTZWrUqW?=
 =?us-ascii?Q?3/e73xUCz5xpFqoQkU3WzJF9puyPUzqdVnzHy7QxRIcsxy8o+th7OVEuVO0X?=
 =?us-ascii?Q?cwv0iT++ewlBiLqEn8n2LxtkTw8gllqvWMDH3p2f5WrYHEqGRmKMv8DuD5dx?=
 =?us-ascii?Q?8YCR7J94P0F+82yHdb1UDhi+m5E1IYYflpPPAWS5p0wpKF3lu9MmumWpLwWk?=
 =?us-ascii?Q?MPexpNBHfd2Ypkh35LvXe05s1sF5jHhgiJ3lNNQ4H0L/WLKLPGQOLd2Ko1MB?=
 =?us-ascii?Q?gZ3NU6Putw7p2+7kc2k/39QmrowhA6IzK2Wj7VVxP+ZOTW0Ay7onzag4Xm3v?=
 =?us-ascii?Q?QQZ0cbagcxlhqPjoBM32f2VYxSnC4J+cjl66QI3CJxDmCuRFqbH+WaghCpzF?=
 =?us-ascii?Q?CIqvsfMzCjucmrNdwKgKelWt4LZ5NGs2P6mGkuf8UY0UOh7j40772eK4Z7EC?=
 =?us-ascii?Q?Bw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?n9WBZ+lS/sBg63e8wTzw1ZZqxn1z4ntdzf0GS4e8ERNm1NdBIWzaO4J8V1ZZ?=
 =?us-ascii?Q?MgZsUiAl0WGSgzJ16P5UFPcRPoYhy2hFhZ6WPfXhg3Fh3VjfpkKgOsKDuEB9?=
 =?us-ascii?Q?Q+Kd08AClGLiNTdKWc1kJlMQmN9bLaTyGgfJRZN2GAx1h16B3ui6UYF+PplP?=
 =?us-ascii?Q?vbwBKq3TqjQQboIplENr+0WN9Nfo+wB0x0gWeV8OJ8f7cXfYBaU9pIiXdOhJ?=
 =?us-ascii?Q?rNa9ayvieaZhnVjZA8d+ur/ifttuou4CmOJEJDi3Gu7VL4MpaQVlkFh9XeWY?=
 =?us-ascii?Q?nFn81UWNf18si2zkAPjm4XFGkq4xeljPrj3N7X8t6W9m+oQkoFzhRREODa1d?=
 =?us-ascii?Q?YReC58STdpF4F/NBJ2Vh73Gg8aJmM9E96ajFe8A4YnHOhFPfHm5weENdSlJL?=
 =?us-ascii?Q?InVyq1IQPDFi00acQYgDJKRmFOlVDlevDUCp6mGMygBxse0IgppVi+JT+8YO?=
 =?us-ascii?Q?O3GgVPuCtZbB6DwzoVpvGamHqZBhpo04YbGgBDPfZcCK3iOYoXCnqrxUb8xx?=
 =?us-ascii?Q?vX+/EhCORj8WKbfee+ATp0FVX0OEoSKzVsQocMetTWvlH93XvplQ3pztHAOJ?=
 =?us-ascii?Q?qOentZ0XEvbI8rwsFaPVGfNijkH5mBZMGsiO43cAfgh80cPUk/lpIC6K2I/S?=
 =?us-ascii?Q?x7MP7a7XvtXMh82DDNyaXKhIoebCAvuHb470Ph48E8G2tPnwJ7vKwJ3ByIUz?=
 =?us-ascii?Q?CFEvw/DeFn+x0zRuh/gO+FxyGk/Ts6G3Bl9zW4NzhzhOQrKiXpNHXW4sJRmK?=
 =?us-ascii?Q?1qXXunBPDtvCNbbOkwEb/kDxTQ+tmkggnHA05aztytDuKZRl+l75Q0lgh7ko?=
 =?us-ascii?Q?IeSknIdPhT4lKDvxzj/tooLbl8k1pYuFcKdmDAXppkoDB/O0vuSV4yffWL0Y?=
 =?us-ascii?Q?E2ChMGGVazxhR+UR4s+C2U6P6eL75SZuUVhCBiALsekeIshfaeyTVMMFZH/w?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f10cd4d8-36a0-405c-591e-08db63bccdb9
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 22:57:56.1045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H5Q/3ofeT6U82SbO/v8U4r7cHpC1xf/226v5A7vE0hfTFB5hIZ2JOL/2E5DnRBDEL2Z0PSe0O837NE47g61hlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6519
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-02_16,2023-06-02_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2306020181
X-Proofpoint-GUID: -lqIgs5IfhyMUgG4BmkCOZm1ml9_72Gf
X-Proofpoint-ORIG-GUID: -lqIgs5IfhyMUgG4BmkCOZm1ml9_72Gf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ackerley Tng reported an issue with hugetlbfs fallocate here[1].  The
issue showed up after the conversion of hugetlb page cache lookup code
to use page_cache_next_miss.  Code in hugetlb fallocate, userfaultfd
and GUP is now using page_cache_next_miss to determine if a page is
present the page cache.  The following statement is used.

	present = page_cache_next_miss(mapping, index, 1) != index;

There are two issues with page_cache_next_miss when used in this way.
1) If the passed value for index is equal to the 'wrap-around' value,
   the same index will always be returned.  This wrap-around value is 0,
   so 0 will be returned even if page is present at index 0.
2) If there is no gap in the range passed, the last index in the range
   will be returned.  When passed a range of 1 as above, the passed
   index value will be returned even if the page is present.
The end result is the statement above will NEVER indicate a page is
present in the cache, even if it is.

As noted by Ackerley in [1], users can see this by hugetlb fallocate
incorrectly returning EEXIST if pages are already present in the file.
In addition, hugetlb pages will not be included in core dumps if they
need to be brought in via GUP.  userfaultfd UFFDIO_COPY also uses this
code and will not notice pages already present in the cache.  It may try
to allocate a new page and potentially return ENOMEM as opposed to
EEXIST.

Both page_cache_next_miss and page_cache_prev_miss have similar issues.
Fix by:
- Check for index equal to 'wrap-around' value and do not exit early.
- If no gap is found in range, return index outside range.
- Update function description to say 'wrap-around' value could be
  returned if passed as index.

[1] https://lore.kernel.org/linux-mm/cover.1683069252.git.ackerleytng@google.com/

Reported-by: Ackerley Tng <ackerleytng@google.com>
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 mm/filemap.c | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 71dc90f64e43..123540c7ba45 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1733,7 +1733,9 @@ bool __folio_lock_or_retry(struct folio *folio, struct mm_struct *mm,
  *
  * Return: The index of the gap if found, otherwise an index outside the
  * range specified (in which case 'return - index >= max_scan' will be true).
- * In the rare case of index wrap-around, 0 will be returned.
+ * In the rare case of index wrap-around, 0 will be returned.  0 will also
+ * be returned if index == 0 and there is a gap at the index.  We can not
+ * wrap-around if passed index == 0.
  */
 pgoff_t page_cache_next_miss(struct address_space *mapping,
 			     pgoff_t index, unsigned long max_scan)
@@ -1743,12 +1745,13 @@ pgoff_t page_cache_next_miss(struct address_space *mapping,
 	while (max_scan--) {
 		void *entry = xas_next(&xas);
 		if (!entry || xa_is_value(entry))
-			break;
-		if (xas.xa_index == 0)
-			break;
+			return xas.xa_index;
+		if (xas.xa_index == 0 && index != 0)
+			return xas.xa_index;
 	}
 
-	return xas.xa_index;
+	/* No gaps in range and no wrap-around, return index beyond range */
+	return xas.xa_index + 1;
 }
 EXPORT_SYMBOL(page_cache_next_miss);
 
@@ -1769,7 +1772,9 @@ EXPORT_SYMBOL(page_cache_next_miss);
  *
  * Return: The index of the gap if found, otherwise an index outside the
  * range specified (in which case 'index - return >= max_scan' will be true).
- * In the rare case of wrap-around, ULONG_MAX will be returned.
+ * In the rare case of wrap-around, ULONG_MAX will be returned.  ULONG_MAX
+ * will also be returned if index == ULONG_MAX and there is a gap at the
+ * index.  We can not wrap-around if passed index == ULONG_MAX.
  */
 pgoff_t page_cache_prev_miss(struct address_space *mapping,
 			     pgoff_t index, unsigned long max_scan)
@@ -1779,12 +1784,13 @@ pgoff_t page_cache_prev_miss(struct address_space *mapping,
 	while (max_scan--) {
 		void *entry = xas_prev(&xas);
 		if (!entry || xa_is_value(entry))
-			break;
-		if (xas.xa_index == ULONG_MAX)
-			break;
+			return xas.xa_index;
+		if (xas.xa_index == ULONG_MAX && index != ULONG_MAX)
+			return xas.xa_index;
 	}
 
-	return xas.xa_index;
+	/* No gaps in range and no wrap-around, return index beyond range */
+	return xas.xa_index - 1;
 }
 EXPORT_SYMBOL(page_cache_prev_miss);
 
-- 
2.40.1