Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Michal Smulski <michal.smulski@ooma.com>
To:     =?iso-8859-1?Q?Marek_Beh=FAn?= <kabel@kernel.org>
CC:     "andrew@lunn.ch" <andrew@lunn.ch>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "olteanv@gmail.com" <olteanv@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "simon.horman@corigine.com" <simon.horman@corigine.com>
Subject: RE: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII
 mode for mv88e6393x
Thread-Topic: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII
 mode for mv88e6393x
Thread-Index: AQHZlOeZhHXye15LEk+eN0zupHuzTK93JOuAgAFZuWA=
Date:   Sat, 3 Jun 2023 04:32:09 +0000
Message-ID: <BYAPR14MB2918BDA8AAEC5413A0CD523EE34FA@BYAPR14MB2918.namprd14.prod.outlook.com>
References: <20230602001705.2747-1-msmulski2@gmail.com>
        <20230602001705.2747-2-msmulski2@gmail.com> <20230602095349.2ab53919@dellmb>
In-Reply-To: <20230602095349.2ab53919@dellmb>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Ntq16Z8UPpXGexrqssy5ScyTVpZOgaDr1RhjddfGcPp42mW8Sui1vYWHIl?=
 =?iso-8859-1?Q?ko83uamME+IuuLAmA+bU8PfU+XvMoSkR/MZvfDzbmxAJ28CDlwbouwUwla?=
 =?iso-8859-1?Q?FBOOzCxojSxeCq8T8CQOK2ISjujzNXSdvgCfmZc6JGe6QvGLwLi5bfDWuN?=
 =?iso-8859-1?Q?0ZPeWrBENxTlIxnrIPacSFDSDUTZbjYYJCN2YLR1yYhJuEFg8n+PN7R/5/?=
 =?iso-8859-1?Q?MVrNm3C9D5FPVRvgvQZXQHKTYOsV9GGKIFyT3LMdvOfmQnKOQqsbt6+gSB?=
 =?iso-8859-1?Q?u0qYtXZJGDt0fyZdNw6mN9GPrx7g1EAXmS5LHcPbEU4RKTKoDlvk8d2+2s?=
 =?iso-8859-1?Q?XCES0pg7apT2ZtwLbeBakcNc47rl3iAHhGK5Gb8OHAMLnmxT4gM9l5ffSx?=
 =?iso-8859-1?Q?f0Nt/Ms6EyTeAeev0F/EbZdC4hW8aPuxo/8AlSVf0LfzSYuOFjCzHWuFem?=
 =?iso-8859-1?Q?c1cz2B++uf7DZpLVWTpKUU01D3smnZvNH1AZcFOZAHTUXM8NwrUiWTIMrU?=
 =?iso-8859-1?Q?KC693DDvkRvkFWFc8xyV2W/fEshmpJveLLZMTwl+qL3JD6EAzacOKCmGqI?=
 =?iso-8859-1?Q?x5nczEWygEFK49H2Q2RsGI/Y8WxLqBA8+gXa+YzSaCzeM13RKA5LzOnq3A?=
 =?iso-8859-1?Q?jWRoLEzxXI9fA94ulFD9bAuNdkvbgOknOpt6A4VDLY+RDOvjt4qL15PGWn?=
 =?iso-8859-1?Q?aNohdw2BYQEnBUleDLJZoPaRuVZUPRe3AL+XQPNKa1SY6NcAX8F6k5a8F9?=
 =?iso-8859-1?Q?RgNPtTO+BBfG0UjyvoJ7Gv0y1AimUbdEaSjFQUT+3dfvN3Uv5XC2WORTlF?=
 =?iso-8859-1?Q?j5cOZdmb4VHiWOHcOf/qavCqh3oay2K3wfh7kcxOUJgt3dUEM7OIYWdw1a?=
 =?iso-8859-1?Q?SHb5gcxaBR9R2FAWupfXrDuI3HDlfHvE5g97tnHMp96d2j2hZ37lpxWMVk?=
 =?iso-8859-1?Q?7QVpSmMLEXoI+OgwGYRrmEnSsN8uXrdkjtEyJQaWH0P6TUkDWExLxhyNsT?=
 =?iso-8859-1?Q?xmqOLuJkCIvnowGjKzIIIS3jhKr1N/P4ntv9YHWmOpqIhcptTSUA4M0KED?=
 =?iso-8859-1?Q?fyhRbH5hvdkPCOpGyW2crY3JEgmrw/CK6wKfpT77gQ65OOXcBtQx/O5bhL?=
 =?iso-8859-1?Q?fGKdD0d6gPPR0vGSpnKmqL7zR+5A8CMMNc/jKXMKUpKjGefss8pjHsV2/I?=
 =?iso-8859-1?Q?JpgMxAj67USHqhjGYutHgPmGJDOp+4NqapJ7mRhzG6cmt/ogQYUuZ+HvjG?=
 =?iso-8859-1?Q?6N9ZkSM/+OTtqJT//0hzPgEiXztpOKDk4vNwNoikkmUfRE3b9eKfp+l1zT?=
 =?iso-8859-1?Q?fbu0jfR1AQ0dZQltjE2ZlA6uu1f0WlasbX6+9wpilmGxFMtSozBWJJIHaS?=
 =?iso-8859-1?Q?0E8dekqzs06H5R9b34HpTcP/DCCj3BIukXk3aN3yKZ2WgNoJjRjjIgWQqI?=
 =?iso-8859-1?Q?wTprw6IaUyvJBsXR7vWp4O0eqCgSlBvO51GG9rROIJgSr30D85lLeOhV5n?=
 =?iso-8859-1?Q?7jABBnI28kcYlzxVwDgmmeMjTZVKjQnDj77ss0MPwswLUyJvenFlRKSPGC?=
 =?iso-8859-1?Q?iH4XZ/XO6QfSRBVKKbXkU9JkgoCDDZ0U4e2ynVNllftIYOmY4Ndsanpgez?=
 =?iso-8859-1?Q?6DFiEURx+qWtJiOD4AGifQGziDTcn6ky/0?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: ooma.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR14MB2918.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85c8aaaf-7a81-422a-f67b-08db63eb7e5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2023 04:32:09.1075
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2d44ad66-e31e-435e-aaf4-fc407c81e93b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TqRQiYcwmDtjoI9j6VYomyISRiUtNLwrkueOdCPENdIiVc9pytXAYCDFlWtXzRVHvOZyv3ds0ZE1wETtA/0+Iw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR14MB5865
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thank you for the review. I will make the change on the next version of thi=
s patch.
Michal

-----Original Message-----
From: Marek Beh=FAn <kabel@kernel.org>=20
Sent: Friday, June 2, 2023 12:54 AM
To: msmulski2@gmail.com
Cc: andrew@lunn.ch; f.fainelli@gmail.com; olteanv@gmail.com; davem@davemlof=
t.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; linux@armli=
nux.org.uk; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; simon.hor=
man@corigine.com; Michal Smulski <michal.smulski@ooma.com>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII=
 mode for mv88e6393x

CAUTION: This email is originated from outside of the organization. Do not =
click links or open attachments unless you recognize the sender and know th=
e content is safe.


On Thu,  1 Jun 2023 17:17:04 -0700
msmulski2@gmail.com wrote:

>                               config->mac_capabilities |=3D MAC_5000FD |
>                                       MAC_10000FD;
>                       }
> -                     /* FIXME: USXGMII is not supported yet */
> -                     /* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported)=
; */
> +                     __set_bit(PHY_INTERFACE_MODE_USXGMII,=20
> + supported);
>               }
>       }

The set_bit() should go into the if statement above, since 6361 does not su=
pport usxgmii:

 /* 6361 only supports up to 2500BaseX */  if (!is_6361) {
        __set_bit(PHY_INTERFACE_MODE_5GBASER, supported);
        __set_bit(PHY_INTERFACE_MODE_10GBASER, supported);
+       __set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
        config->mac_capabilities |=3D MAC_5000FD |
                MAC_10000FD;
 }
-/* FIXME: USXGMII is not supported yet */
-/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */


Marek