Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Sat, 3 Jun 2023 16:46:28 +0300
To:     Astrid Rost <astrid.rost@axis.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@axis.com,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: [PATCH v5 4/7] iio: light: vcnl4000: add illuminance irq
 vcnl4040/4200
Message-ID: <ZHtENLuHKixK884F@surfacebook>
References: <20230530142405.1679146-1-astrid.rost@axis.com>
 <20230530142405.1679146-5-astrid.rost@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230530142405.1679146-5-astrid.rost@axis.com>
Precedence: bulk

Tue, May 30, 2023 at 04:24:02PM +0200, Astrid Rost kirjoitti:
> Add support to configure ambient light sensor interrupts and threshold
> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
> will be pushed to the event interface.

...

> -	int ret;
> +	int ret = -EINVAL;

What is the purpose of this change?

...

> -	int ret;
> +	int ret = -EINVAL;

Ditto.


...

>  	int ret;
>  	struct vcnl4000_data *data = iio_priv(indio_dev);
> +	switch (chan->type) {

Had you run checkpatch.pl? A definition block and a code should be delimited
by a blank line.

...

> -	int ret;
> +	int ret = -EINVAL;

Purpose?

...

> -	val = state ? (ret | mask) : (ret & ~mask);
> +		val = state ? (ret | mask) : (ret & ~mask);

I'm wondering if you can prepere the code by introducing switch-case instead of
current implementation in the preparatory patch and then do what you want to do
here. It will show much better the change and make review easier.

-- 
With Best Regards,
Andy Shevchenko