Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3566475rwd; Sat, 3 Jun 2023 07:36:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Ac2P9uJfXalNgtZqjnTrlJo6qZbTxc6/1KJMHs+q2kbgalBYGOgTTQMIxMQ/ak2L05VgF X-Received: by 2002:a05:6a20:938a:b0:107:35ed:28b5 with SMTP id x10-20020a056a20938a00b0010735ed28b5mr2468399pzh.2.1685803005208; Sat, 03 Jun 2023 07:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685803005; cv=none; d=google.com; s=arc-20160816; b=fIBy3cgbBJ0bLOn0omsb75GSHm1lUFoXBdfFMvIk5VQc1Ppe9yUUkThdwhjpGjhlFW yTJwjKGjtqww4tIBgvpQ7B8k9auHp+1eQdl81lJMhIkhkqx1VONko8+2Z9znq64omEy8 ZrgTOVQBThf/VB0XWKceyBUrNgC5IukC8cL5ajdpEWkYoP5bVEmp9EeBQooGK4hyepe0 0BmKKQZtxSP2dlHT1byMt7O0XmiHaSTu0D64R9Y2wFlPsNBnFkmV+iUrWYVVxVGIoeZ7 TomTt8weKyCLFPKpWL5Nud3nh9fEqyNwtCa416PSJnhsfdqNyEMZ8wTgQGCGhb1UTFOu wKBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:date:from; bh=6jPOBT+ghmq2giYYego3M7dmbzjP0vvibkILrAaZbv8=; b=LQysOYMT0NgxEJLXoPPHsDGAyE8cKpReLr9JbR8Bs2fULjHxpGo+jpImWlaE3W3LpA tMudxC5pwXOxfgUsnOYX5Sa4Ja5oGNKuwjuGkeu9GtjbGidSnw25F7P5vLH8utzhGTqd lgFfZu3UCdjP65MSkSRyddlraHXl15Bo+tES4m4DKQiM3Hxh+Mq9zyW1QLL9ObPriC1M ThKzmqfzDjBBwBYfNZ9NXoLYmwbm53UEOJVRjt1iFNKZZ4HL1i5RbLPPy4V5spsajiLj fsJG8HKlO9/P4Ff16NLhlJyGbP/Jf7FdjFxDUt497TcyfH/wr0ro0RNjLsT1i9WHfrnr +cXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y25-20020a637d19000000b0054104fb57besi2014936pgc.449.2023.06.03.07.36.14; Sat, 03 Jun 2023 07:36:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbjFCNvL (ORCPT + 99 others); Sat, 3 Jun 2023 09:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjFCNvI (ORCPT ); Sat, 3 Jun 2023 09:51:08 -0400 Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B81D123 for ; Sat, 3 Jun 2023 06:51:05 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id adf7629f-0215-11ee-b972-005056bdfda7; Sat, 03 Jun 2023 16:51:03 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Sat, 3 Jun 2023 16:51:03 +0300 To: Astrid Rost Cc: Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mathieu Othacehe Subject: Re: [PATCH v5 5/7] iio: light: vcnl4000: Add period for vcnl4040/4200 Message-ID: References: <20230530142405.1679146-1-astrid.rost@axis.com> <20230530142405.1679146-6-astrid.rost@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530142405.1679146-6-astrid.rost@axis.com> X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,SPF_HELO_NONE, SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, May 30, 2023 at 04:24:03PM +0200, Astrid Rost kirjoitti: > Add read/write attribute for proximity and illuminance period. The > period is set in the interrupt persistence flags(PS_PERS and ALS_PERS). > An interrupt will not be asserted if the raw value is not over (or lower) > than the threshold for the set continued amount of measurements. > The time in seconds is calculated by the number of continued refreshes > multiplied with the integration time. > It will always pick the next lower possible value. The period changes, > if the integration time is changed. ... > +static ssize_t vcnl4040_read_als_period(struct vcnl4000_data *data, int *val, int *val2) > +{ > + int ret, ret_pers, ret_it; > + int64_t val_c; > + > + ret = i2c_smbus_read_word_data(data->client, VCNL4200_AL_CONF); > + if (ret < 0) > + return ret; > + ret_pers = FIELD_GET(VCNL4040_ALS_CONF_PERS, ret); > + Redundant blank line. > + if (ret_pers >= ARRAY_SIZE(vcnl4040_als_persistence)) > + return -EINVAL; > + > + ret_it = FIELD_GET(VCNL4040_ALS_CONF_IT, ret); > + Ditto. > + if (ret_it >= data->chip_spec->num_als_it_times) > + return -EINVAL; Also name them better, at least by dropping ret prefix. > + val_c = mul_u32_u32((*data->chip_spec->als_it_times)[ret_it][1], > + vcnl4040_als_persistence[ret_pers]); > + *val = div_u64_rem(val_c, MICRO, val2); > + > + return IIO_VAL_INT_PLUS_MICRO; > +} ... > +static ssize_t vcnl4040_write_als_period(struct vcnl4000_data *data, int val, int val2) > +{ > + unsigned int index; > + int ret, ret_it; Name variable better. > + u16 regval; > + int64_t val_n = mul_u32_u32(val, MICRO) + val2; It is inconsistent to use uXX and intXX_t in the same module. Can you explain the intention? > + > + ret = i2c_smbus_read_word_data(data->client, VCNL4200_AL_CONF); > + if (ret < 0) > + return ret; > + > + ret_it = FIELD_GET(VCNL4040_ALS_CONF_IT, ret); > + Redundant blank line. > + if (ret_it >= data->chip_spec->num_als_it_times) > + return -EINVAL; > + > + for (index = 0; index < ARRAY_SIZE(vcnl4040_als_persistence) - 1; index++) In one case you use i, here index. Please, be consistent with your code. > + if (val_n < mul_u32_u32(vcnl4040_als_persistence[index], > + (*data->chip_spec->als_it_times)[ret_it][1])) > + break; It would be better to have for (...) { ... } > + mutex_lock(&data->vcnl4000_lock); > + > + ret = i2c_smbus_read_word_data(data->client, VCNL4200_AL_CONF); > + if (ret < 0) > + goto out_unlock; > + > + regval = (ret & ~VCNL4040_ALS_CONF_PERS) | > + FIELD_PREP(VCNL4040_ALS_CONF_PERS, index); > + ret = i2c_smbus_write_word_data(data->client, VCNL4200_AL_CONF, > + regval); > + > +out_unlock: > + mutex_unlock(&data->vcnl4000_lock); > + return ret; > +} ... All the same to the other functions applies. I stopped here. -- With Best Regards, Andy Shevchenko