Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <12c60b4a-6c1b-ce99-6828-8ab3854bb415@siemens.com>
Date:   Sat, 3 Jun 2023 18:41:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 10/12] arm64: dts: ti: k3-am65-iot*: Fixup reference to
 phandles array
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Udit Kumar <u-kumar1@ti.com>
References: <20230601152636.858553-1-nm@ti.com>
 <20230601152636.858553-11-nm@ti.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <20230601152636.858553-11-nm@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGZrNnRaa2pCMFlqbGh3U0hoU01EOGxTYVp1SUFvS1BPTmRKWURXdGtVcFNn?=
 =?utf-8?B?RjFDQllSU3paUEl2eEQ5U2xvSW1mRVNaZlZZME40bmVDZEQrd0hJYXF1YmFD?=
 =?utf-8?B?UDhVRGwvRytuVm93RVJobE5NNlphOHVia3JiVkVvNzB6akROT3NRQkM4b01I?=
 =?utf-8?B?aDZDSUloa25wcVI4UEpXWHZ5RThZUG85VlBRV2pmSUh6OEFEeHRiMEZZbWg1?=
 =?utf-8?B?MWh2UlB3YjExUTJiS2ZPV1V4SG92ME0yczNVQUs3Q21udzV2R3lJelFhbHV0?=
 =?utf-8?B?cWdFcWJacU9kREFFcFRjOGNvaGJEYXJuenR5dUZ1WmlFTVZXQ09kRjdsbXJh?=
 =?utf-8?B?b1hMYjlpd0xiVE9sOXpmd3hOYndoYWFyWW9TV2p1cHA2M2xhL3pEYWFuNEZZ?=
 =?utf-8?B?S1hRS1JuRnp0UENjSFFlM29QUDhoeGl2TWVxaElxRTQ4VnhCenpGUWRxQ3Yy?=
 =?utf-8?B?UmJ0amxFMnQrSzA3K3JLRXNzK2wyRlRxdzByUGZVMzdtaDExZFE5VDg1bHRw?=
 =?utf-8?B?QXU1cGEvaFp1eFIyYkU2ZkMzLys0VzN5SmNIM3kwbkdlYXBqWlFLZEI4UHlM?=
 =?utf-8?B?TytmRkExSU5tT2liU2FCTXR5Zk1zZ1haYkNpekZYSFFxOEJPcS9CVC9JV29i?=
 =?utf-8?B?Nmw1V1BQSUpxcjlDVzV1NjRuRmtPcFNIaTlxSklmbUdzTVppclZzT2FXMUlw?=
 =?utf-8?B?TWJ2TmZiNWh0ZkZoUjZjZmRqN1VQR3cvK2JBN0FpOUhQdFkvM2UzT2ZNaEs3?=
 =?utf-8?B?ZnJJeTR6YXhaandFY2hVVjVNM2lmK08xZWloZEdIVnRUZGswVmdIMVhnQVBp?=
 =?utf-8?B?aFdoR1ZXZWcyOU8vK2FOVFA0R09qWDRBNVBZT1kzaTQ4R2NMTyt0NFdiMTZU?=
 =?utf-8?B?WjFQbTNmRGE0djVvYmVhRGpxbHhHN2w0RzBObWF1K3MzU3o4RW1uOWRnL2FT?=
 =?utf-8?B?S3lMZUJlYTdhdTJrNndLaWhSeU5LcXljeC80SVcwZFFqVFN2M0l1RVlBYUhT?=
 =?utf-8?B?ZVoxWjZUcGNTRjlLeXVLMXpSeElqeEVwQ3hnNG80YzBJdzlEcmhWS3ZEUlg0?=
 =?utf-8?B?Wllxa0ZrYTVzdHN6YjE1N3hjaW4zZXVwNm5LQUxsa25xbk9XTjNwdmhZc3lG?=
 =?utf-8?B?YXh2VmhpenFYcmJMc3hNdUZ0aVgzdHk4TnY4VWJiempTTjdUUnlNNmxBSEtr?=
 =?utf-8?B?alp6L2krRDc4dTNKVUp3dEVSWDY2ZDVHYzBQSzQzaEkxV293cWJrMXVBaHcr?=
 =?utf-8?B?ai90MDNjZkRRa0tYRWhzcTNiRS9ieVlhaHBZRDUyelIvaW5kQ0RNUnExZnlh?=
 =?utf-8?B?NTJHTG44eEVEYXhUSFNJcGh4VWpCZGQyeDFlTmVUbXljbEZvbWNIclFqY0Jz?=
 =?utf-8?B?eno3NGQ3SUMzRDJSeDhyVWZiTDhaR0ZtdUlGV2I3eFpoQlJOaHB2aExObjFO?=
 =?utf-8?B?bHRNWlFLSkVJOUdFWnpSQXFzd2ZUMy9wMXZrU3BEWEIvazZiejJWaFdOSVJB?=
 =?utf-8?B?MTNGMlpQSzY1dyttMmV4cy9zalRVRkhydU8xQWV3T3YzZk1CWGxnNkZFVElX?=
 =?utf-8?B?REQ1ZWhiR3RlN2x2dXQwcmhwUUZVZzI4RENodlpVazNEcmFhWWRRalhMTUw1?=
 =?utf-8?B?Rzk3WGZnUU9sbG9OZGk0YUF2aXJLUTVCRXNXeFNkS0dCMGVUNzVkejI0a2dy?=
 =?utf-8?B?OGV5RngvVWM3T1VrUzRpdTZPZkhDRHpTZHBzVkVKTVIxd29uOTlQVkNGdlNF?=
 =?utf-8?B?MmYxSkUyQXhSeXl1Nzl1Mk5kMmNiK3YvS2M0TWdES01kVjU0RlhtMWF6bmhk?=
 =?utf-8?B?UFN2OXNnZ1d3dGhPSmduSmgvNjhMY2ZCMmVOWWJoMXVEd1dBQUpEbXB3Z3Ji?=
 =?utf-8?B?ejN0WWlmOWZ3V3BqdXIrTU5ZYmdnSVZ2VStDMmFqNmZ2NUhrT2x0VHlPRDZY?=
 =?utf-8?B?YmJtQ2pFa3JsWVhjV2I3bGpDNnR5SDJ0TDU0UUM5cDlIdFV4TmtLKzRFQzV3?=
 =?utf-8?B?QWJTaUJKYmYwSGdzOVBTWEVuY2pEcmxsMkFaU0FFUnMrS2RPQTRPejFlcWsr?=
 =?utf-8?B?ZUJsUWNwaWNNcVcyTitGQXVQbkl2Wk9wR3NyVFRpWDRremdtMlBseDFUVDlo?=
 =?utf-8?Q?oNhS1COrc05NbnKkqajWT37K/?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82999f08-5173-43bb-05fc-08db6451727e
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2023 16:41:58.1753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gqV4G8pHZkJo0yQjX6JBK2TmLp2bbNrpc6lU/97WIDbJkCh/9ITHEdTbbCoZ+sEFU7yqSGVPxh4J+0tW65Lz0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR10MB3821
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01.06.23 17:26, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
> 
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  .../boot/dts/ti/k3-am65-iot2050-common.dtsi    | 17 ++++++++---------
>  .../dts/ti/k3-am6548-iot2050-advanced-m2.dts   | 18 ++++++++----------
>  2 files changed, 16 insertions(+), 19 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index 6b052a0ecfa1..bbbb5c169ccc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -384,13 +384,12 @@ &main_gpio0 {
>  
>  &wkup_gpio0 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <
> -		&arduino_io_d2_to_d3_pins_default
> -		&arduino_i2c_aio_switch_pins_default
> -		&arduino_io_oe_pins_default
> -		&push_button_pins_default
> -		&db9_com_mode_pins_default
> -	>;
> +	pinctrl-0 =
> +		<&arduino_io_d2_to_d3_pins_default>,
> +		<&arduino_i2c_aio_switch_pins_default>,
> +		<&arduino_io_oe_pins_default>,
> +		<&push_button_pins_default>,
> +		<&db9_com_mode_pins_default>;
>  	gpio-line-names =
>  		/* 0..9 */
>  		"wkup_gpio0-base", "", "", "", "UART0-mode1", "UART0-mode0",
> @@ -711,11 +710,11 @@ mbox_mcu_r5fss0_core1: mbox-mcu-r5fss0-core1 {
>  &mcu_r5fss0_core0 {
>  	memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
>  			<&mcu_r5fss0_core0_memory_region>;
> -	mboxes = <&mailbox0_cluster0 &mbox_mcu_r5fss0_core0>;
> +	mboxes = <&mailbox0_cluster0>, <&mbox_mcu_r5fss0_core0>;
>  };
>  
>  &mcu_r5fss0_core1 {
>  	memory-region = <&mcu_r5fss0_core1_dma_memory_region>,
>  			<&mcu_r5fss0_core1_memory_region>;
> -	mboxes = <&mailbox0_cluster1 &mbox_mcu_r5fss0_core1>;
> +	mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
>  };
> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
> index d5e41bdc89c3..1fc93e0b3c9b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
> @@ -66,20 +66,18 @@ AM65X_IOPAD(0x001c, PIN_INPUT_PULLUP, 7)  /* (C23) GPIO1_89 */
>  
>  &main_gpio0 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <
> -		&main_m2_pcie_mux_control
> -		&arduino_io_d4_to_d9_pins_default
> -	>;
> +	pinctrl-0 =
> +		<&main_m2_pcie_mux_control>,
> +		<&arduino_io_d4_to_d9_pins_default>;
>  };
>  
>  &main_gpio1 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <
> -		&main_m2_enable_pins_default
> -		&main_pmx0_m2_config_pins_default
> -		&main_pmx1_m2_config_pins_default
> -		&cp2102n_reset_pin_default
> -	>;
> +	pinctrl-0 =
> +		<&main_m2_enable_pins_default>,
> +		<&main_pmx0_m2_config_pins_default>,
> +		<&main_pmx1_m2_config_pins_default>,
> +		<&cp2102n_reset_pin_default>;
>  };
>  
>  /*

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux