Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Jun 2023 13:57:14 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Tony Luck" <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Eric Biederman <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 6/6] x86/smp: Put CPUs into INIT on shutdown if possible
Message-ID: <ZHupKtSqj1LC911k@a4bf019067fa.jf.intel.com>
References: <20230603193439.502645149@linutronix.de>
 <20230603200459.947733085@linutronix.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230603200459.947733085@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ILTkIntzk7KE7WaORh33qGOI7y0KvdI9MbuV+S/fVhHWVHCWc3WkMxfdrAeR?=
 =?us-ascii?Q?pe7Ei/5ko3ZoroK7WHYLvXJVW3ILoTMueyK4spuDQMvaRA6VWKNnB9UBL5Ct?=
 =?us-ascii?Q?bSyaLMjcD4qAkgT0sNbIxU+8urJlYYNm5v8Qb6ZofWT5bPHYP/PqOdpJzGl2?=
 =?us-ascii?Q?k+49icD1sY8Bpgk8VJ0IymVIpNlNEdQ2uXQm7tZ2Xz3RMqj0pGVmnTT2BydT?=
 =?us-ascii?Q?xSZLB6vs3iRV0SB+/XFUepu/KQOhR+bZA8JVn7mTN5jUp3a7RFxTkDRi3s/m?=
 =?us-ascii?Q?slWx6psQl3oViN3/ajZlgqiBjDOkmVYkGOfp3EVN0VTIvvHeO8j5P/zuoGfQ?=
 =?us-ascii?Q?NvPxAp6UqtWI73CnXkx7fdRCy/49oeVywKtxwstLCzidAm1JrTeWoXYFKrjt?=
 =?us-ascii?Q?tMrWtP7vC8yuPj6YIgeVbHOVLdgV4n0kJ2BeUryw8GSjm90Hck1T+NynDihm?=
 =?us-ascii?Q?hr9l1vNLLsNTgYPoVtiks/MGe0plzw35cBkuMCyC2CCuWrBbU1drhFm/tYBQ?=
 =?us-ascii?Q?UO9MjjtaUij6ktgKanZjLFx3gxL0IegdGcRnFd/Zv+Qe68DV1zjc34KyYacS?=
 =?us-ascii?Q?1xce4CkYeveywu/FpA1vsLtvfNiPXUaTMHt1OG/DP9600Qll6lSNjh6YmbAC?=
 =?us-ascii?Q?igp3i/JAIy+fnOr4ALz1hPyUcwbl13vxCURknnmPsTqrcfrJD/7Zx7w9+J3j?=
 =?us-ascii?Q?IAQ5hK2l7dvtG/kEPKkVDKb8LrFViV+IQrYna+0uKTAbgZef7FU8qS9qi4NH?=
 =?us-ascii?Q?YAY6v4LMs22UTpuwKQPX06eFWnyzOOIFdm5FQV8gpG1eywPMXZu9H0OnxBTd?=
 =?us-ascii?Q?64isrGSaJLAgbTSAeV5j6iMmnPjQxvOzPRpC/u/j+f89PC+IvL+V4zRD4Bg5?=
 =?us-ascii?Q?t8iFGZkUobLE5WpcImZnQoiFlgxa027GhnXx5GpcRN1KJiuMWdU5fJ68FmJw?=
 =?us-ascii?Q?KkeDXNRTwrPh6j9Y1eQ6Zar3+a6vwGBgXqa3OH6B1YF6zSvsEQjwKzw0GQMn?=
 =?us-ascii?Q?Pi1JfCY1Cw8OPM7qCl9aI//Y/UA2P7/UySPBxdVj+Oe/I9dWT3qwAFxugodn?=
 =?us-ascii?Q?AV1AumtjPG+Yowe8y71X0xMs9uC67IzN+jOtI0Ahrd4eTY2uSCtyHekGKMNC?=
 =?us-ascii?Q?DFBuTPcVjAWBlvRQ0VHL/8UySMIQV9xlTaUk1MCsWBmCswWtQ2C2BJbXVFU7?=
 =?us-ascii?Q?Qw3jJxpHfOqDBGvqmb0eJGSMjIDuhgaqCtrQMW/sr/bCGAfdlzq4crFUpWKY?=
 =?us-ascii?Q?RXD5S9YDSZoZSVoEdumQvInrMEh88EKn85PwmhUVEKCJGVWDS7wUOtqoZ49Z?=
 =?us-ascii?Q?KeyVWL/4fNWTpF4c8czsXGXq0KrXdWN2/xCnJhW0PPdwx3/Zkqapadw4yPS7?=
 =?us-ascii?Q?LCPiR2kjJN4JKYrrTwBf0GzRxp1v4n7/yZCw6vch0pe0EW6LN5beiRwF8bXh?=
 =?us-ascii?Q?sfVs3cWa+o6p/U/OCBvRXSZxbJfbiVVLmC36EihgGs89BycqDQGH5jiRh7DW?=
 =?us-ascii?Q?cc14T/Lteh7TOWDDKP14sO6o+bv+vij3XqpqTzL9aXtTWLJqewjyrb8ZqcpG?=
 =?us-ascii?Q?kKgkWobkDSxx8SehVSvfKWOEtBC3SVQ9HNNE9hry?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 395a0886-cc12-4512-45e9-08db64751db2
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2023 20:57:17.6535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8gGFmEJONPaK4snLkzE/w1GUdH1TwCJ0xUXDW3FtLm26kdhXqP9jfHrMjKFgOg8HgCxP+GQQv8h38AoZwp0+Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5805
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 03, 2023 at 10:07:04PM +0200, Thomas Gleixner wrote:
> Parking CPUs in a HLT loop is not completely safe vs. kexec() as HLT can
> resume execution due to NMI, SMI and MCE, which has the same issue as the
> MWAIT loop.
> 
> Kicking the secondary CPUs into INIT makes this safe against NMI and SMI.
> 
> A broadcast MCE will take the machine down, but a broadcast MCE which makes
> HLT resume and execute overwritten text, pagetables or data will end up in
> a disaster too.
> 
> So chose the lesser of two evils and kick the secondary CPUs into INIT
> unless the system has installed special wakeup mechanisms which are not
> using INIT.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

For the whole series.

Reviewed-by: Ashok Raj <ashok.raj@intel.com>