Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dc340ad4-b6ab-0d38-af9d-697b396395c9@ti.com>
Date:   Sun, 4 Jun 2023 10:16:18 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
From:   "Kumar, Udit" <u-kumar1@ti.com>
Subject: Re: [PATCH v2 3/5] arm64: dts: ti: k3-j7200-common-proc-board:
 main_pmx0 clean up
To:     Nishanth Menon <nm@ti.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <conor+dt@kernel.org>, <m-chawdhry@ti.com>, <n-francis@ti.com>
References: <20230601093744.1565802-1-u-kumar1@ti.com>
 <20230601093744.1565802-4-u-kumar1@ti.com>
 <20230601104527.luzqw4m2aidsuw4x@booting>
Content-Language: en-US
In-Reply-To: <20230601104527.luzqw4m2aidsuw4x@booting>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks

On 6/1/2023 4:15 PM, Nishanth Menon wrote:
> On 15:07-20230601, Udit Kumar wrote:
>> Add main_uart0 pin mux in board common file
> $subject is a bit misleading.. I think the intent is to mux the console
> explicitly rather than a pinmux cleanup itself.

oops, missed to changed subject of this patch after split.

Will address in v3.


>> Signed-off-by: Udit Kumar<u-kumar1@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 0cc0e1dc40c5..02d2e4b36b18 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -113,6 +113,15 @@ J721E_IOPAD(0xd8, PIN_INPUT_PULLUP, 0) /* (W2) I2C0_SDA */
>>   		>;
>>   	};
>>   
>> +	main_uart0_pins_default: main_uart0_pins_default {
>> +		pinctrl-single,pins = <
>> +			J721E_IOPAD(0xb0, PIN_INPUT, 0) /* (T16) UART0_RXD */
>> +			J721E_IOPAD(0xb4, PIN_OUTPUT, 0) /* (T17) UART0_TXD */
>> +			J721E_IOPAD(0xc0, PIN_INPUT, 2) /* (W3) SPI0_CS0.UART0_CTSn */
>> +			J721E_IOPAD(0xc4, PIN_OUTPUT, 2) /* (U5) SPI0_CS1.UART0_RTSn */
>> +		>;
>> +	};
>> +
>>   	main_i2c1_pins_default: main-i2c1-pins-default {
>>   		pinctrl-single,pins = <
>>   			J721E_IOPAD(0xdc, PIN_INPUT_PULLUP, 3) /* (U3) ECAP0_IN_APWM_OUT.I2C1_SCL */
>> @@ -162,6 +171,8 @@ &main_uart0 {
>>   	status = "okay";
>>   	/* Shared with ATF on this platform */
>>   	power-domains = <&k3_pds 146 TI_SCI_PD_SHARED>;
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&main_uart0_pins_default>;
>>   };
>>   
>>   &main_uart1 {
>> -- 
>> 2.34.1
>>