Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 4 Jun 2023 11:55:00 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jianmin Lv <lvjianmin@loongson.cn>
Cc:     Liu Peibao <liupeibao@loongson.cn>,
        Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
        netdev@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org,
        Binbin Zhou <zhoubinbin@loongson.cn>,
        Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH pci] PCI: don't skip probing entire device if first fn OF
 node has status = "disabled"
Message-ID: <20230604085500.ioaos3ydehvqq24i@skbuf>
References: <20230601163335.6zw4ojbqxz2ws6vx@skbuf>
 <ZHjaq+TDW/RFcoxW@bhelgaas>
 <20230601221532.2rfcda4sg5nl7pzp@skbuf>
 <dc430271-8511-e6e4-041b-ede197e7665d@loongson.cn>
 <7a7f78ae-7fd8-b68d-691c-609a38ab3161@loongson.cn>
 <20230602101628.jkgq3cmwccgsfb4c@skbuf>
 <87f2b231-2e16-e7b8-963b-fc86c407bc96@loongson.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87f2b231-2e16-e7b8-963b-fc86c407bc96@loongson.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dDsxJmHSMo46tnRSanYbW1mBv5yu2U/nXD4+3z2gzcQFL9vETbzgJohcXP02?=
 =?us-ascii?Q?WwwwyF5rAZAZwsXXVvGDCnHBJ3vpDuAglZnCSgJyQV1aLTl6N8/vCIJo8I1N?=
 =?us-ascii?Q?xggb/TgbB/Bmw2bbW7SnYgbMiSqTgo3hGOTWyINIMpBk8PQdR942hRr9aRCT?=
 =?us-ascii?Q?bw8+4wdneLgzUvMBidL2dKInICNamwdZBcTgdDEY7ZsmB0Z0iflGwQ+w9Sng?=
 =?us-ascii?Q?4MxvkTIxIkrUK9Jq0F7+I4DaPgLI7tKmcxJRTuBvfR8edAL1IsKLkhatiup2?=
 =?us-ascii?Q?l+VQoZU2mMiv4plw3okyrewVZZAfpje2GDIYm0ImFphnB7kA9WWb1nBv8CWd?=
 =?us-ascii?Q?F1jbwqlOV40d1tmWUl/vF8Zq24iWhWi6d2ttwXe3etQRgzdhnHn7vODtcOfp?=
 =?us-ascii?Q?uH697DVlmZdEaVA2zQRM/Oz5sFis5Bb8Hjhb3JBqQrGGggnSQ/YYO3jlTAni?=
 =?us-ascii?Q?RQo19tJvjChdHyn2qUhQqZufyA90Ke+yVKbuzzvsoLUQMxg+j/4nOpj+LMCL?=
 =?us-ascii?Q?Fv4FOhMwhTKtRyXULq9IG/WLQHog+Xsix7pAXeKHXo8tFgwqfBHHQWzNhRx9?=
 =?us-ascii?Q?mIAtalfrP9zJOOjuFFns/VEp7BaDHG4nczGHoOZ8kihfy4rXcx6GOG+YDrEE?=
 =?us-ascii?Q?N3hPLqqULKh+ImTtUmCtdqqXMgFAgbjapHr8M2QY+bxGxQM9s3kXjOaQBcDc?=
 =?us-ascii?Q?t3ITF4/5DSyqSFIH5ONiWm3gEKAWEOkiEjwnXd3Ji0uaXX3PHrNM6qXvaIHJ?=
 =?us-ascii?Q?wpGhFa1yQaxu2vu8gbavCNLKeuysThULKSyy64faQWhShocItTv3EmevpFDs?=
 =?us-ascii?Q?apw3JBwEbMs+qiHVAvT5WYHzk6YnDnp3GZ/8xFcffjMstjGWaORHERdtZRb2?=
 =?us-ascii?Q?bfj7x+mAPI+x19kLrS7bh+GcvI+GSGl8Aom5ZDlKLKES9T04eLOweDLQz3Go?=
 =?us-ascii?Q?dkXXcPU20ML4MqrPo6ktAjOfjKpmXWfmIetH99xpoWZk+o9bWBBW14d2BETw?=
 =?us-ascii?Q?aCSQL3brEt/NmpAtDoT8o7xgq2/ImP5rnplB8/YG7m46B19Try4nPLovvSPD?=
 =?us-ascii?Q?Ayc+vZV1263LiydLC7F2fNJHYFl+qZ640GIdCQs3SWjTwL8xna76bof+XEpI?=
 =?us-ascii?Q?1/LDTPasloZcrh12ciXatEFjBpXmM83rcj4eAkg1f/7iC3QGPw8DtiPk29sn?=
 =?us-ascii?Q?9hLXTh9idu1zh7BUa0gb199ceSck0k3TluzXMsPp3u2pWcUdYE0dHc6kCdFl?=
 =?us-ascii?Q?qc/BwAZOVDA2ynkgYk7zhZryudW6fesKb2MD/sDXFdB7lda27y8ku+mfFjr7?=
 =?us-ascii?Q?HWVdycmURdCE4JqQsjFdVDAHfaJhFVKSiIx97gROF24wq0uzm++a3FlOaeNs?=
 =?us-ascii?Q?k7W7PL0IC0nWiHedUPg3xw1aje+/yP43BfGRnBbQvLDM2ANZiFdD6eFVj002?=
 =?us-ascii?Q?Dn1gYF/2G+YWNnNMM3iz5a1/eK0FN5lqDNEyR0WsgXJt+LKkeNWwC9bu0C72?=
 =?us-ascii?Q?fMA6/TrFwaoC9/TbGW4HoU5YLK+t/18H0VCBDZASFhMM5UMoHy4YjDU3IROt?=
 =?us-ascii?Q?MVZzOWLS58KNWWU5VQ5zJVY1ZAGnq36SrGf3FAuz657WomEbqe/TgZ5FQo8C?=
 =?us-ascii?Q?ew=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de2ea75c-1825-451b-23e3-08db64d96363
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2023 08:55:04.4484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IvKje3EF9+qiMbOnUBVGWlGko6DWlSPJipJw4xUmU4HSu9Oix5MhhtuEtHDnt0IuKuu6Cv768fP7uavW/OiXGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7618
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 03, 2023 at 10:35:50AM +0800, Jianmin Lv wrote:
> > How about 3. handle of_device_is_available() in the probe function of
> > the "loongson, pci-gmac" driver? Would that not work?
> > 
> This way does work only for the specified device. There are other devices,
> such as HDA, I2S, etc, which have shared pins. Then we have to add
> of_device_is_available() checking to those drivers one by one. And we are
> not sure if there are other devices in new generation chips in future. So
> I'm afraid that the way you mentioned is not suitable for us.

Got it, so you have more on-chip PCIe devices than the ones listed in
loongson64-2k1000.dtsi, and you don't want to describe them in the
device tree just to put status = "disabled" for those devices/functions
that you don't want Linux to use - although you could, and it wouldn't
be that hard or have unintended side effects.

Though you need to admit, in case you had an on-chip multi-function PCIe
device like the NXP ENETC, and you wanted Linux to not use function 0,
the strategy you're suggesting here that is acceptable for Loongson
would not have worked.

I believe we need a bit of coordination from PCIe and device tree
maintainers, to suggest what would be the encouraged best practices and
ways to solve this regression for the ENETC.