Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9b1e05a-6b32-3033-cbc4-c87bda711e4d@collabora.com>
Date:   Sun, 4 Jun 2023 15:54:24 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588
Content-Language: en-US
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, sebastian.reichel@collabora.com,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        gustavo.padovan@collabora.com, kernel@collabora.com,
        serge.broslavsky@collabora.com, Simon Xue <xxm@rock-chips.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        andy.shevchenko@gmail.com
References: <20230603185340.13838-1-shreeya.patel@collabora.com>
 <20230603185340.13838-3-shreeya.patel@collabora.com>
 <ZHunAIbK7-tIvsm1@surfacebook> <20230604112043.43b1ada0@jic23-huawei>
From:   Shreeya Patel <shreeya.patel@collabora.com>
In-Reply-To: <20230604112043.43b1ada0@jic23-huawei>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 04/06/23 15:50, Jonathan Cameron wrote:
> On Sat, 3 Jun 2023 23:48:00 +0300
> andy.shevchenko@gmail.com wrote:
>
>> Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti:
>>> From: Simon Xue <xxm@rock-chips.com>
>>>
>>> Add new start and read functions to support rk3588 device.
>>> Also, add a device compatible string for the same.
>> ...
>>
>>> +/* v2 registers */
>>> +#define SARADC2_CONV_CON		0x0
>>> +#define SARADC_T_PD_SOC			0x4
>>> +#define SARADC_T_DAS_SOC		0xc
>> Can you use fixed-width values for all registers?
>>
>> 	0x000
>> 	0x004
>> 	0x00c
>>
>>> +#define SARADC2_END_INT_EN		0x104
>>> +#define SARADC2_ST_CON			0x108
>>> +#define SARADC2_STATUS			0x10c
>>> +#define SARADC2_END_INT_ST		0x110
>>> +#define SARADC2_DATA_BASE		0x120
> I tidied this up whilst applying.

  Ah, I was just about to send a v4 with the change. Thank you for 
making the changes.


Regards,
Shreeya Patel


> Jonathan