Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4409502rwd; Sun, 4 Jun 2023 05:00:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4tLfEPbdl7hQtaGH89j8uryDZNz2wvOPm5W5gcxxrT8A5JnImk6ez1O1IfBb80d4ZpOUbU X-Received: by 2002:a05:6a00:2d10:b0:655:89f1:2db3 with SMTP id fa16-20020a056a002d1000b0065589f12db3mr3573742pfb.3.1685880027312; Sun, 04 Jun 2023 05:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685880027; cv=none; d=google.com; s=arc-20160816; b=KOXSKnS6u2zhcLGqSNZc5m/19by2+2z143UGIDZBtm/i4QNNUYsjIfWaVS8VdqPbJ1 TpqZ5IZLIUEU8uAqZuSJxq3jltmSuNGnlKb42S1b9bDyjMQF4FzN6qGONbAK5eBVogb9 PELuDsjR9SKxQ0WNkd5EtBhgv2ezVDGiNdJJ8EgKwNd7jk74mvpjMpFIAwzdYSR7aNRO P8OOLvoyskCz40Jd4Oes+PeeciqCbMqzAYsXVextPtUY8X3+Ck87+T9nitiaVXG3gon8 /WxAaKudpUTrubH1Sux5NJwSlKCNjzEKroP4V9rsI4A5VTb+OsstXWxpHJGT3t7G+CqY 3fxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QLADrVaabPGJ3NWJVuWmxsijZIk0hNnyyhdNddet8+E=; b=AGKVkK9r/benJwnBjTDCqOB8f7JPTPrWN/jQnT96Mod4rcTfdwAD0+wOaThN+7Ln1i dQTePFqfiCXlS2YPkrwAiHGct2NoSUYCYBQk15Diftf1qYrPT7jhOCbeHZ+pVgBMKhmf pV00907nxCrHzi1ICbKLEzLxm1qu4p4/2Msb6m8XoGxgMnWL/XpoFQewU/2uvWTBNy92 mwbTePTZJpsXKadje9s1YEcgp8oQXueXCjFEKkwQbOk82mO6Tlol1TyKfjf8+tXe1gZ3 CA49GXiJnzbJk3sR9pT+C4nep//5vytAVEGVaH4LHVm/RGd3LVQaxx4NgXHRbwJ54yxW UGEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KYq6RQ//"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y28-20020aa79e1c000000b006501b3c2009si3842998pfq.58.2023.06.04.05.00.08; Sun, 04 Jun 2023 05:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KYq6RQ//"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231135AbjFDLUX (ORCPT + 99 others); Sun, 4 Jun 2023 07:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjFDLUV (ORCPT ); Sun, 4 Jun 2023 07:20:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 665B2D2; Sun, 4 Jun 2023 04:20:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0144860C22; Sun, 4 Jun 2023 11:20:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E40EFC433EF; Sun, 4 Jun 2023 11:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685877619; bh=OsT04YCHMN5MqW4NW2NAHo0FOaoVoBBMNab3Jjr9zlM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KYq6RQ//h7A8/skmKmA3ol1phPbS39NKta5uWZH1E7E390eihXtXR0CX5p2XjLtaz W6/DwZOWtj6B6OmeFecr2hpB9YEUoeT6ThSSW7G/VL2uXqOXzVrZDDTKheASH2/mIT L3CVS0gOKJtI8lLJplLJ6aY2d4m7vNxKmOy5DS70k/feykKPYANTmmeuEBooUPXtiO IL5WlO2/P2xL8wmfDpDZBiYpnbADydbbc16AkrjuafYKjV1oPJx/PVvHQ9roVcQyYe BCGFgJiIgGIGGu5irpg0bE/upDylVNXsuDasnrHB4L5zJ73vLBP5qWZLYE5Ewvgnr/ 3ewTjkf8pGUcA== Date: Sun, 4 Jun 2023 12:20:15 +0100 From: Jonathan Cameron To: andy.shevchenko@gmail.com Cc: Astrid Rost , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com, Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Mathieu Othacehe Subject: Re: [PATCH v5 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 Message-ID: <20230604122015.38e7b8a5@jic23-huawei> In-Reply-To: References: <20230530142405.1679146-1-astrid.rost@axis.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Jun 2023 16:54:10 +0300 andy.shevchenko@gmail.com wrote: > Tue, May 30, 2023 at 04:23:58PM +0200, Astrid Rost kirjoitti: > > Add a more complete support for vncl4040 and vcnl4200, which allows to > > change the distance of proximity detection and interrupt support for the > > illuminance sensor. > >=20 > > Proximity functionality: > > - Interrupt support (new on vcnl4200). > >=20 > > Proximity reduce the amount of interrupts: > > - Adaptable integration time (new on vcnl4200) - the sampling rate > > changes according to this value. > > - Period - interrupt is asserted if the value is above or > > below a certain threshold. > >=20 > > Proximity change the activity distance: > > - Oversampling ratio - Amount of LED pulses per measured raw value. > > - Calibration bias - LED current calibration of the sensor. > >=20 > > Illuminance functionality: > > - Interrupt support. > >=20 > > Illuminance reduce the amount of interrupts: > > - Adaptable integration time - the sampling rate and scale changes > > according to this value. > > - Period =E2=80=93 interrupt is asserted if the value is above or > > below a certain threshold. =20 >=20 > It's a good work, thank you for doing it! >=20 > But it has a lot of small style and inconsistent issues. They are not maj= or > per se, but since there is more than 3, it makes sense to address. Also c= heck > if you can split your patches to two or three where it makes sense. >=20 FWIW nothing to add from me. Agree with Andy that we are down to style things that would be good to tidy up before applying these. Adding levels to switch nests always makes for ugly diffs so I fully agree with Andy that, though trivial, it is probably better to do those in two st= eps for ease of review. If there is just one in a patch then meh, we can proba= bly cope with the extra thinking required to review them , but where it happens several times it's worth making reviewer's lives that little bit easier! Jonathan