Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4443072rwd; Sun, 4 Jun 2023 05:36:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4WB/YJB3vZHEnMN/tzi/xAxcXqSOoxUke0i1xXCN/S7qc1EAWc0YrqIHmkotbgmm7gJPPR X-Received: by 2002:a17:90a:e006:b0:255:2dde:17cc with SMTP id u6-20020a17090ae00600b002552dde17ccmr4736887pjy.47.1685882164732; Sun, 04 Jun 2023 05:36:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685882164; cv=none; d=google.com; s=arc-20160816; b=E03Kp3a0+XOFGSuljvekhieIaiPwtTMhcAHVns2FMlg60bCHavGL3JjHTKAJCV9a8q yI7iU85VrGul3vsMlHgDrIOYUV20efSgFUBfTFIYvuKsCSXcLXSCf/EP18V77YWmi2Yk QOuEbBiK3mHXrQpE2I5TVqSVAZaQBNoJsfUnFHFBB1+vhyxQ2m3sXNGPuzgB4tP2hV9M Y+jn6YNntxIjM7XyqGMOeX9wNIeCN+PQnkXthJEOMBV8LhS+GISQdp93mA5ugy6lKiH5 ixfe2UAOxdhkCDCVegOhQNvRv8fyWcIJOYA5MZn2wE2+biHPHAjHR70aGSbiNZ1dq6Ax UjhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vV5xTrhhRF/gsD0u/8CRhs4Bd6wO0OZNjgk0BavwElQ=; b=w5yuSSM15mjXiSB5SRNYaz0Zzwy1YpStcaZLC5prMq7hQUgMYxQEJ6DQ6RjS6Im502 Tjw/qQgdQfgC6V151bPPKpJVHrqvfWD18j/gHU7jTTCScMnF0rmfJkpobVtGu0KRZKc7 GM8fpxZUHQohwHRcm0FclMrXxV8Iu1XR4NmQulQVTeEmBDPhKvo5+wkVwaSPkL2eLsWd BOd/DmroQO2Z86o6bJqqe0TSIQPy4Rh378Zjbc/XinvOSDRRKB1tywDNk5HtWMLqTfi2 6W7yRydCciFsrQY6WPQDtrILGBP/cJHBlvBnwrTUhpJWlD2lJAKJ4VDFBEC00YSFLVmb 1vRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOxvSeSF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a17090a4f0500b002565045f145si5829812pjh.122.2023.06.04.05.35.31; Sun, 04 Jun 2023 05:36:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOxvSeSF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230346AbjFDMe6 (ORCPT + 99 others); Sun, 4 Jun 2023 08:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjFDMe5 (ORCPT ); Sun, 4 Jun 2023 08:34:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F283C4; Sun, 4 Jun 2023 05:34:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EABBE61119; Sun, 4 Jun 2023 12:34:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53EABC4339C; Sun, 4 Jun 2023 12:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685882095; bh=VPuiAbVXnzzSjUdwZa0/ZBK9EReoHrt56iDrrh2Tl60=; h=From:To:Cc:Subject:Date:From; b=YOxvSeSF3qei8M2VFy4OYaRY+MFCwPusu/4irw2zK9Po8GO+9zBZ0J9TJMXkYye7g 2agfQDaDqKVqq58h4YMYHedEY3F2DRQMBuej/aXdqet4M+X4HFhmshF7uGPTBgCXRd ZFH5bn40LiGgI99j9aDkYxqP8ZjZIPChJCq4fEa8Gb2vAANYc1VCxgT6U2DKqgDNq6 WJoSGYhp3IFUUIdycPvqAEY7aOPQim2YVWuE+IVHIgYmonoSUEW0ILzVXuYCGC+9Tu gwlOZxKT5ZyDffvAGFSPtrLB16LwkrtpsdgYdSQO5Kd2KqIaDoYtcOSnqrD2Up0sjm o7CCHz04u1a5g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1q5mww-0001DS-FN; Sun, 04 Jun 2023 14:35:10 +0200 From: Johan Hovold To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Corey Minyard Subject: [PATCH v2 0/3] USB: serial: return errors from break handling Date: Sun, 4 Jun 2023 14:35:02 +0200 Message-Id: <20230604123505.4661-1-johan@kernel.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series starts returning errors from break handling and also uses that mechanism to report to user space when break signalling is not supported (e.g. when device or driver support is missing). Note that the tty layer currently returns early but without reporting errors when a tty driver does not support break signalling. The intent expressed in commit 9e98966c7bb9 ("tty: rework break handling") from 2008 appears to be to allow missing support to be reported to user space however. Johan Changes in v2 - fix return of potentially uninitialised status variable in io_edgeport as reported by kernel test robot and Dan Carpenter: https://lore.kernel.org/all/202306031014.qzAY3uQ6-lkp@intel.com/ Johan Hovold (3): USB: serial: return errors from break handling USB: serial: cp210x: disable break signalling on CP2105 SCI USB: serial: report unsupported break signalling drivers/usb/serial/ark3116.c | 7 +++-- drivers/usb/serial/belkin_sa.c | 12 ++++++--- drivers/usb/serial/ch341.c | 37 +++++++++++++++++---------- drivers/usb/serial/cp210x.c | 14 +++++++--- drivers/usb/serial/digi_acceleport.c | 7 ++--- drivers/usb/serial/f81232.c | 4 ++- drivers/usb/serial/f81534.c | 4 ++- drivers/usb/serial/ftdi_sio.c | 10 +++++--- drivers/usb/serial/io_edgeport.c | 6 +++-- drivers/usb/serial/io_ti.c | 9 +++++-- drivers/usb/serial/keyspan.c | 5 +++- drivers/usb/serial/keyspan_pda.c | 8 ++++-- drivers/usb/serial/mct_u232.c | 6 ++--- drivers/usb/serial/mos7720.c | 9 ++++--- drivers/usb/serial/mos7840.c | 7 ++--- drivers/usb/serial/mxuport.c | 6 ++--- drivers/usb/serial/pl2303.c | 14 ++++++---- drivers/usb/serial/quatech2.c | 8 ++++-- drivers/usb/serial/ti_usb_3410_5052.c | 10 +++++--- drivers/usb/serial/upd78f0730.c | 7 +++-- drivers/usb/serial/usb-serial.c | 4 +-- drivers/usb/serial/usb_debug.c | 13 +++++++--- drivers/usb/serial/whiteheat.c | 7 ++--- drivers/usb/serial/xr_serial.c | 4 +-- include/linux/usb/serial.h | 2 +- 25 files changed, 147 insertions(+), 73 deletions(-) -- 2.39.3