Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 4 Jun 2023 14:07:22 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     andy.shevchenko@gmail.com
Cc:     Andreas Klinger <ak@it-klinger.de>, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] iio: pressure: Honeywell mprls0025pa pressure
 sensor
Message-ID: <20230604140722.5eef740b@jic23-huawei>
In-Reply-To: <ZHPVn4xzErSZfqVy@surfacebook>
References: <ZGNpZM137jF5yzie@arbad>
        <ZGNp3SqyOJeEcLsj@arbad>
        <ZHPVn4xzErSZfqVy@surfacebook>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk


> 
> > +	if (dev_fwnode(dev)) {  
> 
> Why not simply use defaults?

Potential for inconsistent set if a firmware provides some but not others?
(at least that was my assumption that could well be wrong)

> 
> > +		ret = device_property_read_u32(dev, "honeywell,pmin-pascal",
> > +								&data->pmin);
> > +		if (ret)
> > +			return dev_err_probe(dev, ret,
> > +				"honeywell,pmin-pascal could not be read\n");
> > +		ret = device_property_read_u32(dev, "honeywell,pmax-pascal",
> > +								&data->pmax);
> > +		if (ret)
> > +			return dev_err_probe(dev, ret,
> > +				"honeywell,pmax-pascal could not be read\n");
> > +		ret = device_property_read_u32(dev,
> > +				"honeywell,transfer-function", &data->function);
> > +		if (ret)
> > +			return dev_err_probe(dev, ret,
> > +				"honeywell,transfer-function could not be read\n");
> > +		if (data->function > MPR_FUNCTION_C)
> > +			return dev_err_probe(dev, -EINVAL,