Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 4 Jun 2023 14:10:02 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Astrid Rost <astridr@axis.com>, Astrid Rost <astrid.rost@axis.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@axis.com,
        Uwe =?UTF-8?B?S2xlaW5lLUs=?= =?UTF-8?B?w7ZuaWc=?= 
        <u.kleine-koenig@pengutronix.de>,
        Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq
 vcnl4040/4200
Message-ID: <20230604141002.0b055c10@jic23-huawei>
In-Reply-To: <CAHp75VdZAGhrXgYf5EOE6MQ4DiseaxOqkjUs+X9jROB1aonD_g@mail.gmail.com>
References: <20230522142621.1680563-1-astrid.rost@axis.com>
        <20230522142621.1680563-5-astrid.rost@axis.com>
        <ZHPZlA5LM5h4xmp3@surfacebook>
        <ca146ce1-d3d3-e5eb-ac44-3afaec8ca6cc@axis.com>
        <CAHp75VdZAGhrXgYf5EOE6MQ4DiseaxOqkjUs+X9jROB1aonD_g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 29 May 2023 12:02:16 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, May 29, 2023 at 10:41=E2=80=AFAM Astrid Rost <astridr@axis.com> w=
rote:
> > Thanks for reviewing.
> > I can change this. But this is how it gets formatted by .clang-format. =
=20
>=20
> I would suggest to report the bug (in case it's not configurable) or
> configure to avoid such a misindentation.

I assume it's trading off line length against aligning with opening bracket=
s.
Maybe made the wrong decision, but it is not totally unreasonable to my eye=
s.
I don't care either way though, so go with whatever you have for next versi=
on!

Jonathan

>=20
> > On 5/29/23 00:45, andy.shevchenko@gmail.com wrote: =20
> > > Mon, May 22, 2023 at 04:26:18PM +0200, Astrid Rost kirjoitti: =20
> > >> Add support to configure ambient light sensor interrupts and thresho=
ld
> > >> limits for vcnl4040 and vcnl4200. If an interrupt is detected an eve=
nt
> > >> will be pushed to the event interface. =20
> > >
> > > ...
> > > =20
> > >> +            case IIO_EV_DIR_RISING:
> > >> +                    ret =3D i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_ALS_THDH_LM, val=
); =20
> > >
> > > Strange indentation.
> > > =20
> > >> +                    break;
> > >> +            case IIO_EV_DIR_FALLING:
> > >> +                    ret =3D i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_ALS_THDL_LM, val=
); =20
> > >
> > > Same.
> > > =20
> > >> +                    break; =20
> > >
> > > ...
> > > =20
> > >> +    case IIO_PROXIMITY:
> > >> +            switch (dir) {
> > >> +            case IIO_EV_DIR_RISING:
> > >> +                    ret =3D i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_PS_THDH_LM, val)=
; =20
> > >
> > > Same.
> > > =20
> > >> +                    break;
> > >> +            case IIO_EV_DIR_FALLING:
> > >> +                    ret =3D i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_PS_THDL_LM, val)=
; =20
> > >
> > > Same. =20
>=20